From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 89EC83858C2D for ; Tue, 11 Oct 2022 13:55:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 89EC83858C2D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 4DBBF1F8BF; Tue, 11 Oct 2022 13:55:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1665496526; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/7VH0LGHajwBzrdkaQVgd6ZRbv46GPgIMP3ZHbYi5AI=; b=wP7USYLnERHNFfGgF6pmJwpUvm331Y7g16zSY9ahdC1+oCcApBoOkfjaZxCAN4zP1gz8JG NClKer47uEFTKpACZiLpJs3pPzZ+5f6INSInRHTc8C/VTvl83PuYmSOEu+wkH6KD0zeotG PobftXxOOyCxwjQgt5gH38L+2WX67yk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1665496526; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/7VH0LGHajwBzrdkaQVgd6ZRbv46GPgIMP3ZHbYi5AI=; b=OOxn/5YVIvglzS+y+GeTKLGBwx9pIY/8ZK/2qozHLzA+zW8JxyZApMpJhaEYvXDPXRRN9b /jZrlCoAcA0R+KAw== Received: from wotan.suse.de (wotan.suse.de [10.160.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 3E46E2C141; Tue, 11 Oct 2022 13:55:26 +0000 (UTC) Received: by wotan.suse.de (Postfix, from userid 10510) id 33F82644C; Tue, 11 Oct 2022 13:55:26 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by wotan.suse.de (Postfix) with ESMTP id 32C786230; Tue, 11 Oct 2022 13:55:26 +0000 (UTC) Date: Tue, 11 Oct 2022 13:55:26 +0000 (UTC) From: Michael Matz To: =?ISO-8859-15?Q?J=F8rgen_Kvalsvik?= cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH 1/2] gcov: test switch/break line counts In-Reply-To: <20221011124303.99673-1-jorgen.kvalsvik@woven-planet.global> Message-ID: References: <20221011124303.99673-1-jorgen.kvalsvik@woven-planet.global> User-Agent: Alpine 2.20 (LSU 67 2015-01-07) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="-1609957120-2046319407-1665496526=:9510" X-Spam-Status: No, score=-8.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---1609957120-2046319407-1665496526=:9510 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Hello, On Tue, 11 Oct 2022, Jørgen Kvalsvik via Gcc-patches wrote: > The coverage support will under some conditions decide to split edges to > accurately report coverage. By running the test suite with/without this > edge splitting a small diff shows up, addressed by this patch, which > should catch future regressions. > > Removing the edge splitting: > > $ diff --git a/gcc/profile.cc b/gcc/profile.cc > --- a/gcc/profile.cc > +++ b/gcc/profile.cc > @@ -1244,19 +1244,7 @@ branch_prob (bool thunk) > Don't do that when the locuses match, so > if (blah) goto something; > is not computed twice. */ > - if (last > - && gimple_has_location (last) > - && !RESERVED_LOCATION_P (e->goto_locus) > - && !single_succ_p (bb) > - && (LOCATION_FILE (e->goto_locus) > - != LOCATION_FILE (gimple_location (last)) > - || (LOCATION_LINE (e->goto_locus) > - != LOCATION_LINE (gimple_location (last))))) > - { > - basic_block new_bb = split_edge (e); > - edge ne = single_succ_edge (new_bb); > - ne->goto_locus = e->goto_locus; > - } > + Assuming this is correct (I really can't say) then the comment needs adjustments. It specifically talks about this very code you remove. Ciao, Michael. ---1609957120-2046319407-1665496526=:9510--