From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 124060 invoked by alias); 22 Jul 2018 08:40:20 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 124046 invoked by uid 89); 22 Jul 2018 08:40:19 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=executed, apr, speaker, everywhere X-HELO: ainaz.pair.com Received: from ainaz.pair.com (HELO ainaz.pair.com) (209.68.2.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 22 Jul 2018 08:40:18 +0000 Received: from ainaz.pair.com (localhost [127.0.0.1]) by ainaz.pair.com (Postfix) with ESMTP id CE520B53E18; Sun, 22 Jul 2018 04:40:16 -0400 (EDT) Received: from anthias (vie-188-118-240-174.dsl.sil.at [188.118.240.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ainaz.pair.com (Postfix) with ESMTPSA id D1F0CB53E10; Sun, 22 Jul 2018 04:40:15 -0400 (EDT) Date: Sun, 22 Jul 2018 08:40:00 -0000 From: Gerald Pfeifer To: Martin Sebor cc: marxin , gcc-patches@gcc.gnu.org, Jan Hubicka , Nathan Sidwell Subject: Re: [PATCH 8/8] Enhance documentation of gcov. In-Reply-To: <694454c8-6039-9cb4-bcb8-ef210bbc7ea0@gmail.com> Message-ID: References: <6738b9023845d63ce1d1f9369c08a6f151d3766c.1493371589.git.mliska@suse.cz> <694454c8-6039-9cb4-bcb8-ef210bbc7ea0@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-IsSubscribed: yes X-SW-Source: 2018-07/txt/msg01223.txt.bz2 On Fri, 28 Apr 2017, Martin Sebor wrote: >> 2017-04-27 Martin Liska >> >> * doc/gcov.texi: Enhance documentation of gcov. > Since I started picking on this change set I might as well keep > at it ;) Just a tiny nit: the sentence is missing a preposition: > > depending on whether a basic block is reachable. This adds a bit more. Applied. (This section still needs a bit more love, ideally by a native speaker.) Gerald 2018-07-22 Gerald Pfeifer * doc/gcov.texi (Invoking Gcov): Editorial changes. Index: doc/gcov.texi =================================================================== --- doc/gcov.texi (revision 262161) +++ doc/gcov.texi (working copy) @@ -378,12 +378,12 @@ containing no code. Unexecuted lines are marked @samp{#####} or @samp{=====}, depending on whether they are reachable by non-exceptional paths or only exceptional paths such as C++ exception -handlers, respectively. Given @samp{-a} option, unexecuted blocks are +handlers, respectively. Given the @samp{-a} option, unexecuted blocks are marked @samp{$$$$$} or @samp{%%%%%}, depending on whether a basic block is reachable via non-exceptional or exceptional paths. Executed basic blocks having a statement with zero @var{execution_count} -end with @samp{*} character and are colored with magenta color with @option{-k} -option. The functionality is not supported in Ada. +end with @samp{*} character and are colored with magenta color with +the @option{-k} option. This functionality is not supported in Ada. Note that GCC can completely remove the bodies of functions that are not needed -- for instance if they are inlined everywhere. Such functions