From: Michael Matz <matz@suse.de>
To: "Martin Liška" <mliska@suse.cz>
Cc: Richard Biener <richard.guenther@gmail.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Come up with htab_hash_string_vptr and use string-specific if possible.
Date: Mon, 05 Nov 2018 18:37:00 -0000 [thread overview]
Message-ID: <alpine.LSU.2.21.1811051833050.21712@wotan.suse.de> (raw)
In-Reply-To: <35e46d42-e27a-dc77-922b-61c860cca6ff@suse.cz>
[-- Attachment #1: Type: text/plain, Size: 510 bytes --]
Hi,
On Fri, 2 Nov 2018, Martin Liška wrote:
> V2 of the patch.
>
> Thoughts?
Whereever the new function belongs it certainly isn't system.h. Also the
definition in a header seems excessive. Sure, it enables inlining of it,
but that seems premature optimization. It contains a loop, and inlining
anything with loops that aren't very likely to loop just once or never
just blows code for no gain. Also as the function is leaf there won't be
any second-order effect from inlining.
Ciao,
Michael.
next prev parent reply other threads:[~2018-11-05 18:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-31 17:32 Martin Liška
2018-11-02 8:03 ` Richard Biener
2018-11-02 8:10 ` Martin Liška
2018-11-02 9:25 ` Martin Liška
2018-11-05 18:37 ` Michael Matz [this message]
2018-11-07 8:54 ` Martin Liška
2018-11-08 13:15 ` Michael Matz
2018-11-08 13:41 ` Martin Liška
2018-11-09 13:28 ` Michael Matz
2018-11-12 9:35 ` Martin Liška
2018-11-12 13:43 ` Michael Matz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.21.1811051833050.21712@wotan.suse.de \
--to=matz@suse.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=mliska@suse.cz \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).