public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Gerald Pfeifer <gerald@pfeifer.com>
To: "Sandra Loosemore" <sandra@codesourcery.com>,
	"Martin Liška" <mliska@suse.cz>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [wwwdocs] Add no_sanitize attribute
Date: Sat, 29 Dec 2018 23:41:00 -0000	[thread overview]
Message-ID: <alpine.LSU.2.21.1812291104510.15084@anthias.pfeifer.com> (raw)
In-Reply-To: <2710ab96-47a9-e58b-62d8-43649974edda@suse.cz>

[-- Attachment #1: Type: text/plain, Size: 1578 bytes --]

On Sun, 7 Oct 2018, Sandra Loosemore wrote:
> This is definitely an improvement.  One more tweak I'd make is
> 
> s/any of the options specified/the options provided as arguments to the
> attribute/

Thank you, Sandra.  I made that additional change.

On Mon, 8 Oct 2018, Martin Liška wrote:
> Yes, it's equivalent, thanks for the improvement.

Thanks for the reviews.  I (finally) applied this per the patch below;
sorry for the delay.

Gerald

Index: changes.html
===================================================================
RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-8/changes.html,v
retrieving revision 1.97
diff -u -r1.97 changes.html
--- changes.html	30 Sep 2018 14:38:54 -0000	1.97
+++ changes.html	29 Dec 2018 21:08:04 -0000
@@ -251,11 +251,11 @@
     tests for pointer wrapping.
   </li>
   <li>
-    New <code>no_sanitize</code> attribute has been added.  The attribute
-    on functions is used to inform the compiler that it should
-    not do sanitization of all options mentioned in sanitize option.
-    A list of values acceptable by <code>-fsanitize</code> option can be
-    provided.
+    A new attribute <code>no_sanitize</code> can be applied to functions
+    to instruct the compiler not to do sanitization of the options
+    provided as arguments to the attribute. Acceptable values for
+    <code>no_sanitize</code> match those acceptable by the
+    <code>-fsanitize</code> command-line option.
     <blockquote><pre class="blackbg">
 void __attribute__ ((no_sanitize ("alignment", "object-size")))
 f () { /* Do something. */; }</pre></blockquote>

      reply	other threads:[~2018-12-29 21:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-18 12:22 Martin Liška
2018-04-27 23:26 ` Jeff Law
2018-10-07 12:53 ` Gerald Pfeifer
2018-10-07 19:37   ` Sandra Loosemore
2018-10-08  8:49   ` Martin Liška
2018-12-29 23:41     ` Gerald Pfeifer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LSU.2.21.1812291104510.15084@anthias.pfeifer.com \
    --to=gerald@pfeifer.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=mliska@suse.cz \
    --cc=sandra@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).