public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Gerald Pfeifer <gerald@pfeifer.com>
To: Paul Hua <paul.hua.gm@gmail.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [wwwdoc][Patch] Mention Loongson 3a1000 3a2000 3a3000 2k1000 support in gcc9
Date: Sun, 13 Jan 2019 23:46:00 -0000	[thread overview]
Message-ID: <alpine.LSU.2.21.1901140043130.5414@anthias.pfeifer.com> (raw)
In-Reply-To: <CAKjxQHkbwOD2pgu-gHdYgri-TSqmMGc-GNCB2aXSOh3dtfVVMA@mail.gmail.com>

Hi Paul,

On Mon, 31 Dec 2018, Paul Hua wrote:
> The attached patch mention Loongson 3a1000 3a2000 3a3000 2k1000 support 
> in gcc9.

thanks for putting this together.  Only a couple of editorial changes:

Index: changes.html
===================================================================
+  <li>
+    The Loongson <code>loongson-mmi</code> and <code>loongson-ext</code>
+    extension has now been splited from <code>loongson3a</code>:

"...extensions have been split..."

+    <ul>
+       <li><code>loongson-mmi</code> which contains 
+       the Loongson MultiMedia extension Instructions operations.</li>
+       <li><code>loongson-ext</code> which contains 
+       the Loongson EXTension instructions.</li>

Here I'd omit omit the two instances of "which"

+    The Loongson EXTension R2 instructions is now supported.

"is" -> "are"

+    Use -mxxx or -mno-xxx will enable or disable those extersions.

Since it's only two options, how about listing both of them?

"extersion" -> "extension"

+    for example: Using <code>-mloongson-mmi</code>/<code>-mno-loongson-mmi</code> 
+    will enable/disable Loongson MultiMedia Instructions extensions.

"...the Loongson MultiMedia Instructions extension."

+	which default enable <code>loongson-mmi</code>, <code>loongson-ext</code>.</li>

"which enables ... by default"  (also in the following two items)


Please look into those comments and then simply post the updated patch
as you're committing it.

Gerald

  parent reply	other threads:[~2019-01-13 23:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-31 12:32 Paul Hua
2019-01-12 10:50 ` Paul Hua
2019-01-13 23:46 ` Gerald Pfeifer [this message]
2019-01-17  2:05   ` Paul Hua
2019-04-04  5:02     ` Paul Hua
2023-01-16 20:07       ` Gerald Pfeifer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LSU.2.21.1901140043130.5414@anthias.pfeifer.com \
    --to=gerald@pfeifer.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=paul.hua.gm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).