From: Michael Matz <matz@suse.de>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Richard Biener <rguenther@suse.de>,
gcc-patches@gcc.gnu.org, law@redhat.com
Subject: Re: [PATCH][RFC] Improve get_qualified_type linear list walk
Date: Wed, 17 Apr 2019 12:10:00 -0000 [thread overview]
Message-ID: <alpine.LSU.2.21.1904171154580.8064@wotan.suse.de> (raw)
In-Reply-To: <20190416161445.GJ21066@tucnak>
Hi,
On Tue, 16 Apr 2019, Jakub Jelinek wrote:
> > + if (type1 == type2)
> > + return true;
> > + if (TYPE_MAIN_VARIANT (type1) != TYPE_MAIN_VARIANT (type2))
> > + return false;
>
> Is this second one correct though? Doesn't comptypes return for various
> cases true even if the TYPE_MAIN_VARIANT is different?
Right, that was a thinko. As I said, I rushed this somewhat :)
Ciao,
Michael.
next prev parent reply other threads:[~2019-04-17 11:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-16 13:01 Richard Biener
2019-04-16 16:14 ` Michael Matz
2019-04-16 16:21 ` Jakub Jelinek
2019-04-16 17:47 ` Richard Biener
2019-04-17 12:10 ` Michael Matz [this message]
2019-04-16 17:00 ` Richard Biener
2019-04-17 11:04 ` Richard Biener
2019-04-17 11:55 ` Michael Matz
2019-04-17 18:25 ` Jeff Law
2019-04-17 20:36 ` Marc Glisse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.21.1904171154580.8064@wotan.suse.de \
--to=matz@suse.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=law@redhat.com \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).