From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12644 invoked by alias); 17 Apr 2019 11:55:40 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 12628 invoked by uid 89); 17 Apr 2019 11:55:40 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mx1.suse.de Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 17 Apr 2019 11:55:39 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 2EF56ABE9; Wed, 17 Apr 2019 11:55:37 +0000 (UTC) Date: Wed, 17 Apr 2019 12:10:00 -0000 From: Michael Matz To: Jakub Jelinek cc: Richard Biener , gcc-patches@gcc.gnu.org, law@redhat.com Subject: Re: [PATCH][RFC] Improve get_qualified_type linear list walk In-Reply-To: <20190416161445.GJ21066@tucnak> Message-ID: References: <20190416161445.GJ21066@tucnak> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-IsSubscribed: yes X-SW-Source: 2019-04/txt/msg00704.txt.bz2 Hi, On Tue, 16 Apr 2019, Jakub Jelinek wrote: > > + if (type1 == type2) > > + return true; > > + if (TYPE_MAIN_VARIANT (type1) != TYPE_MAIN_VARIANT (type2)) > > + return false; > > Is this second one correct though? Doesn't comptypes return for various > cases true even if the TYPE_MAIN_VARIANT is different? Right, that was a thinko. As I said, I rushed this somewhat :) Ciao, Michael.