From: Michael Matz <matz@suse.de>
To: "Martin Liška" <mliska@suse.cz>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 5/9] Come up with an abstraction.
Date: Mon, 12 Aug 2019 13:40:00 -0000 [thread overview]
Message-ID: <alpine.LSU.2.21.1908121254120.25869@wotan.suse.de> (raw)
In-Reply-To: <ff5e17d8-da0f-e638-df2d-9aaf161bc059@suse.cz>
[-- Attachment #1: Type: text/plain, Size: 848 bytes --]
Hi,
On Mon, 12 Aug 2019, Martin Liška wrote:
> > You seem to need it only to have the possibility of virtual functions,
> > i.e. fancy callbacks. AFAICS you only have one derived class, i.e. a
> > simple distinction of two cases. What do you think about encoding the
> > additional new (ICF) case in the (existing) 'flags' argument to
> > operand_equal_p (and in case the ICF flag is set simply call the
> > "callback" directly)?
>
> That's possible. I can add two more callbacks to the operand_equal_p
> function (hash_operand_valueize and operand_equal_valueize).
That's premature; why provide callbacks when it's always either NULL or
a single value? What I meant is put code like this into operand_equal_p:
if (flags & OE_FOR_ICF)
op0 = oep_icf_valueize (op0);
...
Less indirection, less confusion.
Ciao,
Michael.
next prev parent reply other threads:[~2019-08-12 12:57 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-22 12:50 [RFC] operand_equal_p with valueization Jan Hubicka
2015-05-22 13:40 ` Richard Biener
2015-05-22 14:12 ` Jan Hubicka
2015-05-26 8:18 ` Richard Biener
2015-05-26 19:09 ` Jan Hubicka
2015-05-27 8:49 ` Richard Biener
2019-06-18 11:10 ` [RFC] " Martin Liška
2019-08-06 15:44 ` [PATCH 0/9] IPA ICF overhaul Martin Liska
2019-08-06 15:43 ` [PATCH 2/9] operand_equal_p: add support for FIELD_DECL Martin Liska
2019-08-07 12:21 ` Richard Biener
2019-08-15 14:19 ` Jan Hubicka
2019-08-16 9:28 ` Richard Biener
2019-08-16 12:17 ` Jan Hubicka
2019-09-11 12:58 ` Martin Liška
2019-08-06 15:43 ` [PATCH 4/9] Strengthen alias_ptr_types_compatible_p in LTO mode Martin Liska
2019-08-07 12:05 ` Richard Biener
2019-08-08 12:09 ` Martin Liška
2019-08-09 11:20 ` Richard Biener
2019-08-06 15:43 ` [PATCH 8/9] Remove comparison for polymorphic types Martin Liska
2019-08-06 15:43 ` [PATCH 1/9] Replace int with boolean in predicate functions Martin Liska
2019-08-07 12:38 ` Richard Biener
2019-08-06 15:43 ` [PATCH 7/9] IPA ICF: remove dead code Martin Liska
2019-08-08 14:44 ` Jeff Law
2019-08-06 15:43 ` [PATCH 6/9] Integrate that for IPA ICF Martin Liska
2019-08-16 11:10 ` Martin Liška
2019-08-06 15:43 ` [PATCH 9/9] Remove alias set comparison Martin Liska
2019-08-07 15:58 ` Martin Sebor
2019-08-08 8:43 ` Martin Liška
2019-08-08 15:21 ` Martin Sebor
2019-08-08 14:44 ` Jeff Law
2019-08-06 15:43 ` [PATCH 5/9] Come up with an abstraction Martin Liska
2019-08-08 16:29 ` Michael Matz
2019-08-12 11:49 ` Martin Liška
2019-08-12 12:27 ` Richard Biener
2019-08-12 12:43 ` Martin Liška
2019-08-12 13:26 ` Richard Biener
2019-08-12 14:48 ` Martin Liška
2019-08-14 13:17 ` Richard Biener
2019-08-14 13:50 ` Martin Liška
2019-08-14 14:38 ` Richard Biener
2019-08-16 11:06 ` Martin Liška
2019-09-18 7:56 ` Martin Liška
2019-09-19 11:30 ` Richard Biener
2019-08-12 13:40 ` Michael Matz [this message]
2019-08-09 11:48 ` Richard Biener
2019-08-06 15:55 ` [PATCH 3/9] operand_equal_p: add support for OBJ_TYPE_REF Martin Liska
2019-08-07 12:09 ` Richard Biener
2019-08-15 15:44 ` Jan Hubicka
2019-08-16 9:25 ` Richard Biener
2019-08-16 12:11 ` Jan Hubicka
2019-08-19 14:03 ` Richard Biener
2019-08-19 15:12 ` Jan Hubicka
2019-08-20 14:29 ` Richard Biener
2019-08-20 14:42 ` Jan Hubicka
2019-09-13 12:30 ` Martin Liška
2019-09-16 6:45 ` Richard Biener
2019-08-16 11:53 ` [PATCH 10/N] Use const_tree more in IPA ICF Martin Liška
2019-08-19 13:57 ` Richard Biener
2019-10-30 11:54 ` [PATCH 0/9] IPA ICF overhaul Martin Liška
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.21.1908121254120.25869@wotan.suse.de \
--to=matz@suse.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=mliska@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).