From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id 70A9B383D03B for ; Fri, 28 May 2021 15:33:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 70A9B383D03B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=matz@suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1622215989; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QpxW9UoVY6gs1VvC1sdJMx/L9zdyfPbIhxHOWjpPr4s=; b=T38KCuK+O6nze0Fxh02DOttn0DB+J+Tj8CQ8dL8DLYxXN+lbLVsCYokJbALv9Ri1Utstct O/Q6I4WlBdsylAkSeiAgcRjksvLwNj16L4SiJZtaAQaAE3rnnrCo/iMcRrCpo4ltl4O1ik SrkcLeekdBhCCK7mgDkMdRmQSrATAz8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1622215989; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QpxW9UoVY6gs1VvC1sdJMx/L9zdyfPbIhxHOWjpPr4s=; b=wIX0jr8xt50vFT/vcJkbqKRFjRz5DJ7ZpFF1t4z6VrRGI9OdBoipe+SDlDTzzAytwZq8WP z52eXJbQmIVxhoAg== Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 52443B251; Fri, 28 May 2021 15:33:09 +0000 (UTC) Date: Fri, 28 May 2021 15:33:09 +0000 (UTC) From: Michael Matz To: Bernd Edlinger cc: Andrew Pinski , Richard Biener , "gcc-patches@gcc.gnu.org" Subject: Re: [PATCH] Generate gimple-match.c and generic-match.c earlier In-Reply-To: Message-ID: References: User-Agent: Alpine 2.22 (LSU 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 May 2021 15:33:13 -0000 Hello, On Fri, 28 May 2021, Bernd Edlinger wrote: > >> I was wondering, why gimple-match.c and generic-match.c > >> are not built early but always last, which slows down parallel > >> makes significantly. > >> > >> The reason seems to be that generated_files does not > >> mention gimple-match.c and generic-match.c. > >> > >> This comment in Makefile.in says it all: > >> > >> $(ALL_HOST_OBJS) : | $(generated_files) > >> > >> So this patch adds gimple-match.c generic-match.c to generated_files. > >> > >> > >> Tested on x86_64-pc-linux-gnu. > >> Is it OK for trunk? > > > > This should help for what I was complaining about in > > https://gcc.gnu.org/pipermail/gcc/2021-May/235963.html . I build with > > -j24 and it was stalling on compiling gimple-match.c for me. > > Looks like insn-attrtab.c is missed too; I saw genattrtab was running last too. > > > > Yeah, probably insn-automata.c as well, sometimes it is picked up early > sometimes not. maybe $(simple_generated_c) should be added to > generated_files, but insn-attrtab.c is yet another exception. You can't put files in there that are sometimes slow to generate (which insn-{attrtab,automata}.c are on some targets), as _everything_ then waits for them to be created first. Ideally there would be a way for gnumake to mark some targets as "ugh-slow" and back-propagate this to all dependencies so that those are put in front of the work queue in a parallel make. Alas, something like that never came into existence :-/ (When order-only deps were introduced I got excited, but then came to realize that that wasn't what was really needed for this case, a "weak" version of it would be required at least, or better yet a specific facility to impose a cost with a target) Ciao, Michael. > > > Bernd. > > > Thanks, > > Andrew > > > >> > >> > >> Thanks > >> Bernd. > >> > >> > >> 2021-05-28 Bernd Edlinger > >> > >> * Makefile.in (generated_files): Add gimple-match.c and > >> generic-match.c >