From: Ranjit Mathew <rmathew@hotmail.com>
To: gcc-patches@gcc.gnu.org
Cc: java-patches@gcc.gnu.org
Subject: Re: Patch: FYI: gcjh and JNIEXPORT
Date: Thu, 07 Nov 2002 21:01:00 -0000 [thread overview]
Message-ID: <aqfg8q$nrf$1@main.gmane.org> (raw)
In-Reply-To: <871y5yqruh.fsf@fleche.redhat.com>
Tom Tromey wrote:
> /* When printing a JNI header we need to respect the space. In
> other cases we're just going to insert a newline anyway. */
> fputs (need_space && ! stubs ? " " : "\n", stream);
> +
> + if (flag_jni && ! stubs)
> + fputs ("JNICALL ", stream);
Shouldn't you also check "is_method && !is_init"?
stdcall is a calling convention and is valid only for methods
not fields.
stdcall does not seem to be valid for constructors as well.
Sincerely Yours,
Ranjit.
--
Ranjit Mathew Email: rmathew AT hotmail DOT com
Bangalore, INDIA. Web: http://ranjitmathew.tripod.com/
next prev parent reply other threads:[~2002-11-08 5:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-06 14:09 Tom Tromey
2002-11-07 21:01 ` Ranjit Mathew [this message]
2002-11-07 21:03 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='aqfg8q$nrf$1@main.gmane.org' \
--to=rmathew@hotmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=java-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).