From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 777CD3858C33 for ; Fri, 2 Sep 2022 03:23:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 777CD3858C33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0098421.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 2823FCYO013233; Fri, 2 Sep 2022 03:23:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pp1; bh=3jYJOtE+gzwY2sH73FibXfW3HvY1k5Cjcip/DY6xkQk=; b=P5k0CuoAItWh4hxbPEQ+Vsa9Kg1FA84oyXLDTnZgvlF2dRqyP6xbvViTZzfxq6slN7JH OSDgiUFDAw9cg4myLPZ+mz1VFSrX1g6+hgumBY5V9Tpn23cLSlet7FbfuJuKH9WI6sbm VPpQCCAUnauLwGwKxvPijVrWqZBCtAnPMZBnYpO16ZjhixJ2+yAO+nSJH4iF8wut6tTs rmFSuIMz0DEvl3lYXOLQ+x9TDUS8cQzjH2CjFaL9PJpuBIooozmmNhZzHuQ6kPNTJqiR jAxeTkkDgZH39TXYk0WwtJx9j1ADgyTxnbNrJcFbBhUCfKQp3k1dl5Tx8RmDYGInIY6K 8Q== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3jb9rv86k9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 02 Sep 2022 03:23:35 +0000 Received: from m0098421.ppops.net (m0098421.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 2823FDvj013252; Fri, 2 Sep 2022 03:23:35 GMT Received: from ppma06ams.nl.ibm.com (66.31.33a9.ip4.static.sl-reverse.com [169.51.49.102]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3jb9rv86jg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 02 Sep 2022 03:23:35 +0000 Received: from pps.filterd (ppma06ams.nl.ibm.com [127.0.0.1]) by ppma06ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 2823LgLW014062; Fri, 2 Sep 2022 03:23:33 GMT Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by ppma06ams.nl.ibm.com with ESMTP id 3j7ahj7k5x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 02 Sep 2022 03:23:33 +0000 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 2823NUge36110666 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 2 Sep 2022 03:23:30 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 738E25204E; Fri, 2 Sep 2022 03:23:30 +0000 (GMT) Received: from [9.200.43.154] (unknown [9.200.43.154]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTP id 8F4685204F; Fri, 2 Sep 2022 03:23:28 +0000 (GMT) Message-ID: Date: Fri, 2 Sep 2022 11:23:26 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v2, rs6000] Put dg-options before effective target checks Content-Language: en-US To: "Kewen.Lin" Cc: Segher Boessenkool , David , Peter Bergner , gcc-patches References: <20055172-6ec9-6055-c02a-9f91b26e0296@linux.ibm.com> <64ddbbb8-0838-6aaf-0b09-d6de92e32f1c@linux.ibm.com> From: HAO CHEN GUI In-Reply-To: <64ddbbb8-0838-6aaf-0b09-d6de92e32f1c@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: E2bGqVjLwtJQAvGP9TGvhJ0pj24C0uJo X-Proofpoint-ORIG-GUID: kkuvRfH9t1jBHR7oegUljC0WvZ0JbvpZ Content-Transfer-Encoding: 8bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-09-01_12,2022-08-31_03,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 malwarescore=0 suspectscore=0 impostorscore=0 spamscore=0 phishscore=0 lowpriorityscore=0 mlxscore=0 bulkscore=0 mlxlogscore=807 priorityscore=1501 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000 definitions=main-2209020013 X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,KAM_SHORT,NICE_REPLY_A,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Kewen, On 1/9/2022 下午 5:34, Kewen.Lin wrote: > Thanks for the updated patch! > > I just found that it seems all the three test cases suffer the empty > TU error issue from those has_arch* effective target checks? > > If yes, it looks we don't need to bother this once patch [1] gets > landed? > > Sorry, I didn't notice and ask when reviewing the previous version. > > [1] https://gcc.gnu.org/pipermail/gcc-patches/2022-July/598748.html Yes, those 3 test cases all suffer from "empty translation unit" problem. My patch just has an side effect which avoid "empty translation unit" problem. But the real problem is still there. pr92398.p9+.c has another problem. It's a compiling case and it should be compiled on any platform when "-mdejagnu-cpu=power9" is set in dg-options or RUNTESTFLAGS. Putting dg-options before "has_arch_pwr9" check achieves this target. Thanks Gui Haochen