public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Kai Tietz <ktietz@redhat.com>
To: gcc-patches@gcc.gnu.org
Cc: Richard Guenther <richard.guenther@gmail.com>
Subject: [patch tree-optimization]: allow branch-cost optimization for truth-and/or on mode-expanded simple boolean-operands
Date: Thu, 20 Oct 2011 14:25:00 -0000	[thread overview]
Message-ID: <b022acb6-081a-498f-90e2-7e66bfd6901f@zmail14.collab.prod.int.phx2.redhat.com> (raw)
In-Reply-To: <7d649d85-73fa-4c37-bd6e-d3527500196b@zmail14.collab.prod.int.phx2.redhat.com>

Hello,

this patch re-enables the branch-cost optimization on simple boolean-typed operands, which are casted to a wider integral type.  This happens due casts from
boolean-types are preserved, but FE might expands simple-expression to wider mode.

I added two tests for already working branch-cost optimization for IA-architecture and
two for explicit checking for boolean-type.

ChangeLog

2011-10-20  Kai Tietz  <ktietz@redhat.com>

        * fold-const.c (simple_operand_p_2): Handle integral
        casts from boolean-operands.

2011-10-20  Kai Tietz  <ktietz@redhat.com>

        * gcc.target/i386/branch-cost1.c: New test.
        * gcc.target/i386/branch-cost2.c: New test.
        * gcc.target/i386/branch-cost3.c: New test.
        * gcc.target/i386/branch-cost4.c: New test.

Bootstrapped and regression tested on x86_64-unknown-linux-gnu for all languages including Ada and Obj-C++.  Ok for apply?

Regards,
Kai

Index: gcc-head/gcc/testsuite/gcc.target/i386/branch-cost2.c
===================================================================
--- /dev/null
+++ gcc-head/gcc/testsuite/gcc.target/i386/branch-cost2.c
@@ -0,0 +1,16 @@
+/* { dg-do compile } */
+/* { dg-options "-O2 -fdump-tree-gimple -mbranch-cost=2" } */
+
+extern int doo (void);
+
+int
+foo (int a, int b)
+{
+  if (a && b)
+   return doo ();
+  return 0;
+}
+
+/* { dg-final { scan-tree-dump-times "if " 1 "gimple" } } */
+/* { dg-final { scan-tree-dump-times " & " 1 "gimple" } } */
+/* { dg-final { cleanup-tree-dump "gimple" } } */
Index: gcc-head/gcc/testsuite/gcc.target/i386/branch-cost3.c
===================================================================
--- /dev/null
+++ gcc-head/gcc/testsuite/gcc.target/i386/branch-cost3.c
@@ -0,0 +1,16 @@
+/* { dg-do compile } */
+/* { dg-options "-O2 -fdump-tree-gimple -mbranch-cost=2" } */
+
+extern int doo (void);
+
+int
+foo (_Bool a, _Bool b)
+{
+  if (a && b)
+   return doo ();
+  return 0;
+}
+
+/* { dg-final { scan-tree-dump-times "if " 1 "gimple" } } */
+/* { dg-final { scan-tree-dump-times " & " 1 "gimple" } } */
+/* { dg-final { cleanup-tree-dump "gimple" } } */
Index: gcc-head/gcc/testsuite/gcc.target/i386/branch-cost4.c
===================================================================
--- /dev/null
+++ gcc-head/gcc/testsuite/gcc.target/i386/branch-cost4.c
@@ -0,0 +1,16 @@
+/* { dg-do compile } */
+/* { dg-options "-O2 -fdump-tree-gimple -mbranch-cost=0" } */
+
+extern int doo (void);
+
+int
+foo (_Bool a, _Bool b)
+{
+  if (a && b)
+   return doo ();
+  return 0;
+}
+
+/* { dg-final { scan-tree-dump-times "if " 2 "gimple" } } */
+/* { dg-final { scan-tree-dump-not " & " "gimple" } } */
+/* { dg-final { cleanup-tree-dump "gimple" } } */
Index: gcc-head/gcc/fold-const.c
===================================================================
--- gcc-head.orig/gcc/fold-const.c
+++ gcc-head/gcc/fold-const.c
@@ -3706,6 +3706,19 @@ simple_operand_p_2 (tree exp)
   /* Strip any conversions that don't change the machine mode.  */
   STRIP_NOPS (exp);
 
+  /* Handle integral widening casts from boolean-typed
+     expressions as simple.  This happens due casts from
+     boolean-types are preserved, but FE might expands
+     simple-expression to wider mode.  */
+  if (INTEGRAL_TYPE_P (TREE_TYPE (exp))
+      && CONVERT_EXPR_P (exp)
+      && TREE_CODE (TREE_TYPE (TREE_OPERAND (exp, 0)))
+	 == BOOLEAN_TYPE)
+    {
+      exp = TREE_OPERAND (exp, 0);
+      STRIP_NOPS (exp);
+    }
+
   code = TREE_CODE (exp);
 
   if (TREE_SIDE_EFFECTS (exp)
Index: gcc-head/gcc/testsuite/gcc.target/i386/branch-cost1.c
===================================================================
--- /dev/null
+++ gcc-head/gcc/testsuite/gcc.target/i386/branch-cost1.c
@@ -0,0 +1,16 @@
+/* { dg-do compile } */
+/* { dg-options "-O2 -fdump-tree-gimple -mbranch-cost=0" } */
+
+extern int doo (void);
+
+int
+foo (int a, int b)
+{
+  if (a && b)
+   return doo ();
+  return 0;
+}
+
+/* { dg-final { scan-tree-dump-times "if " 2 "gimple" } } */
+/* { dg-final { scan-tree-dump-not " & " "gimple" } } */
+/* { dg-final { cleanup-tree-dump "gimple" } } */

       reply	other threads:[~2011-10-20 13:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <7d649d85-73fa-4c37-bd6e-d3527500196b@zmail14.collab.prod.int.phx2.redhat.com>
2011-10-20 14:25 ` Kai Tietz [this message]
2011-10-21  9:52   ` Richard Guenther
2011-10-21 12:40     ` Kai Tietz
2011-10-23 10:11       ` Richard Guenther

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b022acb6-081a-498f-90e2-7e66bfd6901f@zmail14.collab.prod.int.phx2.redhat.com \
    --to=ktietz@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=richard.guenther@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).