From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 71249 invoked by alias); 14 Apr 2017 17:01:43 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 67639 invoked by uid 89); 14 Apr 2017 17:01:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1047 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 14 Apr 2017 17:01:40 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6D81880F9F; Fri, 14 Apr 2017 17:01:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 6D81880F9F Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=law@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 6D81880F9F Received: from localhost.localdomain (ovpn-116-10.phx2.redhat.com [10.3.116.10]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2B3EC62925; Fri, 14 Apr 2017 17:01:40 +0000 (UTC) Subject: Re: [PATCH] Fix newlib build failure for mips16 To: gcc-patches , rdsandiford@googlemail.com References: <8ae83192-929a-a677-639e-100e036672a0@redhat.com> <87efwvw7vw.fsf@googlemail.com> <46ac2419-b3cb-6895-6ae6-5d9d0cff3aa8@redhat.com> <87y3v3ufc9.fsf@googlemail.com> From: Jeff Law Message-ID: Date: Fri, 14 Apr 2017 17:09:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <87y3v3ufc9.fsf@googlemail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg00680.txt.bz2 On 04/14/2017 10:24 AM, Richard Sandiford wrote: > > I think it only does that if the "containing object" that you're > validating is a MEM. If the object you're validating is an insn > (which it always is for regcprop) then normal constrain_operands > does happen. Hmm, you've of course right! > >>> Adding code to do that to individual MIPS patterns feels like a hack to me. >>> The pass should be doing it itself. >> Agreed. It's a hack. But it was the best I could see to do at this stage. > > Been looking at it a bit more, and I think the problem is that we're > somehow ending up with a second stack pointer rtx, distinct from > stack_pointer_rtx. And then I remembered that this had been discussed > before, see the tail end of: > > https://gcc.gnu.org/ml/gcc-patches/2016-01/msg02362.html > > I'd be happier with the mips_stack_address_p change described there, > although it still seems like a hack. Let me dig a little further. Two stack pointers just sounds fundamentally wrong. jeff