From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 7FB493858C27 for ; Fri, 30 Jun 2023 17:28:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7FB493858C27 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0353724.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35UHRbXM014304; Fri, 30 Jun 2023 17:28:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pp1; bh=weVbwMUWRaNN4VXB6N5fDIZzfPWFj+ATjIG+F8LYCbU=; b=RdKKF0tc5ed4INth6V2a16f82HmS3xQ4ogO56w1m9SrepkiVbg+7dbHc3wZ4z1qkRnUP 238Hj6tr7p7Wor7nRecRSALNJjNQh4vwZ4GiMBAx9xbeJFDddXF/hDoetlqURnT/Smvt wdn0W2vgtkA6TAakomc1tA00E00vN+YR5aYu2nHlViU5CiF/tmlhedysNyCVYQAfG1As YRekxiw1zrkYZfDDfPoQiKnIa2NcIs9aebNImMv3ccwZSVbmyUe2BcJk+ohkfacvcuXz 9DxNQYmdEqWrhUjdyiaqNhEpkJnCfVYp/R+jcSQlW3Y9pmf2EZ9TQv8IPZ50ekLiie1p nw== Received: from ppma02wdc.us.ibm.com (aa.5b.37a9.ip4.static.sl-reverse.com [169.55.91.170]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3rj3fh0055-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 30 Jun 2023 17:28:12 +0000 Received: from pps.filterd (ppma02wdc.us.ibm.com [127.0.0.1]) by ppma02wdc.us.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 35UFvRnp023978; Fri, 30 Jun 2023 17:28:11 GMT Received: from smtprelay02.dal12v.mail.ibm.com ([9.208.130.97]) by ppma02wdc.us.ibm.com (PPS) with ESMTPS id 3rdr46h7mn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 30 Jun 2023 17:28:11 +0000 Received: from smtpav01.dal12v.mail.ibm.com (smtpav01.dal12v.mail.ibm.com [10.241.53.100]) by smtprelay02.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 35UHSBDm27591292 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 30 Jun 2023 17:28:11 GMT Received: from smtpav01.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E941858058; Fri, 30 Jun 2023 17:28:10 +0000 (GMT) Received: from smtpav01.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 948E358057; Fri, 30 Jun 2023 17:28:10 +0000 (GMT) Received: from [9.61.31.25] (unknown [9.61.31.25]) by smtpav01.dal12v.mail.ibm.com (Postfix) with ESMTP; Fri, 30 Jun 2023 17:28:10 +0000 (GMT) Message-ID: Date: Fri, 30 Jun 2023 12:28:10 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 1/2] go: update usage of TARGET_AIX to TARGET_AIX_OS Content-Language: en-US To: Ian Lance Taylor Cc: "Paul E. Murphy" , gcc-patches References: <20230616160002.1854983-1-murphyp@linux.ibm.com> From: Peter Bergner In-Reply-To: Content-Type: text/plain; charset=UTF-8 X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: ZXj8OPdfNwbjlph-aS885SLdklvQ9bYM X-Proofpoint-GUID: ZXj8OPdfNwbjlph-aS885SLdklvQ9bYM Content-Transfer-Encoding: 8bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-06-30_09,2023-06-30_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 priorityscore=1501 lowpriorityscore=0 impostorscore=0 spamscore=0 adultscore=0 mlxlogscore=999 bulkscore=0 clxscore=1011 malwarescore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306300147 X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/22/23 10:30 PM, Ian Lance Taylor wrote: > On Thu, Jun 22, 2023, 4: 47 PM Peter Bergner wrote: On 6/22/23 6: 37 PM, Peter Bergner via Gcc-patches wrote: > On 6/16/23 > >> On Fri, Jun 16, 2023 at 9:00 AM Paul E. Murphy via Gcc-patches > >> > wrote: > >>> > >>> TARGET_AIX is defined to a non-zero value on linux and maybe other > >>> powerpc64le targets.  This leads to unexpected behavior such as > >>> dropping the .go_export section when linking a shared library > >>> on linux/powerpc64le. > >>> > >>> Instead, use TARGET_AIX_OS to toggle AIX specific behavior. > >>> > >>> Fixes golang/go#60798. > >>> > >>> gcc/go/ChangeLog: > >>> > >>>         * go-backend.cc [TARGET_AIX]: Rename and update usage to > >>>         TARGET_AIX_OS. > >>>         * go-lang.cc: Likewise. > >> > >> This is OK. > >> > >> Thanks. > >> > >> Ian > > > > I pushed this to trunk for Paul. > > I see this is broken on the release branches too.  Are backports ok > after some burn-in on trunk? > > Yes.  Thanks. Ok, I backported the Go fix to GCC 13, 12, 11 and 10 (before the 10.5 freeze). I also backported to the rust change to GCC 13, which was the first release with rust. Thanks. Peter