From: "Martin Liška" <mliska@suse.cz>
To: Sebastian Huber <sebastian.huber@embedded-brains.de>,
gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] gcov: Reword comment for gcov_read_string()
Date: Thu, 31 Mar 2022 08:57:42 +0200 [thread overview]
Message-ID: <b0951eea-26fc-50c9-8485-64272ba191c5@suse.cz> (raw)
In-Reply-To: <20220331065500.25015-1-sebastian.huber@embedded-brains.de>
On 3/31/22 08:55, Sebastian Huber wrote:
> gcc/
>
> * gcov-io.cc (gcov_read_string): Reword documentation comment.
> ---
> gcc/gcov-io.cc | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/gcc/gcov-io.cc b/gcc/gcov-io.cc
> index c2e9e2b6d64..72c40f8eaa0 100644
> --- a/gcc/gcov-io.cc
> +++ b/gcc/gcov-io.cc
> @@ -473,9 +473,9 @@ mangle_path (char const *base)
> /* We need to expose the below function when compiling for gcov-tool. */
>
> #if !IN_LIBGCOV || defined (IN_GCOV_TOOL)
> -/* Read string from coverage file. Returns a pointer to a static
> - buffer, or NULL on empty string. You must copy the string before
> - calling another gcov function. */
> +/* Read string from coverage file. Allocate the buffer for the string
> + from the heap or die. Return a pointer to the string, or NULL on
> + empty string. */
>
> GCOV_LINKAGE const char *
> gcov_read_string (void)
Ready for master, thanks!
Martin
prev parent reply other threads:[~2022-03-31 6:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-31 6:55 Sebastian Huber
2022-03-31 6:57 ` Martin Liška [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0951eea-26fc-50c9-8485-64272ba191c5@suse.cz \
--to=mliska@suse.cz \
--cc=gcc-patches@gcc.gnu.org \
--cc=sebastian.huber@embedded-brains.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).