From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 5EC693858C50 for ; Thu, 31 Mar 2022 06:57:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5EC693858C50 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 34B42210DB; Thu, 31 Mar 2022 06:57:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1648709863; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0pX5AK7Mo93l8Z8/Cp1oXvTnJfAYxSWYJWMCAQcUvSA=; b=1l1NHpLhR0vUrUwLJBAlruSItIZ4B1gkbDj4AVyXDmuBXzFIMMNIZokkgDGMUZ3GNiXoOK Y/vylwlorZJLmTccJtylCnUmxXNHfuNMugRVW/b3yjTWEv4d3Gc+qwXJBwLu0bREgZY9gb vmJlcUehEcKUFiMHI6oPlOPjzViVOas= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1648709863; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0pX5AK7Mo93l8Z8/Cp1oXvTnJfAYxSWYJWMCAQcUvSA=; b=ViXehnUXwFgs2A4+DMVPm+fUmok8qOiKwKyjG4ZzfAjP11TqMVrjT70bFxiX1FmFP6LL+S d7LPLN1QkdUz/2Dg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 21BB2139C2; Thu, 31 Mar 2022 06:57:43 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id A6TzBOdQRWL8UwAAMHmgww (envelope-from ); Thu, 31 Mar 2022 06:57:43 +0000 Message-ID: Date: Thu, 31 Mar 2022 08:57:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] gcov: Reword comment for gcov_read_string() Content-Language: en-US To: Sebastian Huber , gcc-patches@gcc.gnu.org References: <20220331065500.25015-1-sebastian.huber@embedded-brains.de> From: =?UTF-8?Q?Martin_Li=c5=a1ka?= In-Reply-To: <20220331065500.25015-1-sebastian.huber@embedded-brains.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Mar 2022 06:57:49 -0000 On 3/31/22 08:55, Sebastian Huber wrote: > gcc/ > > * gcov-io.cc (gcov_read_string): Reword documentation comment. > --- > gcc/gcov-io.cc | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/gcc/gcov-io.cc b/gcc/gcov-io.cc > index c2e9e2b6d64..72c40f8eaa0 100644 > --- a/gcc/gcov-io.cc > +++ b/gcc/gcov-io.cc > @@ -473,9 +473,9 @@ mangle_path (char const *base) > /* We need to expose the below function when compiling for gcov-tool. */ > > #if !IN_LIBGCOV || defined (IN_GCOV_TOOL) > -/* Read string from coverage file. Returns a pointer to a static > - buffer, or NULL on empty string. You must copy the string before > - calling another gcov function. */ > +/* Read string from coverage file. Allocate the buffer for the string > + from the heap or die. Return a pointer to the string, or NULL on > + empty string. */ > > GCOV_LINKAGE const char * > gcov_read_string (void) Ready for master, thanks! Martin