From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by sourceware.org (Postfix) with ESMTPS id 12B1F3858C2B for ; Thu, 20 Jul 2023 07:41:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 12B1F3858C2B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-3fc0aecf107so3276005e9.2 for ; Thu, 20 Jul 2023 00:41:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689838869; x=1690443669; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:cc:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Kw7uSgnxDNs/b7GVzrMhlf/JEuPbc7RYPrc9/Mrk/Hk=; b=Rfs/Z7u4V2JsFSeDVJXAjhg74oo8YboRtbLyHZPBQVfcv0rL4FFLwdBYyczXuhwfuq +rkxaeEiRF/23TB2AR0qeToqtDO5UvX/l9HSAeyyuiKh7Msc846TNCDsc0xxg8vRnU7b Ioqq1l2dQVELfmHi/kY08sii3aYs669Ei6a/lD5SCNYPqOPuHV64p0mTCX5xppMvnQEf fZtvCDP99SEOA4cZ1RuEwPKhQTv8qzqHvQ8B4s7UBXkZMehAkGG9jWJAkH0UfpeyGK/2 g3ALGjT012y3H7jn+mMthurP//5wBggS7rZ2H8dZAmGuj9V3us1si21x0kHfsRGo8fcS A9uA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689838869; x=1690443669; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:cc:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Kw7uSgnxDNs/b7GVzrMhlf/JEuPbc7RYPrc9/Mrk/Hk=; b=D/iYWxHcmHNv6MZthAN/yid+PZINbf41tJ4NIgedfjy2LcDeCse6JXOcAFjlYi/QlF bq1iQS7ZoZ6k1yhv/K/ss0DK/Tsg5M+s8sY/zr6kgiVPEegzp5EgrXwNa5oOvml42Dhl e7ELx6Q/Fl0hhgPHOONwoBejm3Zt9sa0aOhEBrX4hNTkapuizkmQhbhPC7eKkW5Kho8g lDoxem8A0WYsOqzdRnFdUc2Ryh/hOwIfEjyheHhvrCll7N+qczIVB1UENmfhQ1+NyJoR 8TWIzbSiQOjBeRKUgwPQzajEmmLiSk48UoIxnoZmgvmfyJUHogdxh6ewxHiOEdBubER4 3r3g== X-Gm-Message-State: ABy/qLaCdCdDJjeMv1gfl5TSMUIJsJzNRDOqcaBy6fUFobgqWcXStQU4 QtLb4W6Ahmit5pMdvpNxSNs= X-Google-Smtp-Source: APBJJlEBZTCK+dr5slgvxqf3rpAh7gZ66ziXzpUdhVsau0iZ8ek65120WioKRiJ7oxMCkJuwR1x8og== X-Received: by 2002:a05:600c:231a:b0:3fb:a62d:1992 with SMTP id 26-20020a05600c231a00b003fba62d1992mr1123346wmo.0.1689838869514; Thu, 20 Jul 2023 00:41:09 -0700 (PDT) Received: from [192.168.1.23] (ip-046-005-130-086.um12.pools.vodafone-ip.de. [46.5.130.86]) by smtp.gmail.com with ESMTPSA id p26-20020a7bcc9a000000b003fbc0a49b57sm522401wma.6.2023.07.20.00.41.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Jul 2023 00:41:09 -0700 (PDT) Message-ID: Date: Thu, 20 Jul 2023 09:41:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: rdapp.gcc@gmail.com, kito.cheng@gmail.com, kito.cheng@sifive.com, jeffreyalaw@gmail.com Subject: Re: [PATCH] RISC-V: Support in-order floating-point reduction Content-Language: en-US To: Juzhe-Zhong , gcc-patches@gcc.gnu.org References: <20230720073406.239379-1-juzhe.zhong@rivai.ai> From: Robin Dapp In-Reply-To: <20230720073406.239379-1-juzhe.zhong@rivai.ai> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > +enum reduction_type > +{ > + UNORDERED_REDUDUCTION, > + FOLD_LEFT_REDUDUCTION, > + MASK_LEN_FOLD_LEFT_REDUDUCTION, > +}; There are redundant 'DU's here ;) Wouldn't it be sufficient to have an enum enum reduction_type { UNORDERED, FOLD_LEFT, MASK_LEN_FOLD_LEFT, }; ? Regards Robin