public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "Martin Liška" <mliska@suse.cz>
To: gcc-patches@gcc.gnu.org
Cc: Jan Hubicka <hubicka@ucw.cz>
Subject: [PATCH] ipa: "naked" attribute implies "noipa" attribute
Date: Fri, 13 Aug 2021 11:14:07 +0200	[thread overview]
Message-ID: <b0e740ff-b0f4-65ef-3f08-da881f5afd32@suse.cz> (raw)

Hi.

This is a first part fixing the PR. It makes sense making "naked" functions "noipa".
What's missing is IPA MOD pass support where the pass should not optimize fns
with "noipa" attributes.

@Honza: Can you please implement that?

Patch can bootstrap on x86_64-linux-gnu and survives regression tests.

Ready to be installed?
Thanks,
Martin

	PR ipa/101354

gcc/ChangeLog:

	* attribs.c (decl_attributes): Make naked functions "noipa"
	  functions.
---
  gcc/attribs.c | 11 +++--------
  1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/gcc/attribs.c b/gcc/attribs.c
index afa485ed37d..e149f5b66dd 100644
--- a/gcc/attribs.c
+++ b/gcc/attribs.c
@@ -517,14 +517,9 @@ decl_attributes (tree *node, tree attributes, int flags,
    if (TREE_CODE (*node) == FUNCTION_DECL
        && attributes
        && lookup_attribute ("naked", attributes) != NULL
-      && lookup_attribute_spec (get_identifier ("naked")))
-    {
-      if (lookup_attribute ("noinline", attributes) == NULL)
-	attributes = tree_cons (get_identifier ("noinline"), NULL, attributes);
-
-      if (lookup_attribute ("noclone", attributes) == NULL)
-	attributes = tree_cons (get_identifier ("noclone"),  NULL, attributes);
-    }
+      && lookup_attribute_spec (get_identifier ("naked"))
+      &&(lookup_attribute ("noipa", attributes) == NULL))
+	attributes = tree_cons (get_identifier ("noipa"), NULL, attributes);
  
    /* A "noipa" function attribute implies "noinline", "noclone" and "no_icf"
       for those targets that support it.  */
-- 
2.32.0


             reply	other threads:[~2021-08-13  9:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-13  9:14 Martin Liška [this message]
2021-08-13 10:31 ` Jan Hubicka
2021-08-13 14:03   ` Martin Liška
2021-08-16  6:15 ` Richard Biener
2021-08-16  6:16   ` Richard Biener

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b0e740ff-b0f4-65ef-3f08-da881f5afd32@suse.cz \
    --to=mliska@suse.cz \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=hubicka@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).