From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 129223 invoked by alias); 4 Oct 2018 14:17:13 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 129210 invoked by uid 89); 4 Oct 2018 14:17:13 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=ISTM, meetings, Hx-languages-length:1022, istm X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 04 Oct 2018 14:17:11 +0000 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D21A82E606F; Thu, 4 Oct 2018 14:17:09 +0000 (UTC) Received: from localhost.localdomain (ovpn-112-4.rdu2.redhat.com [10.10.112.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 577C1308BDA4; Thu, 4 Oct 2018 14:17:08 +0000 (UTC) Subject: Re: [PATCH] Redirect call within specific target attribute among MV clones (PR ipa/82625). To: =?UTF-8?Q?Martin_Li=c5=a1ka?= , gcc-patches@gcc.gnu.org References: <70b0358c-5060-b5c0-9116-3b4e8e0b5146@suse.cz> From: Jeff Law Openpgp: preference=signencrypt Message-ID: Date: Thu, 04 Oct 2018 14:34:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <70b0358c-5060-b5c0-9116-3b4e8e0b5146@suse.cz> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2018-10/txt/msg00272.txt.bz2 On 10/4/18 7:56 AM, Martin Liška wrote: > Hi. > > When having a pair of target clones where foo calls bar, if the target > attribute are equal we can redirect the call and not use ifunc dispatcher. > > Patch survives regression tests on x86_64-linux-gnu. > Ready for trunk? > > Martin > > gcc/ChangeLog: > > 2018-10-04 Martin Liska > > PR ipa/82625 > * multiple_target.c (redirect_to_specific_clone): New function. > (ipa_target_clone): Use it. > * tree-inline.c: Fix comment. > > gcc/testsuite/ChangeLog: > > 2018-10-04 Martin Liska > > PR ipa/82625 > * g++.dg/ext/pr82625.C: New test. Your timing is good. The issues with unnecessary calls to ifunc dispatchers when we have an ifunc that is not a leaf in the call graph came up in some meetings I was having last week. I doubt this is enough to address all the issues folks raised, but ISTM it should certainly help. OK for the trunk. Jeff