From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 383DD3858C83 for ; Wed, 19 Oct 2022 18:37:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 383DD3858C83 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666204663; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ShRTfX2A8ejLKmQrxFmlJy5C2r8hS5sbjKUdnysentQ=; b=fJrb7D46N8oQVBayKrdLwXZmq+HhiDJx2yE1Lxqo6id7q23LYFcyXGbboMXsnKnAi1gXeH t107OgjwNSyKiv41aZVOK5HQRYKEomcIw4foxDtN3xcsHOG0WPk0WdZ1wW4hgQ8cZT4ST6 vniWFSDw6urG5OklKYp8l6ZGhoMDYXA= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-590-ix2-L7eAMLCY3CkSd9zX6Q-1; Wed, 19 Oct 2022 14:37:41 -0400 X-MC-Unique: ix2-L7eAMLCY3CkSd9zX6Q-1 Received: by mail-qt1-f199.google.com with SMTP id bz12-20020a05622a1e8c00b0039ae6e887ffso13317501qtb.8 for ; Wed, 19 Oct 2022 11:37:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ShRTfX2A8ejLKmQrxFmlJy5C2r8hS5sbjKUdnysentQ=; b=mpUPgzinmNIEsxTIoOhHy9xCKfYDMlTdosidxtVqMRO50ITDnHJ7Adfihx0OD1Gjve 2a3heIa0f+PexnWpuvJFbFXMpiN4d1Y501D4qY/+uqGTG3ihg/PwEdQtcS8PrCYau+Fb Um/aapNFTDHxCy+t/JXXKzwDDrH3jmM8B4EFjq1d9vnl0uBrALCHCLIJBy+4CR/7j5Nj kOs4TmbokxFb8IJoJAWzjkrqf4/8A3oowM4mgcIhWaqDyUm4iy9h9JG9F5kBWBQrIuY2 VrkqzG98Pl2o/UgueNeH/8PPdXN5wJd8lTc4DFl1rdtyyxiN4TxUBkyFYFzlcVA35of7 9gAg== X-Gm-Message-State: ACrzQf2hp0Q7kgwQHyCGp+JAkUmmhjvMEesuFaRCd97Pz/WbsXCnedaX ku+JoJJdse7ixo85R1uWail9OHRFWODq00qeevc0+/LPoh/pDcsMwlIX1+oCvzgWsxDWtGHkdmC 8B84KGuBEz7Nv3YAM8g== X-Received: by 2002:ae9:e417:0:b0:6ec:a8d4:29ae with SMTP id q23-20020ae9e417000000b006eca8d429aemr6435173qkc.550.1666204660759; Wed, 19 Oct 2022 11:37:40 -0700 (PDT) X-Google-Smtp-Source: AMsMyM50QqUZdNINPUvGSo8eSfmc6x/gdEzhppzMyqY1ul+9BRqbzMZoV0QWGf4mp23bJd0xx9dQQg== X-Received: by 2002:ac8:7f09:0:b0:39c:e8ce:aefa with SMTP id f9-20020ac87f09000000b0039ce8ceaefamr7803030qtk.353.1666204649471; Wed, 19 Oct 2022 11:37:29 -0700 (PDT) Received: from [192.168.1.101] (130-44-159-43.s15913.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.159.43]) by smtp.gmail.com with ESMTPSA id u12-20020a05620a454c00b006ce2c3c48ebsm5403120qkp.77.2022.10.19.11.37.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Oct 2022 11:37:28 -0700 (PDT) Message-ID: Date: Wed, 19 Oct 2022 14:37:23 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH v2] c++: Mitigate -Wuseless-cast with classes [PR85043] To: Marek Polacek Cc: GCC Patches References: <20221018173829.392773-1-polacek@redhat.com> <84d8cddc-79f5-3920-fd34-4b2b28010363@redhat.com> From: Jason Merrill In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/19/22 12:38, Marek Polacek wrote: > On Wed, Oct 19, 2022 at 09:27:27AM -0400, Jason Merrill wrote: >> On 10/18/22 13:38, Marek Polacek wrote: >>> -Wuseless-cast (not part of -Wall/-Wextra) warns here: >>> >>> struct S { }; >>> void g (S&&); >>> void f (S&& arg) >>> { >>> g (S(arg)); // warning: useless cast to type 'struct S' >>> } >>> >>> which is wrong: the code will not compile without the cast because >>> "arg" is an lvalue which cannot bind to S&&. >>> >>> I'd like to disable the warning when a class object is cast to >>> a non-reference type, which seems like a minimal patch that fixes the >>> problems reported in our Bugzilla. Of course, the cast in "(int)i" >>> may not be useless, either, but I'm not changing that here. >> >> As I commented on PR 14710, "I wouldn't warn about a cast that changes the >> type or value category of an expression at all...." > > Ah, I didn't see that comment. > >> The code currently checks the value category when casting to a reference, >> but not when casting to a non-reference; that seems like the thing to fix. > > OK, how about this? The nice thing is that it handles non-classes as well, > while we still warn about truly useless casts as in "X(X{})". Thanks, > > Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk? > > -- >8 -- > -Wuseless-cast (not part of -Wall/-Wextra) warns here: > > struct S { }; > void g (S&&); > void f (S&& arg) > { > g (S(arg)); // warning: useless cast to type 'struct S' > } > > which is wrong: the code will not compile without the cast because > "arg" is an lvalue which cannot bind to S&&. > > This patch disables the warning when an object that isn't a prvalue > is cast to a non-reference type. Therefore we still warn about the > useless cast in "X(X{})". > > PR c++/85043 > > gcc/cp/ChangeLog: > > * typeck.cc (maybe_warn_about_useless_cast): Don't warn when > a glvalue is cast to a non-reference type. > > gcc/ChangeLog: > > * doc/invoke.texi: Update documentation of -Wuseless-cast. > > gcc/testsuite/ChangeLog: > > * g++.dg/warn/Wuseless-cast.C: Remove dg-warning. > * g++.dg/warn/Wuseless-cast3.C: New test. > --- > gcc/cp/typeck.cc | 4 ++- > gcc/doc/invoke.texi | 13 +++++++++- > gcc/testsuite/g++.dg/warn/Wuseless-cast.C | 12 ++++----- > gcc/testsuite/g++.dg/warn/Wuseless-cast3.C | 29 ++++++++++++++++++++++ > 4 files changed, 50 insertions(+), 8 deletions(-) > create mode 100644 gcc/testsuite/g++.dg/warn/Wuseless-cast3.C > > diff --git a/gcc/cp/typeck.cc b/gcc/cp/typeck.cc > index da0e1427b97..8e1d14ee6b0 100644 > --- a/gcc/cp/typeck.cc > +++ b/gcc/cp/typeck.cc > @@ -8108,7 +8108,9 @@ maybe_warn_about_useless_cast (location_t loc, tree type, tree expr, > && (TYPE_REF_IS_RVALUE (type) > ? xvalue_p (expr) : lvalue_p (expr)) > && same_type_p (TREE_TYPE (expr), TREE_TYPE (type))) > - || same_type_p (TREE_TYPE (expr), type)) > + /* Don't warn when converting a class object to a non-reference type, > + because that's a common way to create a temporary. */ > + || (!glvalue_p (expr) && same_type_p (TREE_TYPE (expr), type))) Might use ?: instead of || so we check this only when !TYPE_REF_P. OK with that change. > warning_at (loc, OPT_Wuseless_cast, > "useless cast to type %q#T", type); > } > diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi > index c176e2dc646..cd4d3c1d72c 100644 > --- a/gcc/doc/invoke.texi > +++ b/gcc/doc/invoke.texi > @@ -4551,7 +4551,18 @@ pointers after reallocation. > @item -Wuseless-cast @r{(C++ and Objective-C++ only)} > @opindex Wuseless-cast > @opindex Wno-useless-cast > -Warn when an expression is casted to its own type. > +Warn when an expression is cast to its own type. This warning does not > +occur when a class object is converted to a non-reference type as that > +is a way to create a temporary: > + > +@smallexample > +struct S @{ @}; > +void g (S&&); > +void f (S&& arg) > +@{ > + g (S(arg)); // make arg prvalue so that it can bind to S&& > +@} > +@end smallexample > > @item -Wno-conversion-null @r{(C++ and Objective-C++ only)} > @opindex Wconversion-null > diff --git a/gcc/testsuite/g++.dg/warn/Wuseless-cast.C b/gcc/testsuite/g++.dg/warn/Wuseless-cast.C > index 2fd6bc45102..d7cb89930a6 100644 > --- a/gcc/testsuite/g++.dg/warn/Wuseless-cast.C > +++ b/gcc/testsuite/g++.dg/warn/Wuseless-cast.C > @@ -62,11 +62,11 @@ A prvalue(); > > void f() > { > - int n; > + int n; > > - (int)(n); // { dg-warning "3:useless cast" } > - static_cast(n); // { dg-warning "3:useless cast" } > - reinterpret_cast(n); // { dg-warning "3:useless cast" } > + (int)(n); > + static_cast(n); > + reinterpret_cast(n); > > (int*)(&n); // { dg-warning "3:useless cast" } > const_cast(&n); // { dg-warning "3:useless cast" } > @@ -100,8 +100,8 @@ void f() > > A a; > > - (A)(a); // { dg-warning "3:useless cast" } > - static_cast(a); // { dg-warning "3:useless cast" } > + (A)(a); > + static_cast(a); > > (A*)(&a); // { dg-warning "3:useless cast" } > const_cast(&a); // { dg-warning "3:useless cast" } > diff --git a/gcc/testsuite/g++.dg/warn/Wuseless-cast3.C b/gcc/testsuite/g++.dg/warn/Wuseless-cast3.C > new file mode 100644 > index 00000000000..43dd2ebfaea > --- /dev/null > +++ b/gcc/testsuite/g++.dg/warn/Wuseless-cast3.C > @@ -0,0 +1,29 @@ > +// PR c++/85043 > +// { dg-do compile { target c++11 } } > +// { dg-options "-Wuseless-cast" } > + > +struct S { int s; void bump () { s++; } }; > + > +void > +foo () > +{ > + S s = { 1 }; > + s.bump (); > + S (s).bump (); // { dg-bogus "useless" } > + ((S) s).bump (); // { dg-bogus "useless" } > + static_cast (s).bump (); // { dg-bogus "useless" } > +} > + > +struct X { }; > +void g(X&&); > + > +void > +f (X&& arg) > +{ > + g(X(arg)); // { dg-bogus "useless" } > + g(X(X{})); // { dg-warning "useless" } > + g(static_cast(arg)); > + > + int i = (int) 1; // { dg-warning "useless" } > + const int &r = (int) i; // { dg-bogus "useless" } > +} > > base-commit: 69a233610f6b27cd4283561569d8ce0f35044dc4