From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on2052.outbound.protection.outlook.com [40.107.6.52]) by sourceware.org (Postfix) with ESMTPS id 5F4833858D20 for ; Thu, 27 Apr 2023 07:39:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5F4833858D20 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HIuhu3IZnyRsb/u2QFrrB3q67whAdNbucwhUhZ45xnfcVMtxVGMZyFAkDexZHvJl9fpbp2yGY5OQmnC5OkOxoEDzsRGv6rghuRvr9yVwp+wj9y7R59Ne7QwdXIbn+lbRBJWn0w9zt5zwb7f9nSNsPu4lSdvgazSyVjVYKMG7z/fTRZ/8tmiAflqy9C0ubFFNfs59Ih6oNXBnsPFLEYilFHpbyjPM8jp5VIT0xBt2MkNr1FG7hCavsDdS+zdP3ZQwBfxrSivpj/6JDgR19Je7uutVmOaZ1P5DQW5RuT1dez6l8t2kcI+xuGaGzoL/hH3KDp6tjCyhZdIk5LTMSzCfyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Iz9kpPoPGbbP2ouz5xyRKzDPPVhu9bxVkbCayaUjQHo=; b=IoXx0UWqGK7wXBysEaRE+lJvgctIuiN7siQ/vd1xzmDUXrArMmEyoSTUMgSiMo6PJ8EvX3AFwGipthpedGdeQfSpiHBxZNwjHyl+mB3gqLzviRzIFzXwyOg4iF58q7xhZZ7QUUcC4Er+GgTIBAMWDfSusYj2CA4HrLGkpJVXqyhwbRAMvw36nDGaqXaUasz86UlxmEntNs4DaAVBKY+0gjgFbPW8T7UJzdQwFUKJ9NvHnf6IAJ8SUK3jr4tRHIdUG1vXRjQMV7z4SPUEw6N11QABZ81DBwmnHwmAkOhFMaEzXVyr8hzE8oaZP/q/RlFaHD6S4Gdku2G3ZliQUBA29g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Iz9kpPoPGbbP2ouz5xyRKzDPPVhu9bxVkbCayaUjQHo=; b=Xpybj89Z1cD7rLVjOJ3Xt2QeRPvda6dNcNqKM4FsZlSYrnhJVArswt92ZW0NXslffWZDNS374VeYfmGq47+iUGCQRw75nC7srYm4dHbo8/bSwxF7kRzpN0bRxpSgJnxfcBg+1kl+uA65uV58g0cx7gshQOXqsFC6l5SkVNqvPIhqQyS7mh1PfJWcvC/qH/f4syC8NfxDm3DzUsnpTjJX7OTQLZ7xTU4NAtvdVwl72QY9K9h1WY8WD9MpuGUGzL8dU7Q8yv484b5agcP22EWbQrUPzn5DBe0xBL+LZDCHxuDiMcUJM0conu2ugslLxUraF/E2/7CqQtEuOA8lmMF1kQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB7870.eurprd04.prod.outlook.com (2603:10a6:102:b8::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.22; Thu, 27 Apr 2023 07:39:48 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae%2]) with mapi id 15.20.6319.033; Thu, 27 Apr 2023 07:39:48 +0000 Message-ID: Date: Thu, 27 Apr 2023 09:39:46 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH] testsuite: adjust NOP expectations for RISC-V Content-Language: en-US To: Palmer Dabbelt Cc: ro@CeBiTec.Uni-Bielefeld.DE, mikestump@comcast.net, gcc-patches@gcc.gnu.org References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0251.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:af::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB7870:EE_ X-MS-Office365-Filtering-Correlation-Id: b3c8f79d-29cf-4bae-a1e2-08db46f293ac X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Mv0SF4au4HYOu7jcgulXtHq9CdfqKdTTfyCm5h/6t+QMfdEQXQuO7fUPrb5VGrmSMuq222AC2OjaQcjMK3pfGczGT3UGRsiZ2DEaXIF7YBxmCG5SKtdYHacc36w9jBrCxEbndUH/M+IeUJC6M8DIBFE0V9nB6V87TgLEREOUY5Zh6M9VOCvr0PWlzl3q1fBVL21Mrsba1nHfPdnQ2GjyxsYwVii0roxjmn2OpiPd54nRALGFQeGaICIl+8vI6xjqaEEuD7YBcgfRLVEsoyxOockX2uj2RhSyaqBHO313y4r0QYOApw/YZyW3a7o+5b9wNrZl37X67+KP+i/x4+rZo2T89Wvha38Cugxm9DPg2ZP+m3MWvF3G8ePKBY7vgkkahJxh3mRIqRb1vO8shAVb0rHkjjmLRhZe3iYGs2pTRQ3p9BuXluD61KtYe2zNwpTwqi27Ip11teLpU5EsBDxLfnsmyX0Bqu8Qu9p034ykzzsJSGhI3USLEsvD+nHt9uXY50hv0lqY/MwngzmJcpi4Kv9pp6NJ/vocB4sz/JPfcOy8I4Ub+tjkTHxNA5Xv5QFlvxSxJVvHX6fX/zmQsbpFR2GIZJZiEP6anAcQPXIc11oQcI1kUhmnYXFhF0DJtGkWGxbwVDTvklKQ1mm8KmYoYg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(396003)(366004)(136003)(39860400002)(346002)(451199021)(478600001)(36756003)(38100700002)(8676002)(8936002)(5660300002)(2906002)(6916009)(41300700001)(316002)(66476007)(66556008)(66946007)(4326008)(31696002)(26005)(6506007)(31686004)(2616005)(86362001)(186003)(53546011)(6512007)(6486002)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WW9zS1Rkd29UMVh3aGNFV2djdUxyUGE1cXRyR2puK3hqU1B4WkI3VkxIajJG?= =?utf-8?B?aHBJUjFzS25nM2Y4MVc0QVBpL0JIMjZTZkNZM1p4TUp4N2VtZ2E3NkJPQ2FW?= =?utf-8?B?eGNFWnV5aG5qQ3RWM295dTNsdTdUdE5ZV0lUT2FxVlkwdEdNT0FscmhUdkd4?= =?utf-8?B?TlFCdENiTDVJeGF2b0lpZmo5N1d3dUpveVZwV3I5RmNtNFV4SkRZYnlpa0o0?= =?utf-8?B?VDM2Q0dQMStRdmpyTzQ4Q002S1JnK241T0Q2QmVlVUhvS2lhMTQ1Nk1LVVBU?= =?utf-8?B?OEFCMjVEcC9GSWVrV0VRK2E3aDd4R25Td1NjSDg3VlhiT3k1dUVNMktFTkFm?= =?utf-8?B?UjNmeUo5bEdjL1A2ZThVRzJ1TlN3cEljaHZkd1V3QzBmN1ZDNTVFZEptem10?= =?utf-8?B?eXRtNTNjQkpPbVNOSHJVQVg4Y2lKMC93SkpwTUpjeFVUMzUxL1Q2aUVmRzQ5?= =?utf-8?B?YmVtclloaW54d2xlU3VuTlZOQUVxTjRNTHNRZEpBOGNWNVNSTER4Z1JoVEhH?= =?utf-8?B?MHVHMEZSV3pNT0dTUVM3L1IzOXNIcFRjY1d3bHl6b1pHbldmWnRhL1VMcHdX?= =?utf-8?B?dGMvYnFqS3dLc1hydUo2ZmZwNU1RN2FtUjJOV2dWNTZEcXN5aEc0VEppd3J2?= =?utf-8?B?UzczS1p4WVdZMjNHeEhIUm5oZmdsS3hRTFZTMkdHZXpMNEFxV0plcHNxZWxn?= =?utf-8?B?YTZ1MTdrblFqRmJGeWVBRi96Mk5zWmFJZXRTdDZkS3Fpcy9ZcnB3ZzZLMklY?= =?utf-8?B?M0ZnKzA2cjl3MXNFa0FvM1RKU1plR0RlWHhtWm1ObFREakVSVDZSMFJtbkh2?= =?utf-8?B?b1pGdlcyeWt3ZzNUbWpzMzVEa1JBSCtDWmpuSTZHcFNsQ2s4b2Rac3dGZzJZ?= =?utf-8?B?ZFhwY2ZXMUpGTU9OOG9heVRWUzRneFF1ZnF3OElLUlA5K3ZRMzczc001bkJC?= =?utf-8?B?OVA5Q1hHaElSYnhCT2FqZ245S1JXQWhJRldoYTFZUWFjckUxTUJmOFBKcDBj?= =?utf-8?B?RGlXL21XUUh0TWYva1JqYXdPVXRCQStkZFN1T2dDU293L0hiUmdneWI4KzJ5?= =?utf-8?B?ZU41bjZ3U082UjVxSENCQmliSFRwQjIzWSs0UmZuZ3F3cmNJUXNyM1l4S2VZ?= =?utf-8?B?d2liZ2dYUjV1RFdIZnBRSVdUYndTUTRjRFBsbEpydVhLRjA3R21XdzBYcmla?= =?utf-8?B?djFicGFsQ0pnalVXazFZWUNDenF6djJuRUl2SDdQY2xWQldDYjVLQ3BoMmtH?= =?utf-8?B?ZXJoQXk4SkkvSVVMQkNCemQwTExZMmM5eUdRNm9wUVRPQVdLY3BRV1hqaXBL?= =?utf-8?B?bDBGVjNaSU5uc0pCR0tGTHoyaEZBWjdYaytRa0llaEpYM0pQb3BqbmRncDRK?= =?utf-8?B?a2hOOGFQSmhHWWhjOEZhVTh6Ykp6Y1YxaUhpMVBFYWdqS3pjL3hiakNNQ1B2?= =?utf-8?B?NnpVdUdhOGFwa2U2WFF0SFcrOWNNbXhMdlYrRmJNTys2SXF5bFQvSzVybGNo?= =?utf-8?B?dk1ieTNPTHpHQlJwTnVqZWJFWjVtRFdxUFM1dWJoUytocVZBdlJUSSs0dXJN?= =?utf-8?B?VkNvbzIzdzZYZ2l2a1V6ZDZreVBiQTFUOWVIRHdHRVc5MCswUER4SFNjWld5?= =?utf-8?B?MHphckIrdys5ejU1bVl6ZHhjQmZQQ0owS0dxOTNtNWJrMGoydHFYa3Q3c2RK?= =?utf-8?B?OTEyQTNpeXJZMHhSVlNJdVNMbVNuVEJwZk1HbXN4K1FMbWd2cG8zdG02QmNM?= =?utf-8?B?akVkZWt0ZWhrSW1ILzBHU0R2MTk1cmx4RTBqQm1QYzZiV3JESHZBa3REU0t0?= =?utf-8?B?VWc3VXp1M0diY2tzQUxzQmcyOUs0RDExR0plVGFoQzN3cnVjdTdlSGU0ZHVZ?= =?utf-8?B?eW1WcXVocU1mZmhaZDZRaWNDelNlbjd6THdadWk0TGRzYzZjY2I0VFJiWWZp?= =?utf-8?B?L2lDRzBkTENHZzN3OXFpMHNWazA1YnRHWkdUdWNtT0luS1BhY2gyZzJ5cGox?= =?utf-8?B?UDVIbitmWE4vamlVNDZwOEJXZnV4cjE3SGNNcEM1NWk4dWJEVGNDSTBidkdk?= =?utf-8?B?ZnMxSGFZdGxjV0VBbGRmOFpJVkFRNjVsek00L2tGS0F6UE1nWCtEazN4a1Q5?= =?utf-8?Q?dQebhOAp4my/mBxVMo2Q2N2ld?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b3c8f79d-29cf-4bae-a1e2-08db46f293ac X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2023 07:39:47.9022 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: g5GWYOqqvNjJWd1EmooisLjI28PdpiiwCU3RmlB3wgsgadyTZwcfK5a66oSYBdLsJKIZ3DYv2+Pbjb/fHmL8bw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7870 X-Spam-Status: No, score=-3028.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 26.04.2023 17:45, Palmer Dabbelt wrote: > On Wed, 26 Apr 2023 08:26:26 PDT (-0700), gcc-patches@gcc.gnu.org wrote: >> >> >> On 4/25/23 08:50, Jan Beulich via Gcc-patches wrote: >>> RISC-V will emit ".option nopic" when -fno-pie is in effect, which >>> matches the generic pattern. Just like done for Alpha, special-case >>> RISC-V. >>> --- >>> A couple more targets look to be affected as well, simply because their >>> "no-operation" insn doesn't match the expectation. With the apparently >>> necessary further special casing I then also question the presence of >>> "SWYM" in the generic pattern. >>> >>> An alternative here might be to use dg-additional-options to add e.g. >>> -fpie. I don't think I know all possible implications of doing so, >>> though. > > Looks like there's already a no-pie for SPARC. Nothing's jumping out as > to why, but I'm not super familiar with `-fpatchable-function-entry`. > >> I think this is fine. Go ahead and install it. > > We run into this sort of thing somewhat frequently. Maybe we want a DG > matcher that avoids matching assembler directives? Or maybe even a > "scan-assembler-nop-times" type thing, given that different ports have > different names for the instruction? > > I don't see reason to block fixing the test on something bigger, though, > so seems fine for trunk. Presumably we'd want to backport this as well? Perhaps, but in order to do so I'd need to be given the respective okay. Jan