From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by sourceware.org (Postfix) with ESMTPS id 41C563858C50; Thu, 1 Jun 2023 20:36:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 41C563858C50 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-x429.google.com with SMTP id ffacd0b85a97d-30789a4c537so1225894f8f.0; Thu, 01 Jun 2023 13:36:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685651814; x=1688243814; h=in-reply-to:from:content-language:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=kf/OpG2QwzLydmgxFqfRe5bDLQBv1McrS+NZWfhAcYU=; b=YUzAJ9g4wFlenvoVKdQaEbwguXU0UgazNSBfvmxGU5cdkwqJOpeQA+2TU0mmn2DOcU FeS+32AyFvSytwIU9lgs+yEnB3I6+W8IgI16Liqk0VWm2GSe2Ec05VPCvLr2BLBcLan9 3DHylFrRkdMt78G1gqAygFUKBfA6vy4OZf/GQFQuwmVHHwkmisfGZKZigkFZID95Tvf7 xqpkR+v3/t43yhk8lLwJ/fon8et/BARGa5T8JOcKfb8XL0zxgEgJbzeteQVP7wBwu5XJ F8Me1Wkl3dl/Sj5TjsEhhsYQPZQQHnXeyJm80cDHSAV8aLE1uaC+iRGk4DgDy3tT/qTd s1lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685651814; x=1688243814; h=in-reply-to:from:content-language:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=kf/OpG2QwzLydmgxFqfRe5bDLQBv1McrS+NZWfhAcYU=; b=i6rvXNniM55V6QbohERr+WlOK+T8VMYMXsfjXF+mmOTAh9boqbJfOP1NzQIP8eJyQO eN2hQg4oqU5zJlGiPH9L4HtXz+hbC5LzLpy5lKZDmZto8Od5tLNPcPrxMM63kFJKTsO7 JHjRF+4Gx78p7WrR7d/a/MB49bZKocLp7WZr+Laq8dN6nAOL4mrZaML3mkK4JZrxDFpM LXtmpW6UgxppTBgdwsV6Kuk/7mN6GGNuA9ABtyvSUOUMWVfspTUS8pYxcgvbq6T/MsSl 3WIpwuDVeK6lJ3yl+91g0DRkdU5h3FkUvbyFqkXEv+jmzkjap0FApynIRgR5huT6cngR +iNw== X-Gm-Message-State: AC+VfDwmYb2qF/1iTRJZ7IXC87Mxxy0qKBXEhXRu/VFG/0z86zbGnw7K uSo5Lr0RupTV+v7+FFkpJexRYLPYB7c= X-Google-Smtp-Source: ACHHUZ4dkzukunEL3XtUkDWKGrIg/fx+EkpZ+DWHIKxQH7DCJWHNas4gU8P9yUG3FczKd7vYHfy6SA== X-Received: by 2002:a5d:6592:0:b0:30a:e9a9:a4e4 with SMTP id q18-20020a5d6592000000b0030ae9a9a4e4mr2636948wru.51.1685651813446; Thu, 01 Jun 2023 13:36:53 -0700 (PDT) Received: from ?IPV6:2a01:e0a:1dc:b1c0:3092:dae:3588:d5b9? ([2a01:e0a:1dc:b1c0:3092:dae:3588:d5b9]) by smtp.gmail.com with ESMTPSA id l5-20020adffe85000000b00307a83ea722sm11387601wrr.58.2023.06.01.13.36.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Jun 2023 13:36:53 -0700 (PDT) Content-Type: multipart/alternative; boundary="------------iUn7Zw8C4tNfTcwb0SqxJftA" Message-ID: Date: Thu, 1 Jun 2023 22:36:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] Move std::search into algobase.h To: Jonathan Wakely , Rainer Orth Cc: Jonathan Wakely via Gcc-patches , libstdc++ References: <01f2b9e7-14e8-12a7-c275-7e48e3bd94df@gmail.com> Content-Language: en-US From: =?UTF-8?Q?Fran=c3=a7ois_Dumont?= In-Reply-To: X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------iUn7Zw8C4tNfTcwb0SqxJftA Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit It's of course not as easy as I thought. I would never have detected this problem on my system because I'm missing omp.h. I've implemented and added a: // { dg-require-effective-target omp } so that now those tests are UNRESOLVED rather than PASS. Now I've install OMP and try to rebuild lib to reproduce the failure. To be continued tomorrow... On 01/06/2023 14:05, Jonathan Wakely wrote: > > > On Thu, 1 Jun 2023 at 12:52, Rainer Orth > wrote: > > Jonathan Wakely via Gcc-patches writes: > > > On Wed, 31 May 2023 at 18:39, François Dumont via Libstdc++ < > > libstdc++@gcc.gnu.org > wrote: > > > >> libstdc++: Reduce inclusion to > >> > >> > >> Move the std::search definition from stl_algo.h to > stl_algobase.h and use > >> the later in . > >> > >> For consistency also move std::__parallel::search and > associated helpers > >> from > >> to so that > >> std::__parallel::search > >> is accessible along with std::search. > >> > >> libstdc++-v3/ChangeLog: > >> > >>              * include/bits/stl_algo.h > >>              (std::__search, std::search(_FwdIt1, _FwdIt1, _FwdIt2, > >> _FwdIt2, _BinPred)): Move... > >>              * include/bits/stl_algobase.h: ...here. > >>              * include/std/functional: Replace > include by > >> . > >>              * include/parallel/algo.h > (std::__parallel::search<_FIt1, > >> _FIt2, _BinaryPred>) > >> (std::__parallel::__search_switch<_FIt1, _FIt2, > >> _BinaryPred, _ItTag1, _ItTag2>): > >>              Move... > >>              * include/parallel/algobase.h: ...here. > >>              * include/std/functional: Remove and > >> > >>              includes. Include . > >> > >> Tested under Linux x86_64. > >> > >> Ok to commit ? > >> > > > > OK > > This seems to have caused > > +FAIL: 17_intro/headers/c++2011/parallel_mode.cc (test for excess > errors) > +FAIL: 17_intro/headers/c++2014/parallel_mode.cc (test for excess > errors) > > on i386-pc-solaris2.11: > > > I think it affects all targets. > > > Excess errors: > /var/gcc/regression/master/11.4-gcc-gas/build/i386-pc-solaris2.11/libstdc++-v3/include/parallel/algobase.h:496: > error: '__search_template' is not a member of '__gnu_parallel'; > did you mean '__find_template'? > >         Rainer > > -- > ----------------------------------------------------------------------------- > Rainer Orth, Center for Biotechnology, Bielefeld University > --------------iUn7Zw8C4tNfTcwb0SqxJftA--