public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeff Law <law@redhat.com>
To: Jakub Jelinek <jakub@redhat.com>,
	Richard Biener <rguenther@suse.de>,
	Uros Bizjak <ubizjak@gmail.com>,
	Daniel Santos <daniel.santos@pobox.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Fix ms-sysv.exp testsuite FAILs (PR c/83117)
Date: Tue, 28 Nov 2017 06:36:00 -0000	[thread overview]
Message-ID: <b1ca2029-cfe4-6aa0-6699-6cc32f0827aa@redhat.com> (raw)
In-Reply-To: <20171127223411.GL2353@tucnak>

On 11/27/2017 03:34 PM, Jakub Jelinek wrote:
> Hi!
> 
> As mentioned in the PR, my C FE rvalue folding patch allows folding
> const variable initializers into the uses of those variables in rvalue
> contexts more than before, and so we get warnings about UB in the test,
> because an unprototyped function is cast to a function type with ellipsis in
> it.
> 
> It isn't entirely clear what exactly the test wants to test, as mentioned
> in the PR, this is one of the options how to solve it, by dropping the
> const it can't be optimized in the FEs (the optimizers can still figure out
> the static vars are never written to).  Another option would be just
> add -w to dg-options, another one is const volatile.
> 
> Regtested on x86_64-linux and i686-linux, ok for trunk?
> 
> 2017-11-27  Jakub Jelinek  <jakub@redhat.com>
> 
> 	PR c/83117
> 	* gcc.target/x86_64/abi/ms-sysv/gen.cc (make_do_tests_decl): Drop
> 	const from do_test_{u,v}*.
OK.
jeff

      parent reply	other threads:[~2017-11-28  6:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-27 22:37 Jakub Jelinek
2017-11-27 23:27 ` Daniel Santos
2017-11-28 11:46   ` Jakub Jelinek
2017-11-28 19:29     ` Daniel Santos
2017-11-28  6:36 ` Jeff Law [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b1ca2029-cfe4-6aa0-6699-6cc32f0827aa@redhat.com \
    --to=law@redhat.com \
    --cc=daniel.santos@pobox.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@redhat.com \
    --cc=rguenther@suse.de \
    --cc=ubizjak@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).