From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id C62B63858D28 for ; Wed, 3 May 2023 20:50:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C62B63858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683147059; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=x2WU12cWik+p0c0TBCsvB227aXiQC9qqje0JrjNudBY=; b=dOs3GC5iJbRod7V3DgGSGHq9fAnAedenl7uZCoAlQpIRR/3ZsKCSJo5JtrQNAyW/KVjt0Y Caj8tqHhO9pHwDr/zCI+hmE6Wy9uoUbuXK7BuilsYLVYC4QyTenqvTcz8g650FA8BhlCc+ Gat95IsPbxndRPCvJXOk422izPqExLs= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-549-WkfoJxLhNZm3FpArjPm7UQ-1; Wed, 03 May 2023 16:50:58 -0400 X-MC-Unique: WkfoJxLhNZm3FpArjPm7UQ-1 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-74e0e819d7fso328698385a.1 for ; Wed, 03 May 2023 13:50:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683147058; x=1685739058; h=mime-version:references:message-id:in-reply-to:subject:cc:to:date :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=x2WU12cWik+p0c0TBCsvB227aXiQC9qqje0JrjNudBY=; b=FvhRk4H+HZawWGFlB4Yipc/nv+QW5qYuxK5zqiz/oAC2xN/q+9oKy0X5sSlMBsFNyt +Xhql7pRLtR3oDOUCQdynZ5cEC+AbaEmP1dz5FM8bnEtHDBq9J4rPfEXAEcB3UFE0J3K NXxk9yTmlTxOMVJbABcc/hJzMtjrz9FHR4LOfujHtZK6J3FZTrUQlGX02QSGQLfgaKnF V5nim72mDV2MR6XT+hukuYGC4jDirV44Nej4jYYOHK3Fb9H2Qm8i+TJuCmcG58J9h/8m IY5OmH372m5kXYvT24Sdmq1pXzBtgKj6R5+bdj5WxLHwrw21V6DLTwwlwrj+4YJ5dB6w vd0Q== X-Gm-Message-State: AC+VfDwe83kic4Zn9/ifXxfrTa7o1kTGmACedBAvq3Snbo7FXbc/Jfei Sj29Ck02tGaKoZ7rRAijTiAaJIYPPkpxNC1M7aZURj5mi8W8Si5/pJEgyMNjUBkQJrvc/UDRDqs N7C0ScbNxw3MJR82QWQ== X-Received: by 2002:a05:6214:2689:b0:5ef:5033:f37b with SMTP id gm9-20020a056214268900b005ef5033f37bmr12478923qvb.41.1683147057677; Wed, 03 May 2023 13:50:57 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7NHvCg12UIzpbIjif+PDHsL1xgu7Dw3WpsyVCdlpD3wBCgrVBJfEBRzYmwTDCsN9BK1XuSfg== X-Received: by 2002:a05:6214:2689:b0:5ef:5033:f37b with SMTP id gm9-20020a056214268900b005ef5033f37bmr12478902qvb.41.1683147057386; Wed, 03 May 2023 13:50:57 -0700 (PDT) Received: from [192.168.1.130] (ool-457670bb.dyn.optonline.net. [69.118.112.187]) by smtp.gmail.com with ESMTPSA id f16-20020a0ccc90000000b005ef6557834fsm10709262qvl.62.2023.05.03.13.50.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 May 2023 13:50:57 -0700 (PDT) From: Patrick Palka X-Google-Original-From: Patrick Palka Date: Wed, 3 May 2023 16:50:56 -0400 (EDT) To: Jason Merrill cc: Patrick Palka , gcc-patches@gcc.gnu.org Subject: Re: [PATCH 1/2] c++: potentiality of templated memfn call [PR109480] In-Reply-To: <8dacd562-3441-872f-ab4f-20015694eb8f@redhat.com> Message-ID: References: <20230501195902.1915703-1-ppalka@redhat.com> <6da23365-02cd-8ac1-2fdc-91b284af6a68@redhat.com> <2aea65a6-eef7-d171-8790-bbb5b9c45d8a@idea> <3744435a-11ea-f9bf-c8de-b040e98b3c0b@idea> <8dacd562-3441-872f-ab4f-20015694eb8f@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-13.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 3 May 2023, Jason Merrill wrote: > On 5/2/23 15:53, Patrick Palka wrote: > > on Tue, 2 May 2023, Patrick Palka wrote: > > > > > On Tue, 2 May 2023, Jason Merrill wrote: > > > > > > > On 5/1/23 15:59, Patrick Palka wrote: > > > > > Here we're incorrectly deeming the templated call a.g() inside b's > > > > > initializer as potentially constant, despite g being non-constexpr, > > > > > which leads to us wastefully instantiating the initializer ahead of > > > > > time > > > > > and triggering a bug in access checking deferral (which will get fixed > > > > > in the subsequent patch). > > > > > > > > > > This patch fixes this by calling get_fns earlier during potentiality > > > > > checking so that we also handle the templated form of a member > > > > > function > > > > > call (whose overall callee is a COMPONENT_REF) when checking if the > > > > > called > > > > > function is constexpr etc. > > > > > > > > > > PR c++/109480 > > > > > > > > > > gcc/cp/ChangeLog: > > > > > > > > > > * constexpr.cc (potential_constant_expression_1) > > > > CALL_EXPR>: > > > > > Reorganize to call get_fns sooner. Remove dead store to > > > > > 'fun'. > > > > > > > > > > gcc/testsuite/ChangeLog: > > > > > > > > > > * g++.dg/cpp0x/noexcept59.C: Make e() constexpr so that the > > > > > expected "without object" diagnostic isn't replaced by a > > > > > "call to non-constexpr function" diagnostic. > > > > > * g++.dg/template/non-dependent25.C: New test. > > > > > --- > > > > > gcc/cp/constexpr.cc | 16 > > > > > ++++++++-------- > > > > > gcc/testsuite/g++.dg/cpp0x/noexcept59.C | 2 +- > > > > > gcc/testsuite/g++.dg/template/non-dependent25.C | 14 ++++++++++++++ > > > > > 3 files changed, 23 insertions(+), 9 deletions(-) > > > > > create mode 100644 gcc/testsuite/g++.dg/template/non-dependent25.C > > > > > > > > > > diff --git a/gcc/cp/constexpr.cc b/gcc/cp/constexpr.cc > > > > > index d1097764b10..29d872d0a5e 100644 > > > > > --- a/gcc/cp/constexpr.cc > > > > > +++ b/gcc/cp/constexpr.cc > > > > > @@ -9132,6 +9132,10 @@ potential_constant_expression_1 (tree t, bool > > > > > want_rval, bool strict, bool now, > > > > > if (fun && is_overloaded_fn (fun)) > > > > > { > > > > > + if (!RECUR (fun, true)) > > > > > + return false; > > > > > + fun = get_fns (fun); > > > > > + > > > > > if (TREE_CODE (fun) == FUNCTION_DECL) > > > > > { > > > > > if (builtin_valid_in_constant_expr_p (fun)) > > > > > @@ -9167,7 +9171,8 @@ potential_constant_expression_1 (tree t, bool > > > > > want_rval, bool strict, bool now, > > > > > expression the address will be folded away, so look > > > > > through it now. */ > > > > > if (DECL_NONSTATIC_MEMBER_FUNCTION_P (fun) > > > > > - && !DECL_CONSTRUCTOR_P (fun)) > > > > > + && !DECL_CONSTRUCTOR_P (fun) > > > > > + && !processing_template_decl) > > > > > > > > I don't see any rationale for this hunk? > > > > > > Now that we call get_fns earlier, we can reach this code path with a > > > templated non-static memfn call, but the code that follows assumes > > > non-templated form. > > > > > > I tried teaching it to handle the templated form too, but there's > > > apparently two different templated forms for non-static memfn calls, > > > one with a COMPONENT_REF callee and one with an ordinary BASELINK > > > callee (without a implicit object argument). In the former the implict > > > object argument is inside the COMPONENT_REF (and is a reference instead > > > of a pointer), and in the latter we don't even have an implicit object > > > argument to inspect. > > > > > > FWIW I think which form we use depends on whether we know if the called > > > function is a member of the current instantiation, e.g > > > > > > struct A { void f(); }; > > > > > > template struct B; > > > > > > template > > > struct C : B { > > > void g(); > > > > > > void h() { > > > A::f(); // templated form has BASELINK callee, no object arg > > > C::g(); // templated form has COMPONENT_REF callee > > > } > > > }; > > > > > > So it seemed best to punt on templated non-static memfn calls here for > > > now and treat that as a separate enhancement. > > > > And I'm not even sure if the code path in question is necessary at all > > anymore: disabling it outright doesn't cause any regressions in the > > testsuite. > > It seems effectively equivalent to the body of the loop over the args a few > > lines later: > > If removing that hunk doesn't regress anything, let's do it. Probably that > should have happened in r13-55-ge9d2adc17d0dbe Sounds good, here's the combined patch which I'm bootstrapping for good measure. Does it look OK for trunk if bootstrap+regtest succeeds? -- >8 -- Subject: [PATCH] c++: potentiality of templated memfn call [PR109480] Here we're incorrectly deeming the templated call a.g() inside b's initializer as potentially constant, despite g being non-constexpr, which leads to us wastefully instantiating the initializer ahead of time, which incidentally tiggers a bug in access checking deferral (to be fixed by the subsequent patch). This patch fixes this by calling get_fns earlier during CALL_EXPR potentiality checking so that we're able to extract a FUNCTION_DECL out of a templated member function call (whose overall is typically a COMPONENT_REF) and to the usual checking if the called function is constexpr etc. In passing, I noticed potential_constant_expression_1's special handling of the object argument of a non-static member function call is effectively the same as the generic argument handling a few lines later. So this patch just gets rid of this special handling; otherwise we'd have to adapt it to handle templated versions of such calls. PR c++/109480 gcc/cp/ChangeLog: * constexpr.cc (potential_constant_expression_1) : Reorganize to call get_fns sooner. Remove special handling of the object argument of a non-static member function call. Remove dead store to 'fun'. gcc/testsuite/ChangeLog: * g++.dg/cpp0x/noexcept59.C: Make e() constexpr so that the expected "without object" diagnostic isn't replaced by a "call to non-constexpr function" diagnostic. * g++.dg/template/non-dependent25.C: New test. --- gcc/cp/constexpr.cc | 32 ++++--------------- gcc/testsuite/g++.dg/cpp0x/noexcept59.C | 2 +- .../g++.dg/template/non-dependent25.C | 14 ++++++++ 3 files changed, 21 insertions(+), 27 deletions(-) create mode 100644 gcc/testsuite/g++.dg/template/non-dependent25.C diff --git a/gcc/cp/constexpr.cc b/gcc/cp/constexpr.cc index d1097764b10..075339f7f62 100644 --- a/gcc/cp/constexpr.cc +++ b/gcc/cp/constexpr.cc @@ -9132,6 +9132,10 @@ potential_constant_expression_1 (tree t, bool want_rval, bool strict, bool now, if (fun && is_overloaded_fn (fun)) { + if (!RECUR (fun, true)) + return false; + fun = get_fns (fun); + if (TREE_CODE (fun) == FUNCTION_DECL) { if (builtin_valid_in_constant_expr_p (fun)) @@ -9162,36 +9166,12 @@ potential_constant_expression_1 (tree t, bool want_rval, bool strict, bool now, explain_invalid_constexpr_fn (fun); return false; } - /* A call to a non-static member function takes the address - of the object as the first argument. But in a constant - expression the address will be folded away, so look - through it now. */ - if (DECL_NONSTATIC_MEMBER_FUNCTION_P (fun) - && !DECL_CONSTRUCTOR_P (fun)) - { - tree x = get_nth_callarg (t, 0); - if (is_this_parameter (x)) - return true; - /* Don't require an immediately constant value, as - constexpr substitution might not use the value. */ - bool sub_now = false; - if (!potential_constant_expression_1 (x, rval, strict, - sub_now, fundef_p, - flags, jump_target)) - return false; - i = 1; - } - } - else - { - if (!RECUR (fun, true)) - return false; - fun = get_first_fn (fun); } + + fun = OVL_FIRST (fun); /* Skip initial arguments to base constructors. */ if (DECL_BASE_CONSTRUCTOR_P (fun)) i = num_artificial_parms_for (fun); - fun = DECL_ORIGIN (fun); } else if (fun) { diff --git a/gcc/testsuite/g++.dg/cpp0x/noexcept59.C b/gcc/testsuite/g++.dg/cpp0x/noexcept59.C index c752601ba09..1dc826d3111 100644 --- a/gcc/testsuite/g++.dg/cpp0x/noexcept59.C +++ b/gcc/testsuite/g++.dg/cpp0x/noexcept59.C @@ -3,7 +3,7 @@ template class A { - void e (); + constexpr bool e () { return true; }; bool f (int() noexcept(this->e())); // { dg-error "this" } bool g (int() noexcept(e())); // { dg-error "without object" } }; diff --git a/gcc/testsuite/g++.dg/template/non-dependent25.C b/gcc/testsuite/g++.dg/template/non-dependent25.C new file mode 100644 index 00000000000..c00e44532b0 --- /dev/null +++ b/gcc/testsuite/g++.dg/template/non-dependent25.C @@ -0,0 +1,14 @@ +// PR c++/109480 + +template +struct A { + void f() { + A a; + const bool b = a.g(); // { dg-bogus "private" } + } + +private: + bool g() const; +}; + +template struct A; -- 2.40.1.476.g69c786637d