From: Bernd Schmidt <bschmidt@redhat.com>
To: Marek Polacek <polacek@redhat.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Joseph Myers <joseph@codesourcery.com>,
Jason Merrill <jason@redhat.com>,
Sandra Loosemore <sandra@codesourcery.com>
Subject: Re: C/C++ PATCH for c/77423 (bogus warning with -Wlogical-not-parentheses)
Date: Mon, 05 Sep 2016 16:12:00 -0000 [thread overview]
Message-ID: <b2049e58-dbab-b128-4c94-181a0892fcc9@redhat.com> (raw)
In-Reply-To: <20160905105221.GB19950@redhat.com>
On 09/05/2016 12:52 PM, Marek Polacek wrote:
> On Mon, Sep 05, 2016 at 12:35:13PM +0200, Bernd Schmidt wrote:
>> On 09/02/2016 05:13 PM, Marek Polacek wrote:
>>> diff --git gcc/doc/invoke.texi gcc/doc/invoke.texi
>>> index 87da1f1..38d55d4 100644
>>> --- gcc/doc/invoke.texi
>>> +++ gcc/doc/invoke.texi
>>> @@ -5437,8 +5437,8 @@ if (a < 0 && a < 0) @{ @dots{} @}
>>> @opindex Wlogical-not-parentheses
>>> @opindex Wno-logical-not-parentheses
>>> Warn about logical not used on the left hand side operand of a comparison.
>>> -This option does not warn if the RHS operand is of a boolean type. Its
>>> -purpose is to detect suspicious code like the following:
>>> +This option does not warn if the right operand is considered to be a Boolean
>>> +expression. Its purpose is to detect suspicious code like the following:
>>
>> I think "Boolean" shouldn't be capitalized. The patch looks ok to me
>> otherwise.
>
> No strong opinions, but looking at
> https://en.wikipedia.org/wiki/Boolean_expression
> I see that it's capitalized there, so I think let's keep "Boolean".
I looked at other occurrences in this file, and they are lower-case.
Across the other texi files upper-case is also the exception. Let's ask
Sandra for a ruling?
Bernd
next prev parent reply other threads:[~2016-09-05 15:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-02 15:14 Marek Polacek
2016-09-05 10:51 ` Bernd Schmidt
2016-09-05 10:57 ` Marek Polacek
2016-09-05 16:12 ` Bernd Schmidt [this message]
2016-09-05 16:44 ` Sandra Loosemore
2016-09-06 9:08 ` Marek Polacek
2016-09-02 15:51 Bernd Edlinger
2016-09-05 14:08 ` Marek Polacek
2016-09-05 14:28 ` Bernd Edlinger
2016-09-05 14:39 ` Marek Polacek
2016-09-05 15:03 ` Bernd Edlinger
2016-09-05 16:46 ` Joseph Myers
2016-09-05 17:03 ` Bernd Edlinger
2016-09-15 19:55 ` Jeff Law
2016-09-16 9:05 ` Marek Polacek
2016-09-05 15:01 ` Eric Gallager
2016-09-05 15:08 ` Bernd Edlinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2049e58-dbab-b128-4c94-181a0892fcc9@redhat.com \
--to=bschmidt@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
--cc=joseph@codesourcery.com \
--cc=polacek@redhat.com \
--cc=sandra@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).