From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id E5B993858D39 for ; Wed, 19 Apr 2023 07:19:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E5B993858D39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn Received: from loongson.cn (unknown [10.20.4.52]) by gateway (Coremail) with SMTP id _____8Dx_5cClj9kdNEeAA--.48625S3; Wed, 19 Apr 2023 15:19:31 +0800 (CST) Received: from [10.20.4.52] (unknown [10.20.4.52]) by localhost.localdomain (Coremail) with SMTP id AQAAf8CxPL7_lT9kTbAuAA--.57417S2; Wed, 19 Apr 2023 15:19:28 +0800 (CST) Subject: Re: [PATCH] LoongArch: fix MUSL_DYNAMIC_LINKER To: =?UTF-8?B?5qiK6bmP?= , gcc-patches@gcc.gnu.org Cc: Xi Ruoyao , "yangyujie@loongson.cn" References: <20230417023919.7015-1-fanpeng@loongson.cn> <27953fa0.32f92.1878dfbf8a0.Coremail.fanpeng@loongson.cn> From: Lulu Cheng Message-ID: Date: Wed, 19 Apr 2023 15:19:20 +0800 User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <27953fa0.32f92.1878dfbf8a0.Coremail.fanpeng@loongson.cn> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-CM-TRANSID:AQAAf8CxPL7_lT9kTbAuAA--.57417S2 X-CM-SenderInfo: xfkh0wpoxo3qxorr0wxvrqhubq/ X-Coremail-Antispam: 1Uk129KBjvJXoWxAr13GryktFW7KF1fCrW5trb_yoW5Cw4rpr ZayFy7JrWrCws5AwsYq3s3urn0q3sYganruFsxGw1DCFsIkw1jqF15tr98u3ZxXr4Sqa40 vry0gFy7uF4aya7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUj1kv1TuYvTs0mT0YCTnIWj qI5I8CrVACY4xI64kE6c02F40Ex7xfYxn0WfASr-VFAUDa7-sFnT9fnUUIcSsGvfJTRUUU bI8YFVCjjxCrM7AC8VAFwI0_Jr0_Gr1l1xkIjI8I6I8E6xAIw20EY4v20xvaj40_Wr0E3s 1l1IIY67AEw4v_Jr0_Jr4l8cAvFVAK0II2c7xJM28CjxkF64kEwVA0rcxSw2x7M28EF7xv wVC0I7IYx2IY67AKxVW5JVW7JwA2z4x0Y4vE2Ix0cI8IcVCY1x0267AKxVW8JVWxJwA2z4 x0Y4vEx4A2jsIE14v26r4UJVWxJr1l84ACjcxK6I8E87Iv6xkF7I0E14v26r4UJVWxJr1l e2I262IYc4CY6c8Ij28IcVAaY2xG8wAqjxCEc2xF0cIa020Ex4CE44I27wAqx4xG64xvF2 IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_JrI_JrylYx0Ex4A2jsIE14v26r1j6r4U McvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvEwIxGrwCYjI0SjxkI62AI1cAE67vIY487Mx AIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_ Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCIc40Y0x0EwI xGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWUJVW8 JwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcV C2z280aVCY1x0267AKxVWUJVW8JbIYCTnIWIevJa73UjIFyTuYvjxUrNtxDUUUU X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_50,BODY_8BITS,GIT_PATCH_0,KAM_DMARC_STATUS,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: 在 2023/4/17 下午2:51, 樊鹏 写道: > Yes, https://wiki.musl-libc.org/guidelines-for-distributions.html, "Multilib/multi-arch" section of this > introduces it. > Hi,  fanpeng: I agree with ruoyao, add this link to the commit message. I have no problem with other. Thanks! >> -----Original Messages----- >> From: "Xi Ruoyao" >> Sent Time:2023-04-17 14:36:52 (星期一) >> To: "Peng Fan" , gcc-patches@gcc.gnu.org >> Cc: chenglulu@loongson.cn >> Subject: Re: [PATCH] LoongArch: fix MUSL_DYNAMIC_LINKER >> >> On Mon, 2023-04-17 at 10:39 +0800, Peng Fan wrote: >>> The system based on musl has no '/lib64', so change it. >> I like the change. IMO Glibc-based systems should avoid /lib64 as well >> but it's too late to change it now. >> >> Could you provide a link to the Musl doc as a reference? I'd like to >> include the link in the commit message. >> >>> gcc/ >>>         * config/loongarch/gnu-user.h (MUSL_DYNAMIC_LINKER): Redefine. >>> >>> Signed-off-by: Peng Fan >>> --- >>>  gcc/config/loongarch/gnu-user.h | 7 ++++++- >>>  1 file changed, 6 insertions(+), 1 deletion(-) >>> >>> diff --git a/gcc/config/loongarch/gnu-user.h >>> b/gcc/config/loongarch/gnu-user.h >>> index aecaa02a199..fa1a5211419 100644 >>> --- a/gcc/config/loongarch/gnu-user.h >>> +++ b/gcc/config/loongarch/gnu-user.h >>> @@ -33,9 +33,14 @@ along with GCC; see the file COPYING3.  If not see >>>  #define GLIBC_DYNAMIC_LINKER \ >>>    "/lib" ABI_GRLEN_SPEC "/ld-linux-loongarch-" ABI_SPEC ".so.1" >>> >>> +#define MUSL_ABI_SPEC \ >>> +  "%{mabi=lp64d:-lp64d}" \ >>> +  "%{mabi=lp64f:-lp64f}" \ >>> +  "%{mabi=lp64s:-lp64s}" >>> + >>>  #undef MUSL_DYNAMIC_LINKER >>>  #define MUSL_DYNAMIC_LINKER \ >>> -  "/lib" ABI_GRLEN_SPEC "/ld-musl-loongarch-" ABI_SPEC ".so.1" >>> +  "/lib/ld-musl-loongarch" ABI_GRLEN_SPEC MUSL_ABI_SPEC ".so.1" >>> >>>  #undef GNU_USER_TARGET_LINK_SPEC >>>  #define GNU_USER_TARGET_LINK_SPEC \ >> -- >> Xi Ruoyao >> School of Aerospace Science and Technology, Xidian University > > 本邮件及其附件含有龙芯中科的商业秘密信息，仅限于发送给上面地址中列出的个人或群组。禁止任何其他人以任何形式使用（包括但不限于全部或部分地泄露、复制或散发）本邮件及其附件中的信息。如果您错收本邮件，请您立即电话或邮件通知发件人并删除本邮件。 > This email and its attachments contain confidential information from Loongson Technology , which is intended only for the person or entity whose address is listed above. Any use of the information contained herein in any way (including, but not limited to, total or partial disclosure, reproduction or dissemination) by persons other than the intended recipient(s) is prohibited. If you receive this email in error, please notify the sender by phone or email immediately and delete it.