From: Arthur Cohen <arthur.cohen@embecosm.com>
To: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>, gcc-patches@gcc.gnu.org
Cc: Thomas Schwinge <thomas@codesourcery.com>
Subject: Re: [PATCH] rust: Fix rust-tree.cc compilation on SPARC
Date: Mon, 20 Feb 2023 11:37:54 +0100 [thread overview]
Message-ID: <b20a366b-bd38-7657-5427-4450ba64d691@embecosm.com> (raw)
In-Reply-To: <yddcz64wrmy.fsf@CeBiTec.Uni-Bielefeld.DE>
[-- Attachment #1.1.1: Type: text/plain, Size: 1012 bytes --]
Thanks Rainer!
Ok for trunk :)
Kindly,
--
Arthur
On 2/20/23 11:36, Rainer Orth wrote:
> This patch
>
> commit 27a89f84c458ae938bc3eb92ad0d594c06fc3b42
> Author: Thomas Schwinge <thomas@codesourcery.com>
> Date: Fri Feb 17 23:36:20 2023 +0100
>
> '#include "tm_p.h"' in 'gcc/rust/backend/rust-tree.cc'
>
> broke rust bootstrap on SPARC:
>
> In file included from ./tm_p.h:4,
> from /vol/gcc/src/hg/master/local/gcc/rust/backend/rust-tree.cc:38:
> /vol/gcc/src/hg/master/local/gcc/config/sparc/sparc-protos.h:46:47: error: use of enum 'memmodel' without previous declaration
> 46 | extern void sparc_emit_membar_for_model (enum memmodel, int, int);
> | ^~~~~~~~
>
> Fixed by including memmodel.h. Tested on sparc-sun-solaris2.11 and
> i386-pc-solaris2.11.
>
> Ok for trunk?
>
> I'd usually commit the patch as obvious, but have no idea how rust
> patches are handled.
>
> Rainer
>
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3195 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
prev parent reply other threads:[~2023-02-20 10:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-20 10:36 Rainer Orth
2023-02-20 10:37 ` Arthur Cohen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b20a366b-bd38-7657-5427-4450ba64d691@embecosm.com \
--to=arthur.cohen@embecosm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=ro@CeBiTec.Uni-Bielefeld.DE \
--cc=thomas@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).