From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 70B933858C2F for ; Tue, 23 Jan 2024 21:03:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 70B933858C2F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 70B933858C2F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706043807; cv=none; b=EcRz2wUr2dcPEJ026NmCFG0jmgYfEH6UmXYTH3ijdQvVvKP4eymdz6K4Lim1qls1bbkBilZrVe0H9UO8mi4nCWlO6cDSSmx+g5NY4XnfomKygSNpy+q7OdHXn145sfMhLHoU4+0rKfbB5PBGD3lq0DSFYa4t4aQxarUMLSPJhmw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706043807; c=relaxed/simple; bh=3hwbUOe3kw0JHtcjLbT/svQfjD7BMDucioA3SYAx+24=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=BhafgERDBXMPKLIAjD/VhtLwtDIdkO+uSQFOeOESXBk1htHmaCffTaovUHRzHIG9gioW+/6lPXKwq12pqaQs9zoXyAYZDeiK3b9KpvEL39wwPt1cNkbn3zgs7RwD1fXDX4hMkGKWSj+uJjgDGg98BdsNR6+flUT4P/gvF3j7fMw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706043804; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DrN6Nlf/IEpO7sMA+EtXbVFhk1KyEjXawX2+n0Zs3P4=; b=TfqRdoMcKhQpzSc5anJUMu8qUPnmQDDZk2/DLo5cHftonRptgcaI1nHhvIZuw3Mh5WhGID vKvk3n2Z8RVqJQ0FAmVRKcPY9DOVp3M/cBMlCHuqBhRuuYRjOVLVbiVhPVh1CwU5W8aRx3 aTbPdrY6KUAn6DKA4HH1vape5qJRS28= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-556-58pLNuXMNSy1ROeK6TWmIQ-1; Tue, 23 Jan 2024 16:03:22 -0500 X-MC-Unique: 58pLNuXMNSy1ROeK6TWmIQ-1 Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-42a58020febso5160011cf.3 for ; Tue, 23 Jan 2024 13:03:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706043802; x=1706648602; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DrN6Nlf/IEpO7sMA+EtXbVFhk1KyEjXawX2+n0Zs3P4=; b=tQAMnCguOFzl7uOqrRym6cBMv/X09JBFbOtDyC1WIX4rIT1GCSIzFR+tPlkxjGsCYH 70TY3fWoP+VqPx5X5ej8AiJCt0elaNqzIsDtPTfXohsQdN2roBzW3+gIRY1jmCcV5DV+ 9qhiAVqmL2EoFRUNmTu1vx9ueFuxTOnPfS2wQ1qAkEs818zspR1U1rJX1vts9Arf8+lP 07JVzKzo9zgxQWzHkLBgBSkdTxs/Hxf1SGSl1RMqA08menmHNxb1IVaYlSXuky+w9dhz TDYjBjsAPXSNoUJtUZJ39V6qKR3aRbqLTIh+Dn4yDQ1B3A/VDdigvGYMPBHOk6A8EEwN xu9Q== X-Gm-Message-State: AOJu0Yy81Lyz4KPocycYVRuz1qjLk9nz4HR1qGsuWFo4ujwQwhRWXJMm ZsBKPjAWXNrFYHw8oP++yd2ag6+XfjS9K2SxprWFPWgrn7AWTOU3rJ+wSuNupG1676z15sZ1p+t GL6k55G2COPz5ucHeYNy2GOHzDXV2T+JgLZsJAs1Hcz7pfPwPNxyvoAM= X-Received: by 2002:ac8:4283:0:b0:42a:5194:f51b with SMTP id o3-20020ac84283000000b0042a5194f51bmr1321737qtl.54.1706043802097; Tue, 23 Jan 2024 13:03:22 -0800 (PST) X-Google-Smtp-Source: AGHT+IEfQEr7IAYqQQBkJEdoTMGfZiWLbKeizwJUTq1xjlnuDftMlvoG9xykkkV3NInfx7OiolBTQA== X-Received: by 2002:ac8:4283:0:b0:42a:5194:f51b with SMTP id o3-20020ac84283000000b0042a5194f51bmr1321726qtl.54.1706043801792; Tue, 23 Jan 2024 13:03:21 -0800 (PST) Received: from [192.168.1.108] (130-44-146-16.s12558.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.146.16]) by smtp.gmail.com with ESMTPSA id cr15-20020a05622a428f00b0042a31bc98b9sm3499233qtb.24.2024.01.23.13.03.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Jan 2024 13:03:21 -0800 (PST) Message-ID: Date: Tue, 23 Jan 2024 16:03:19 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] c++: -Wdangling-reference and lambda false warning [PR109640] To: Marek Polacek , GCC Patches , libstdc++ References: <20240120021823.81839-1-polacek@redhat.com> From: Jason Merrill In-Reply-To: <20240120021823.81839-1-polacek@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RCVD_IN_SORBS_WEB,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/19/24 21:18, Marek Polacek wrote: > Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk? OK. A lambda could return a dangling reference, but it's unlikely. > -- >8 -- > -Wdangling-reference checks if a function receives a temporary as its > argument, and only warns if any of the arguments was a temporary. But > we should not warn when the temporary represents a lambda or we generate > false positives as in the attached testcases. > > PR c++/113256 > PR c++/111607 > PR c++/109640 > > gcc/cp/ChangeLog: > > * call.cc (do_warn_dangling_reference): Don't warn if the temporary > is of lambda type. > > gcc/testsuite/ChangeLog: > > * g++.dg/warn/Wdangling-reference14.C: New test. > * g++.dg/warn/Wdangling-reference15.C: New test. > * g++.dg/warn/Wdangling-reference16.C: New test. > --- > gcc/cp/call.cc | 9 ++++-- > .../g++.dg/warn/Wdangling-reference14.C | 22 +++++++++++++ > .../g++.dg/warn/Wdangling-reference15.C | 31 +++++++++++++++++++ > .../g++.dg/warn/Wdangling-reference16.C | 13 ++++++++ > 4 files changed, 72 insertions(+), 3 deletions(-) > create mode 100644 gcc/testsuite/g++.dg/warn/Wdangling-reference14.C > create mode 100644 gcc/testsuite/g++.dg/warn/Wdangling-reference15.C > create mode 100644 gcc/testsuite/g++.dg/warn/Wdangling-reference16.C > > diff --git a/gcc/cp/call.cc b/gcc/cp/call.cc > index 1f5ff417c81..77f51bacce3 100644 > --- a/gcc/cp/call.cc > +++ b/gcc/cp/call.cc > @@ -14123,7 +14123,10 @@ do_warn_dangling_reference (tree expr, bool arg_p) > tree e = expr; > while (handled_component_p (e)) > e = TREE_OPERAND (e, 0); > - if (!reference_like_class_p (TREE_TYPE (e))) > + tree type = TREE_TYPE (e); > + /* If the temporary represents a lambda, we don't really know > + what's going on here. */ > + if (!reference_like_class_p (type) && !LAMBDA_TYPE_P (type)) > return expr; > } > > @@ -14180,10 +14183,10 @@ do_warn_dangling_reference (tree expr, bool arg_p) > initializing this reference parameter. */ > if (do_warn_dangling_reference (arg, /*arg_p=*/true)) > return expr; > - /* Don't warn about member function like: > + /* Don't warn about member functions like: > std::any a(...); > S& s = a.emplace({0}, 0); > - which constructs a new object and returns a reference to it, but > + which construct a new object and return a reference to it, but > we still want to detect: > struct S { const S& self () { return *this; } }; > const S& s = S().self(); > diff --git a/gcc/testsuite/g++.dg/warn/Wdangling-reference14.C b/gcc/testsuite/g++.dg/warn/Wdangling-reference14.C > new file mode 100644 > index 00000000000..92b38a965e0 > --- /dev/null > +++ b/gcc/testsuite/g++.dg/warn/Wdangling-reference14.C > @@ -0,0 +1,22 @@ > +// PR c++/113256 > +// { dg-do compile { target c++14 } } > +// { dg-options "-Wdangling-reference" } > + > +#include > +#include > + > +template auto bind(M T::* pm, A) > +{ > + return [=]( auto&& x ) -> M const& { return x.*pm; }; > +} > + > +template struct arg {}; > + > +arg<1> _1; > + > +int main() > +{ > + std::pair pair; > + int const& x = bind( &std::pair::first, _1 )( pair ); // { dg-bogus "dangling reference" } > + assert( &x == &pair.first ); > +} > diff --git a/gcc/testsuite/g++.dg/warn/Wdangling-reference15.C b/gcc/testsuite/g++.dg/warn/Wdangling-reference15.C > new file mode 100644 > index 00000000000..c39577db64a > --- /dev/null > +++ b/gcc/testsuite/g++.dg/warn/Wdangling-reference15.C > @@ -0,0 +1,31 @@ > +// PR c++/111607 > +// { dg-do compile { target c++20 } } > +// { dg-options "-Wdangling-reference" } > + > +#include > + > +struct S { > + constexpr S(int i_) : i(i_) {} > + S(S const &) = delete; > + S & operator=(S const &) = delete; > + S(S &&) = delete; > + S & operator=(S &&) = delete; > + int i; > +}; > + > +struct A { > + S s{0}; > +}; > + > +using V = std::variant; > + > +consteval auto f(V const & v) { > + auto const & s = std::visit([](auto const & v) -> S const & { return v.s; }, v); // { dg-bogus "dangling reference" } > + return s.i; > +} > + > +int main() { > + constexpr V a{std::in_place_type}; > + constexpr auto i = f(a); > + return i; > +} > diff --git a/gcc/testsuite/g++.dg/warn/Wdangling-reference16.C b/gcc/testsuite/g++.dg/warn/Wdangling-reference16.C > new file mode 100644 > index 00000000000..91996922291 > --- /dev/null > +++ b/gcc/testsuite/g++.dg/warn/Wdangling-reference16.C > @@ -0,0 +1,13 @@ > +// PR c++/109640 > +// { dg-do compile { target c++11 } } > +// { dg-options "-Wdangling-reference" } > + > +bool > +fn0 () > +{ > + int a; > + int&& i = [](int& r) -> int&& { return static_cast(r); }(a); // { dg-bogus "dangling reference" } > + auto const l = [](int& r) -> int&& { return static_cast(r); }; > + int&& j = l(a); > + return &i == &j; > +} > > base-commit: 615e25c82de97acc17ab438f88d6788cf7ffe1d6