From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) by sourceware.org (Postfix) with ESMTPS id 8999C3858D3C for ; Tue, 12 Sep 2023 00:49:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8999C3858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x62b.google.com with SMTP id d9443c01a7336-1c1f8aaab9aso44073455ad.1 for ; Mon, 11 Sep 2023 17:49:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694479777; x=1695084577; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8GAQ5Pkzo8062ZyC8/zy0+ikBYYYtlLHW0OhrO4e29E=; b=clJ4/FpX6Du+h8OKZ/BqKmZDbHcel14MXI5xyxNlka4VVWChDEGycMEqfsSQl2Otys RPk5kaM/W7/5NF0765VarA46Sg4AbwTaJLDFBTjwn2RPZJs48I4DNTq6ovcauc2MsvPH 5vmC1ds6wwyGepg2VUZn3HOiLBXLKhPX7s/2CSu7yC5DhuOVk+O98CBfxmcrwDUFjk69 pkCLgVZDCb318ID/REUB/iv363+19kg6sJQfcjnh11ge8iihEPVy5nCmylnCE6zgQGQB X2MmO8yLrOLcIELKhUq0t/4ZXYfx+HsDjVkhgFHKHxG1TaPpUkEy+Ac1nJi7+7xzg+vp Szlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694479777; x=1695084577; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8GAQ5Pkzo8062ZyC8/zy0+ikBYYYtlLHW0OhrO4e29E=; b=dvxxRQua2x3Z1alLCtZJqmFAIygytiIV07BT4Ceg4kKQhagfE40VgXriRmkUg93Cl1 TF8n/3aTdraBMaJUTG8YC8xQNtgnGTkjxIrLoEm/m9rDVRUS4NoShFk+f2YYbi+bSmoU /7owoqMo8Ow2NQAiuXzJVte5KSTKYjeENbFvI+E2m1JbWmXWpBgT3YbIBfbf11BORWG3 G0P7Lvx5tPgP110zPpP1sSg5xxWg0eqri6ngU+4mSEMPyHfLaUMRA3MsdCtxH5A20lSB HWtE8oAUFUJiPsHIU13iz9chHkG1S/DIxJPDtN6NDsQ1srI0Nn8j83zfF2Vghjx/BvR6 J5kg== X-Gm-Message-State: AOJu0Yx7B1VznlJ8Bi59Cmw45E1w60O9y0poA9sh/UyBeNWZJm0WIITM x+xHM4Qbqi4JpyCzcCFIRWg= X-Google-Smtp-Source: AGHT+IH8vQI1oAs6QMfUA5VoC3LMpc0SpEjbeITtrYVFcbTtZCMYI04eDAIbmD0iszJ47I8pFutmNQ== X-Received: by 2002:a17:902:7fcc:b0:1c1:dbd6:9bf6 with SMTP id t12-20020a1709027fcc00b001c1dbd69bf6mr9954009plb.41.1694479777330; Mon, 11 Sep 2023 17:49:37 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id i5-20020a170902eb4500b001bde12178b4sm7064942pli.33.2023.09.11.17.49.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Sep 2023 17:49:36 -0700 (PDT) Message-ID: Date: Mon, 11 Sep 2023 18:49:35 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] RISC-V: Finish Typing Un-Typed Instructions and Turn on Assert Content-Language: en-US To: Edwin Lu , gcc-patches@gcc.gnu.org Cc: gnu-toolchain@rivosinc.com References: <20230911225308.2275313-1-ewlu@rivosinc.com> From: Jeff Law In-Reply-To: <20230911225308.2275313-1-ewlu@rivosinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 9/11/23 16:52, Edwin Lu wrote: > Updates autovec instruction that was added after last patch and turns on the > assert statement to ensure all new instructions have a type. > > * config/riscv/autovec-opt.md: Update type > * config/riscv/riscv.cc (riscv_sched_variable_issue): Remove assert "Remove assert" -> "Enable assert." We're removing the #if 0 guard, not the assert itself :-) OK with the ChangeLog fixed. jeff