From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x32.google.com (mail-oa1-x32.google.com [IPv6:2001:4860:4864:20::32]) by sourceware.org (Postfix) with ESMTPS id D06793875473 for ; Thu, 27 Jun 2024 01:54:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D06793875473 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D06793875473 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:4860:4864:20::32 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1719453280; cv=none; b=QLpZnr9OiAm/ARYanRIJuYt02/I4m/S1CuCcpGO5Rg8VlMgXdK85T9EUczlssAi6MHXHSTxnVe3m8JTjefzI16rq3HTM/jXR2OqPtc/4hB5cfXT2dn5M5k3j+9hBAmuWsNBYWlFBGPy3zwMQHVQ8EQ9hvPGiAURRrT69/gmHIf4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1719453280; c=relaxed/simple; bh=KlpYYiUzTUXnh9ET4zFg0O7mWGD+iKU9sqImbye4Du8=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=Z+dm3FhgGR65GdaVyXsSuXQaiGCyBcfHaBYmy4ZxNeK6GR22tso41XcJTUf5U/6Jy6tqq+v91HMbSlI6NUVqzVTLdhsV6Z6NPBOxMF4xcpSeJqw+QuY45lkWVZqTADInWq12U+dlThrQApEipZ7gGat3gbxyyoQvdelCt0nqqs4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-oa1-x32.google.com with SMTP id 586e51a60fabf-25d75ead52fso56317fac.1 for ; Wed, 26 Jun 2024 18:54:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719453277; x=1720058077; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=26NLrLcqWeuhDrXay1Anr6YYmn8BDHZcoGmVUtGJlMA=; b=UnA7OjvV5lomARIbj9VGE8/lXMU7X15chjikOx6pkEjXbz7ftDH5ES4BVWRWiRjPbq 8dq6DNZb1cKkXkdNyteAp7onRt4qEknGa8+l7NYwebBMET+Vfv97Ma8B/7ynYh/YFtkR JdC5wd4NAUb99z+dQ6jg42xIvBRGxVbxYYFqEdgMV+3MC8Cl3u27uTDhzAlR+Qz0QkQg ul11kxs0etQOniymNXzakSU8Iad8723KBvlvv5+jx2IH/OmayzEFht17966tahsfmpta OzOpMybLniDzbQ23DOk5h5r1bORxSTRJp9jEeSQujL0Ij7InEqOGugtvEfprspgFeFno LJbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719453277; x=1720058077; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=26NLrLcqWeuhDrXay1Anr6YYmn8BDHZcoGmVUtGJlMA=; b=ozF0caMJL/lYXHv8cxPVYZWCXVI9dOZDtjd3Z6xStIt3UXH/08W9S/pNgwB47KZLbu xMKQs4As4aQh+jkpD1LGpFZY+vq9eu3TcQvyLqgcMoPVQiMXOeb/cSlosQI7RDh3hqoi nbfPdWeLT9CvXDIGwd0QbRD+2ZH1WRNsMurf1pYuoIZhUNk22NwKZjyV3T7p4xSPsHcU vCZEKpW72NAu3aC8gUe0oNFdqS5rzTL8OI9IG7tCODdHjFpLhKoU6GXDMkUJ+bdl3z7f 2Rsvvw6CZ+wBC6CI7gEjFHrNhJeUbuu7zzkNXlC/ekU2j7rb/5sY+DGTZO9Mnr6UQjHI SdEA== X-Forwarded-Encrypted: i=1; AJvYcCVt+AK0QtjmUs5pQ3OKb5cSGNY4rLzpdciKMn/So4G0jL7eQ6+MZI2YdKgcWqfNELclcKIRrIg7u3l+WeUhyBrrrvuKyzz5ZQ== X-Gm-Message-State: AOJu0YxmGwFWW3Cb5Uaoo5jo8nC+0jZtvITrbyp2rE9iMN7XlzQng68o 9q03fjV2QslBynGZOjg1YZTZTRrRNjhcwG8Xpd03R/H9mQlUWqlb X-Google-Smtp-Source: AGHT+IG/uPoaKwZZG5utWTp7aUmUI5WcEsXhkBlnB7621F+wKMFIXO/KnELKK1p9n1hzAlD7YoLIVw== X-Received: by 2002:a05:6870:c0c3:b0:254:a2c2:d3bf with SMTP id 586e51a60fabf-25d32cb6595mr3496966fac.28.1719453276768; Wed, 26 Jun 2024 18:54:36 -0700 (PDT) Received: from [172.31.0.109] ([136.36.72.243]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-25d72ae5ed1sm131804fac.12.2024.06.26.18.54.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Jun 2024 18:54:36 -0700 (PDT) Message-ID: Date: Wed, 26 Jun 2024 19:54:34 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [committed] Remove compromised sh test Content-Language: en-US To: Oleg Endo , "gcc-patches@gcc.gnu.org" References: <9796ab1d-201f-4097-9cc0-cadbc5a6e499@gmail.com> <2b196d4549b15f47c61b34c8e9da09035691b960.camel@t-online.de> <5e3df9ed-dc09-4f86-8bfb-e33d11d6be6f@gmail.com> <4210b775-a58d-42e1-af2b-2bbe893f75e7@gmail.com> <9ab0ed971ab0851a6d40cfe24260e3efd7bf9380.camel@t-online.de> From: Jeff Law In-Reply-To: <9ab0ed971ab0851a6d40cfe24260e3efd7bf9380.camel@t-online.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/26/24 7:27 PM, Oleg Endo wrote: > On Wed, 2024-06-26 at 18:30 -0600, Jeff Law wrote: >>>> >>> >>> OK, then what's the default config of your test setup / triplet? >>> Can you please show the generated code that you get? Because - like I said >>> - I can't reproduce it. >> test01: >> sts.l pr,@-r15 ! 31 [c=4 l=2] movsi_i/10 >> add #-4,r15 ! 32 [c=4 l=2] *addsi3/0 >> mov.l .L3,r0 ! 26 [c=10 l=2] movsi_i/0 >> jsr @r0 ! 12 [c=5 l=2] call_valuei >> mov.l r6,@r15 ! 4 [c=4 l=2] movsi_i/8 >> mov.l @r15,r1 ! 29 [c=1 l=2] movsi_i/5 >> add r1,r0 ! 30 [c=4 l=2] *addsi3/0 >> add #4,r15 ! 36 [c=4 l=2] *addsi3/0 >> lds.l @r15+,pr ! 38 [c=1 l=2] movsi_i/14 >> rts >> nop ! 40 [c=0 l=4] *return_i >> >> >> Note that there's a scheduling barrier in the RTL between insns 30 and >> 36. So instructions prior to insn 36 can't be used to fill the delay slot. >> > > Thanks. Now I'm also seeing the same result. Needed to specify -O2 to get > that. -O1 was not enough it seems. > > I don't know why you said that the code for this case improved -- it has > not?! > > I think the test is still valid. The reason for the failure might be > different from the original one (the scheduling barrier for whatever > reason), but the end result is the same -- the last delay slot is not > stuffed, although the 'add r1,r0' could go in there. > > I'd like to revert the removal of this test case, as it catches a valid > issue. Before the IRA patch there is an additional prologue/epilogue save/restore for a callee saved register. That's what filled the delay slot before. THe add r1,r0 can not move down to fill the delay slot. There's scheduling barrier in the RTL. Feel free to restore it, but you're just adding a bogus, failing, test to the testsuite. jeff