From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 5704D3858D37 for ; Wed, 5 Oct 2022 12:52:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5704D3858D37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 454372189B; Wed, 5 Oct 2022 12:52:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1664974326; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oDYETvnMx1nWktc/OEWzH8k25ekq9Kphoxz+0vf5jps=; b=nasZJyR7xQ+AgH9op87DQRXF9lkXrFIqGn8RVnJfasSzl23kqFrAJ0iBy44EyiybeorXcM NLt/ZPY674T6PnX5u3JOTnG0HLWvu45eTPw/wIZ8P5dUDj4wIDJ0ZeEDIkCV+7L5Y7UVO5 ngm71wCDJyn3dTewIIg/J9U5EJjTlsg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1664974326; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oDYETvnMx1nWktc/OEWzH8k25ekq9Kphoxz+0vf5jps=; b=BzKjUdwTHzPsxpectfr6qqfB2kFbNYpEucQwfH5VRz3MvrA1mdfIZDZ/ZVRDDrv+aQtRnj kqrL7PLaO6UBhnCg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2DF7D13ABD; Wed, 5 Oct 2022 12:52:06 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id yKYvCvZ9PWMudgAAMHmgww (envelope-from ); Wed, 05 Oct 2022 12:52:06 +0000 Content-Type: multipart/mixed; boundary="------------Pqj1Zn9xsemLN0gp0nz3O1R4" Message-ID: Date: Wed, 5 Oct 2022 14:52:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH] c: support attribs starting with '_' Content-Language: en-US To: Jakub Jelinek Cc: gcc-patches@gcc.gnu.org References: From: =?UTF-8?Q?Martin_Li=c5=a1ka?= In-Reply-To: X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------Pqj1Zn9xsemLN0gp0nz3O1R4 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 10/5/22 14:01, Jakub Jelinek wrote: > On Wed, Oct 05, 2022 at 01:49:40PM +0200, Martin Liška wrote: >> PR c/107156 >> >> gcc/ChangeLog: >> >> * attribs.h (lookup_attribute_by_prefix): Support attributes >> starting with underscore (like _noreturn, or __Noreturn). > > There are no _noreturn or __Noreturn attributes, there is just > _Noreturn. > And, the assert is useful to catch that non-canonicalized attributes > don't make it into the attribute lists. > Now that we have the first attribute that starts with an underscore > in canonicalized form (do we accept ___Noreturn__ attribute too, perhaps > we shouldn't?), I'd say instead of removing the assert it should verify > gcc_checking_assert (attr_len == 0 || p[0] != '_' > || (ident_len > 1 && p[1] != '_')); Works for me, I'm going to install the following patch. Martin > ? >> --- >> gcc/attribs.h | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/gcc/attribs.h b/gcc/attribs.h >> index b2836560fc2..706d35e63d8 100644 >> --- a/gcc/attribs.h >> +++ b/gcc/attribs.h >> @@ -274,8 +274,6 @@ lookup_attribute_by_prefix (const char *attr_name, tree list) >> } >> >> const char *p = IDENTIFIER_POINTER (name); >> - gcc_checking_assert (attr_len == 0 || p[0] != '_'); >> - >> if (strncmp (attr_name, p, attr_len) == 0) >> break; >> >> -- >> 2.37.3 > > Jakub > --------------Pqj1Zn9xsemLN0gp0nz3O1R4 Content-Type: text/x-patch; charset=UTF-8; name="0001-c-support-the-attribute-starting-with-_.patch" Content-Disposition: attachment; filename="0001-c-support-the-attribute-starting-with-_.patch" Content-Transfer-Encoding: base64 RnJvbSBiN2ViMWU3YTBlODg3ODQ5NDcwZWM5NmM1ZjMxNDIyYjIyMjRjNDYxIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJ0aW4gTGlza2EgPG1saXNrYUBzdXNlLmN6PgpE YXRlOiBXZWQsIDUgT2N0IDIwMjIgMTI6MzQ6MzAgKzAyMDAKU3ViamVjdDogW1BBVENIXSBj OiBzdXBwb3J0IHRoZSBhdHRyaWJ1dGUgc3RhcnRpbmcgd2l0aCAnXycKCglQUiBjLzEwNzE1 NgoKZ2NjL0NoYW5nZUxvZzoKCgkqIGF0dHJpYnMuaCAobG9va3VwX2F0dHJpYnV0ZV9ieV9w cmVmaXgpOiBTdXBwb3J0IHRoZSBhdHRyaWJ1dGUKCXN0YXJ0aW5nIHdpdGggdW5kZXJzY29y ZSAoX05vcmV0dXJuKS4KLS0tCiBnY2MvYXR0cmlicy5oIHwgNCArKy0tCiAxIGZpbGUgY2hh bmdlZCwgMiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2dj Yy9hdHRyaWJzLmggYi9nY2MvYXR0cmlicy5oCmluZGV4IGIyODM2NTYwZmMyLi4xMjFiOWVi YmMzOSAxMDA2NDQKLS0tIGEvZ2NjL2F0dHJpYnMuaAorKysgYi9nY2MvYXR0cmlicy5oCkBA IC0yNzQsOCArMjc0LDggQEAgbG9va3VwX2F0dHJpYnV0ZV9ieV9wcmVmaXggKGNvbnN0IGNo YXIgKmF0dHJfbmFtZSwgdHJlZSBsaXN0KQogCSAgICB9CiAKIAkgIGNvbnN0IGNoYXIgKnAg PSBJREVOVElGSUVSX1BPSU5URVIgKG5hbWUpOwotCSAgZ2NjX2NoZWNraW5nX2Fzc2VydCAo YXR0cl9sZW4gPT0gMCB8fCBwWzBdICE9ICdfJyk7Ci0KKwkgIGdjY19jaGVja2luZ19hc3Nl cnQgKGF0dHJfbGVuID09IDAgfHwgcFswXSAhPSAnXycKKwkJCSAgICAgICB8fCAoaWRlbnRf bGVuID4gMSAmJiBwWzFdICE9ICdfJykpOwogCSAgaWYgKHN0cm5jbXAgKGF0dHJfbmFtZSwg cCwgYXR0cl9sZW4pID09IDApCiAJICAgIGJyZWFrOwogCi0tIAoyLjM3LjMKCg== --------------Pqj1Zn9xsemLN0gp0nz3O1R4--