From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 59759 invoked by alias); 23 Jun 2018 23:47:43 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 59738 invoked by uid 89); 23 Jun 2018 23:47:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.2 spammy=sk:gfortra, Argument X-HELO: mx2.suse.de Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 23 Jun 2018 23:47:41 +0000 Received: from relay2.suse.de (charybdis-ext-too.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id E7868AB46; Sat, 23 Jun 2018 23:47:38 +0000 (UTC) Subject: Re: [PATCH][testsuite/guality] Be verbose about gdb version used To: Christophe Lyon , Jeff Law Cc: gcc Patches , Mike Stump , Rainer Orth References: <20180622113456.r4pnsat4yz3qwac5@localhost.localdomain> <54fe6363-3dc4-5cde-8ba4-e7b536405a3e@redhat.com> From: Tom de Vries Message-ID: Date: Sat, 23 Jun 2018 23:47:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------316D8550DE52DF62780D9654" X-IsSubscribed: yes X-SW-Source: 2018-06/txt/msg01504.txt.bz2 This is a multi-part message in MIME format. --------------316D8550DE52DF62780D9654 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-length: 1679 On 06/23/2018 07:05 PM, Christophe Lyon wrote: > Hello, > > On Fri, 22 Jun 2018 at 18:01, Jeff Law wrote: >> >> On 06/22/2018 05:35 AM, Tom de Vries wrote: >>> Hi, >>> >>> by default, guality invokes gdb with --quiet to avoid being unnecessarily >>> verbose for each test. But as a consequence, we don't see which version of >>> gdb is used. >>> >>> This patch adds printing of the full path to the gdb used, as well as the >>> gdb version as printed by gdb. >>> >>> Tested on x86_64. >>> >>> OK for trunk? >>> >>> Thanks, >>> - Tom >>> >>> [testsuite/guality] Be verbose about gdb version used >>> >>> 2018-06-22 Tom de Vries >>> >>> * lib/gcc-gdb-test.exp (report_gdb): New proc. >>> * g++.dg/guality/guality.exp: Use report_gdb. >>> * gcc.dg/guality/guality.exp: Same. >>> * gfortran.dg/guality/guality.exp: Same. >> OK. > > It looks like this patch is causing problems when not building gdb. I > my GCC testing, I'm now seeing: > ERROR: tcl error sourcing /gcc/testsuite/gfortran.dg/guality/guality.exp. > ERROR: which: no aarch64-none-linux-gnu-gdb in > (/aci-gcc-fsf/builds/gcc-fsf-gccsrc/tools/bin:/work/local/bin:/aci-gcc-fsf/builds/gcc-fsf-gccsrc/obj-aarch64-none-linux-gnu/gcc3/utils/bin:/usr/local/bin:/bin:/usr/bin:/usr/X11R6/bin) > while executing > "exec which $::env(GUALITY_GDB_NAME)" > invoked from within > "report_gdb [exec which $::env(GUALITY_GDB_NAME)] [info script]" > Hi, the problem is not related to building or not building gdb, it's related to whether the gdb that guality.exp is trying to use, is available in PATH or not. I've fixed this in attached patch. Thanks, - Tom --------------316D8550DE52DF62780D9654 Content-Type: text/x-patch; name="0001-testsuite-guality-Fix-tcl-error-on-missing-gdb.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename*0="0001-testsuite-guality-Fix-tcl-error-on-missing-gdb.patch" Content-length: 2830 [testsuite/guality] Fix tcl error on missing gdb 2018-06-24 Tom de Vries * g++.dg/guality/guality.exp: Don't use which on gdb arg to report_gdb. * gcc.dg/guality/guality.exp: Same. * gfortran.dg/guality/guality.exp: Same. * lib/gcc-gdb-test.exp: Do early out if which gdb fails. --- gcc/testsuite/g++.dg/guality/guality.exp | 2 +- gcc/testsuite/gcc.dg/guality/guality.exp | 2 +- gcc/testsuite/gfortran.dg/guality/guality.exp | 2 +- gcc/testsuite/lib/gcc-gdb-test.exp | 5 +++++ 4 files changed, 8 insertions(+), 3 deletions(-) diff --git a/gcc/testsuite/g++.dg/guality/guality.exp b/gcc/testsuite/g++.dg/guality/guality.exp index e5eaceedc9a..4be22baa19c 100644 --- a/gcc/testsuite/g++.dg/guality/guality.exp +++ b/gcc/testsuite/g++.dg/guality/guality.exp @@ -46,7 +46,7 @@ if ![info exists ::env(GUALITY_GDB_NAME)] { } setenv GUALITY_GDB_NAME "$guality_gdb_name" } -report_gdb [exec which $::env(GUALITY_GDB_NAME)] [info script] +report_gdb $::env(GUALITY_GDB_NAME) [info script] if {[check_guality " #include \"$srcdir/$subdir/guality.h\" diff --git a/gcc/testsuite/gcc.dg/guality/guality.exp b/gcc/testsuite/gcc.dg/guality/guality.exp index 2a90ec3c8c8..04e889caa2f 100644 --- a/gcc/testsuite/gcc.dg/guality/guality.exp +++ b/gcc/testsuite/gcc.dg/guality/guality.exp @@ -46,7 +46,7 @@ if ![info exists ::env(GUALITY_GDB_NAME)] { } setenv GUALITY_GDB_NAME "$guality_gdb_name" } -report_gdb [exec which $::env(GUALITY_GDB_NAME)] [info script] +report_gdb $::env(GUALITY_GDB_NAME) [info script] if {[check_guality " #include \"$srcdir/$subdir/guality.h\" diff --git a/gcc/testsuite/gfortran.dg/guality/guality.exp b/gcc/testsuite/gfortran.dg/guality/guality.exp index 3784cac1ef3..f76347dd52f 100644 --- a/gcc/testsuite/gfortran.dg/guality/guality.exp +++ b/gcc/testsuite/gfortran.dg/guality/guality.exp @@ -27,7 +27,7 @@ if ![info exists ::env(GUALITY_GDB_NAME)] { } setenv GUALITY_GDB_NAME "$guality_gdb_name" } -report_gdb [exec which $::env(GUALITY_GDB_NAME)] [info script] +report_gdb $::env(GUALITY_GDB_NAME) [info script] gfortran-dg-runtest [lsort [glob $srcdir/$subdir/*.\[fF\]{,90,95,03,08} ]] "" "" diff --git a/gcc/testsuite/lib/gcc-gdb-test.exp b/gcc/testsuite/lib/gcc-gdb-test.exp index f3726635c03..9aff6218300 100644 --- a/gcc/testsuite/lib/gcc-gdb-test.exp +++ b/gcc/testsuite/lib/gcc-gdb-test.exp @@ -145,6 +145,11 @@ proc gdb-test { args } { # Argument 1 is the location where gdb is used # proc report_gdb { gdb loc } { + if { [catch { exec which $gdb } msg] } { + send_log "gdb not found in $loc: $msg\n" + return + } + set gdb [exec which $gdb] send_log "gdb used in $loc: $gdb\n" set gdb_version [exec $gdb -v] send_log "gdb used in $loc: version:\n---\n$gdb_version\n---\n" --------------316D8550DE52DF62780D9654--