From: Robin Dapp <rdapp.gcc@gmail.com>
To: Juzhe-Zhong <juzhe.zhong@rivai.ai>, gcc-patches@gcc.gnu.org
Cc: rdapp.gcc@gmail.com, kito.cheng@gmail.com, kito.cheng@sifive.com,
jeffreyalaw@gmail.com
Subject: Re: [PATCH V4] RISC-V: Support Dynamic LMUL Cost model
Date: Tue, 12 Sep 2023 11:17:58 +0200 [thread overview]
Message-ID: <b2d56ec5-6bed-ba76-dd8e-5cfd57a63dc0@gmail.com> (raw)
In-Reply-To: <20230912064932.647337-1-juzhe.zhong@rivai.ai>
I did some benchmarks and, at least for calculix the differences are
miniscule. I'd say we can stick with the current approach and improve
as needed.
However, I noticed ICEs here:
+ gcc_assert (biggest_size >= mode_size);
and here:
+ mode = TYPE_MODE (TREE_TYPE (lhs));
when compiling calculix.
Regards
Robin
next prev parent reply other threads:[~2023-09-12 9:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 6:49 Juzhe-Zhong
2023-09-12 8:19 ` Robin Dapp
2023-09-12 9:14 ` juzhe.zhong
2023-09-12 9:17 ` Robin Dapp [this message]
2023-09-12 9:25 ` juzhe.zhong
2023-09-12 9:31 ` Robin Dapp
2023-09-12 9:36 ` juzhe.zhong
2023-09-12 10:57 ` Robin Dapp
[not found] ` <2023091217364091739043@rivai.ai>
2023-09-12 9:38 ` juzhe.zhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2d56ec5-6bed-ba76-dd8e-5cfd57a63dc0@gmail.com \
--to=rdapp.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
--cc=juzhe.zhong@rivai.ai \
--cc=kito.cheng@gmail.com \
--cc=kito.cheng@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).