From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa2.mentor.iphmx.com (esa2.mentor.iphmx.com [68.232.141.98]) by sourceware.org (Postfix) with ESMTPS id 4B9D93858D1E for ; Mon, 6 Feb 2023 23:15:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4B9D93858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.97,276,1669104000"; d="scan'208";a="97162438" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa2.mentor.iphmx.com with ESMTP; 06 Feb 2023 15:15:03 -0800 IronPort-SDR: fQANqVCxIVuaUMBOTVasAiKBHJZKjJjJc1X182EnjuflRKnvbXNuMwJtsvRRpbfbgpSK3BUiGD 2qcR85CkD5c8Hl1b5+540QawjZbhlLNlS3PjskF3Cy5Q2QzBv27JDhwXFhpiNn58jM6QpJCIBD R2GTxJTzoxGKFgCRce8K/1wYxiuLF5e27fZy8oHLZ8FXJkipGw4X48XFi65GjWxxzZkiesASk1 7KDVr94T7Q8zlUPqe1zdaYkT9Cp0JiqlWrPKfoEwae3JnSSPfwoOvNtLYyqmHzF6TeIdXF+A9N 6Oc= Date: Mon, 6 Feb 2023 23:14:53 +0000 From: Joseph Myers To: Qing Zhao CC: Richard Biener , "gcc-patches@gcc.gnu.org" , "siddhesh@gotplt.org" , "keescook@chromium.org" Subject: Re: [PATCH 1/2] Handle component_ref to a structre/union field including flexible array member [PR101832] In-Reply-To: <4E515AA5-2069-497E-A301-EC8ED744E780@oracle.com> Message-ID: References: <20230131141140.3610133-1-qing.zhao@oracle.com> <20230131141140.3610133-2-qing.zhao@oracle.com> <812910BC-870E-4432-870D-538024F1A510@oracle.com> <3B30CFBF-5004-41A4-940D-1F23C010403B@oracle.com> <4E515AA5-2069-497E-A301-EC8ED744E780@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-11.mgc.mentorg.com (139.181.222.11) To svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) X-Spam-Status: No, score=-3108.6 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,KAM_SHORT,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 6 Feb 2023, Qing Zhao via Gcc-patches wrote: > In GCC14: > > 1. Include this new warning -Wgnu-varaible-sized-type-not-at-end to -Wall > 2. Deprecate this extension from GCC. (Or delay this to next release?). Any deprecation, or inclusion in -Wall, would best come with evidence about the prevalance of use (possibly unintentional, probably undesirable) of these extensions. For example, maybe someone could do a distribution rebuild with a patch to enable these warnings and report the results? Various misuses of flexible array members are only pedwarns-if-pedantic because of such uses - and while the original motivating case was _G_config.h, which has since been fixed (though existing installed headers from old glibc would need fixincluding, at least if it becomes an error), it's very plausible there are uses of these extensions elsewhere. -- Joseph S. Myers joseph@codesourcery.com