public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Takayuki 'January June' Suwa <jjsuwa_sys3175@yahoo.co.jp>
To: Max Filippov <jcmvbkbc@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] xtensa: Optimize stack frame adjustment more
Date: Sat, 7 Jan 2023 11:54:50 +0900	[thread overview]
Message-ID: <b2e294a3-6a30-3c72-edec-3d9edb55bda5@yahoo.co.jp> (raw)
In-Reply-To: <CAMo8BfJfEd4BWUpZ41MdnhoESFvYkMnmcoE458RK2S5vgyLdhg@mail.gmail.com>

On 2023/01/06 17:05, Max Filippov wrote:
> On Thu, Jan 5, 2023 at 10:57 PM Takayuki 'January June' Suwa
> <jjsuwa_sys3175@yahoo.co.jp> wrote:
>> By using the helper function, it makes stack frame adjustment logic
>> simplified and instruction count less in some cases.
> 
> I've built a couple linux configurations with and without this change and
> I observe consistent code size growth, e.g.:
> 
> iss_defconfig without the change:
>   text    data     bss     dec     hex filename
> 3014768  164016  115108 3293892  3242c4 vmlinux
> 
> iss_defconfig with the change:
>   text    data     bss     dec     hex filename
> 3015296  164008  115108 3294412  3244cc vmlinux
> 
> virt_defconfig without the change:
>   text    data     bss     dec     hex filename
> 5498881 2254360  291768 8045009  7ac1d1 vmlinux
> 
> virt_defconfig with the change:
>   text    data     bss     dec     hex filename
> 5500389 2254360  291768 8046517  7ac7b5 vmlinux
> 
> generic_kc705_defconfig without the change:
>   text    data     bss     dec     hex filename
> 7062530  635340  286400 7984270  79d48e vmlinux
> 
> generic_kc705_defconfig with the change:
>   text    data     bss     dec     hex filename
> 7064078  635340  286400 7985818  79da9a vmlinux
> 

Probably due to this location:
> +  else if (TARGET_DENSITY && optimize_size && xtensa_simm12b (imm))
                             ^^^^^^^^^^^^^^^^
I omitted it in the new patch, so please check it.

      reply	other threads:[~2023-01-07  2:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <04a89dbf-c2a3-5dcb-8949-77569a1ad169.ref@yahoo.co.jp>
2023-01-05  8:40 ` Takayuki 'January June' Suwa
2023-01-05 21:32   ` Max Filippov
2023-01-06  3:34     ` Takayuki 'January June' Suwa
2023-01-06  6:26       ` Max Filippov
2023-01-06  6:57         ` Takayuki 'January June' Suwa
2023-01-06  8:05           ` Max Filippov
2023-01-07  2:54             ` Takayuki 'January June' Suwa [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b2e294a3-6a30-3c72-edec-3d9edb55bda5@yahoo.co.jp \
    --to=jjsuwa_sys3175@yahoo.co.jp \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jcmvbkbc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).