From: Jeff Law <jeffreyalaw@gmail.com>
To: apinski@marvell.com, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 7/7] Port most of the A CMP 0 ? A : -A to match
Date: Thu, 24 Jun 2021 09:19:04 -0600 [thread overview]
Message-ID: <b2e4b37a-3988-ca46-a369-646e35a6f978@gmail.com> (raw)
In-Reply-To: <1624486755-12879-8-git-send-email-apinski@marvell.com>
On 6/23/2021 4:19 PM, apinski--- via Gcc-patches wrote:
> From: Andrew Pinski <apinski@marvell.com>
>
> To improve phiopt and be able to remove abs_replacement, this ports
> most of "A CMP 0 ? A : -A" from fold_cond_expr_with_comparison to
> match.pd. There is a few extra changes that are needed to remove
> the "A CMP 0 ? A : -A" part from fold_cond_expr_with_comparison:
> * Need to handle (A - B) case
> * Need to handle UN* comparisons.
>
> I will handle those in a different patch.
>
> Note phi-opt-15.c test needed to be updated as we get ABSU now
> instead of not getting ABS. When ABSU was added phiopt was not
> updated even to use ABSU instead of not creating ABS.
>
> OK? Bootstrapped and tested on x86_64-linux-gnu with no regressions.
>
> gcc/ChangeLog:
>
> * match.pd (A CMP 0 ? A : -A): New patterns.
> * tree-ssa-phiopt.c (abs_replacement): Delete function.
> (tree_ssa_phiopt_worker): Don't call abs_replacement.
> Update comment about abs_replacement.
>
> gcc/testsuite/ChangeLog:
>
> * gcc.dg/tree-ssa/phi-opt-15.c: Update test to expect
> ABSU and still not expect ABS_EXPR.
And I've already ack'd this part :-) I think it's unchanged since he
original.
Jeff
next prev parent reply other threads:[~2021-06-24 15:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-23 22:19 [PATCH 0/7] PHI-OPT move abs_replacement to match.pd apinski
2021-06-23 22:19 ` [PATCH 1/7] Expand the comparison argument of fold_cond_expr_with_comparison apinski
2021-06-24 15:11 ` Jeff Law
2021-06-23 22:19 ` [PATCH 2/7] Reset the range info on the moved instruction in PHIOPT apinski
2021-06-24 15:11 ` Jeff Law
2021-06-23 22:19 ` [PATCH 3/7] Duplicate the range information of the phi onto the new ssa_name apinski
2021-06-24 15:16 ` Jeff Law
2021-06-26 6:21 ` Andrew Pinski
2021-06-23 22:19 ` [PATCH 4/7] Allow match-and-simplified phiopt to run in early phiopt apinski
2021-06-24 16:23 ` Jeff Law
2021-06-25 8:24 ` Richard Biener
2021-06-29 15:17 ` Jeff Law
2021-06-23 22:19 ` [PATCH 5/7] Try inverted comparison for match_simplify in phiopt apinski
2021-06-24 13:02 ` Bernhard Reutner-Fischer
2021-06-24 15:17 ` Jeff Law
2021-06-23 22:19 ` [PATCH 6/7] Lower for loops before lowering cond in genmatch apinski
2021-06-24 16:25 ` Jeff Law
2021-06-23 22:19 ` [PATCH 7/7] Port most of the A CMP 0 ? A : -A to match apinski
2021-06-24 15:19 ` Jeff Law [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-06-19 21:49 apinski
2021-06-24 15:08 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2e4b37a-3988-ca46-a369-646e35a6f978@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=apinski@marvell.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).