From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 79451 invoked by alias); 11 Oct 2017 22:41:18 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 79393 invoked by uid 89); 11 Oct 2017 22:41:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 11 Oct 2017 22:41:09 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7401E5F299B for ; Wed, 11 Oct 2017 22:41:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 7401E5F299B Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=vmakarov@redhat.com Received: from [10.10.120.77] (ovpn-120-77.rdu2.redhat.com [10.10.120.77]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0B42917CF7; Wed, 11 Oct 2017 22:41:06 +0000 (UTC) Subject: Re: patch to fix PR82353 To: Jakub Jelinek References: <20171011211106.GQ14653@tucnak> Cc: gcc-patches From: Vladimir Makarov Message-ID: Date: Wed, 11 Oct 2017 22:54:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20171011211106.GQ14653@tucnak> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg00713.txt.bz2 On 10/11/2017 05:11 PM, Jakub Jelinek wrote: > On Wed, Oct 11, 2017 at 03:39:21PM -0400, Vladimir Makarov wrote: >> The following patch fixes >> >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82353 >> >> LRA did not update hard reg liveness on bb borders for hard regs which are >> part of insn patterns like CFLAGS reg. It was ok for inheritance in EBB >> which creates only moves and they usually have no embedded hard regs in the >> patterns. But LRA rematerialization needs this. So this patch implements >> such hard reg liveness updates. >> >> The patch was successfully bootstrapped and tested on x86-64. >> >> Committed as rev. 253656. > Thanks for the fix, however I believe we do not want C++ tests in > gcc.target/*/, those are historically handled in g++.dg/ (and if we wanted > to have them, we'd introduce g++.target/*/), furthermore the test requires > working -fsanitize=undefined and such tests belog into g++.dg/ubsan/ > if they are in C++. And finally, the test fails on i386, where we > rematerialize something else, so I think we should just limit it to lp64. I just followed arch64 which has C++ tests in gcc.target/arch64. I think we will have more and more target tests on C++ in the future, so probably having g++.target is a good idea. > Tested on x86_64-linux -m32/-m64, and verified with cc1plus before your > change, ok for trunk? > > Sure, Jakub.