From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rusty.tulip.relay.mailchannels.net (rusty.tulip.relay.mailchannels.net [23.83.218.252]) by sourceware.org (Postfix) with ESMTPS id 9FFF0385843A for ; Tue, 31 Oct 2023 17:58:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9FFF0385843A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=eagercon.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=eagercon.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9FFF0385843A Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=23.83.218.252 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1698775128; cv=pass; b=fqyDe6u25E5lepAOIamiIGeSuph74U0s0dtOffW+N/NNUVaROor39cToqgAvDHU9yw0iu76xGTtAA5SK9lYfke7AqG9+vrnXJqs6MpkTr3gvtxBtO2P1huc0bh7SFzdqRDpEaAlzaa4dNOsa9l3Kbx8kp1S4WzmFA3EKVAhu2aw= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1698775128; c=relaxed/simple; bh=Uhft3XwdEue/vFFk2YdmXyUFwnlvHB8ixeFOWkTGYm0=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=i5T+urTMu/IVw1EeyQ3Zaq3XVq7l+u5n+pTwCG7IU0yeBpTZrnvschDrE9Ug+1rNHKCm8ZPf8USWyYqLtmXrSfiVCZ0WyU4d7WXhdKz9tHJ7g8L7XJqAtkx9HCcjo20fpDhMkQl3y5Vjr8rHhmeGyoe7i7be5aco04dd0Rl50gM= ARC-Authentication-Results: i=2; server2.sourceware.org X-Sender-Id: dreamhost|x-authsender|eager@eagerm.com Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id A3D4C362819; Tue, 31 Oct 2023 17:58:36 +0000 (UTC) Received: from pdx1-sub0-mail-a238.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 4DDD83627D4; Tue, 31 Oct 2023 17:58:36 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1698775116; a=rsa-sha256; cv=none; b=PcZFhaJE4zRxfPF2kilbYtLaUCjhZT/+uEeS2YhLRBU1+sNa1kPbHFSmsrxtSoWd/eGmpZ hRNEEiq6+qCC/D4paDSYxVybybawc6ORgIkZLBYP4SG4dJTsJkCFdLo12jdcqxWs6XHmcJ wTDfqSuKfwf74QHqrDWTFDOqpX864zK5Mcp4T4wIlKR8KpLIzsiKKQ1a1CkewHhvx9GIx4 Xq6pckqzrAITUy+VATshI7yRG7oUDWCJ3A9XIcxPfZrgZ1gFI24FOexq/2QauhSrD+kiC5 vrz8ahue4faQ/viu11+fytC6az/kyi02wfxcGJTpzJ8+4dqCeEIKRuHqdYUilA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1698775116; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+fYhW7o5dDTxIZSXs2ASbjoviARezqFXs/BzFIme7j0=; b=Iu6LjgVXfCFM6KrcoYtn+oc3nQsLflily2NWlibv6rcQBzjtcwwtoAxW0ouW1G16cO+4JA oxQNPjBPBnq9Lxgyr1Fhjdu+8FvBZ4XPVtycWe4/z5zZOLermivgqnupqd1nSq4WYIhLWj AQhLhCN57MT5dM5I3R5dQWXBbsvhzq8vRbe/3jp/IDmggGeB6WJ2XFEciIhzBFgjYSPOQK ahjUha6rz5sNIc3tD9x5ZO21SpEW2tDSkc8DYC9M/fYXtCZmua6I6JVWqi9/sOnZdaRoOE /c89UeRs9lkfcTHfggVH9oHLWH8KqpiSG70q4B68euoqCIFB4/6MTK+r1GMODg== ARC-Authentication-Results: i=1; rspamd-86646d89b6-p2nqw; auth=pass smtp.auth=dreamhost smtp.mailfrom=eager@eagercon.com X-Sender-Id: dreamhost|x-authsender|eager@eagerm.com X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|eager@eagerm.com X-MailChannels-Auth-Id: dreamhost X-Daffy-Abortive: 7c3388740d02e6e6_1698775116525_2815538881 X-MC-Loop-Signature: 1698775116525:3386834258 X-MC-Ingress-Time: 1698775116525 Received: from pdx1-sub0-mail-a238.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.103.105.139 (trex/6.9.2); Tue, 31 Oct 2023 17:58:36 +0000 Received: from [192.168.20.10] (c-73-170-238-207.hsd1.ca.comcast.net [73.170.238.207]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) (Authenticated sender: eager@eagerm.com) by pdx1-sub0-mail-a238.dreamhost.com (Postfix) with ESMTPSA id 4SKdDC5FDMz2J; Tue, 31 Oct 2023 10:58:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eagercon.com; s=dreamhost; t=1698775116; bh=+fYhW7o5dDTxIZSXs2ASbjoviARezqFXs/BzFIme7j0=; h=Date:Subject:To:Cc:From:Content-Type:Content-Transfer-Encoding; b=K9n9eaf4fIxvAFJZpjMAfjlMY85LOYLjC1wADDLfNTDZX9tSvGI0UkeNVtS93vJRN sairpZKLsbPmgI4IqFRBhynwTTHPrZ6LigNLnCzh7DJ+gKD/k2WP7UdkZq6/TV2rro rkNTCRHSJ7OY6Is3VxmrZxb+LU4SwyGaufopYKh6nEuif2CXvaYjiX3/Iss0J54dpl R0EXBmsnw0Ybh0DabK9pDnqBXhOON6RMDeZurfTWcxVOX9GBCkM5mXN5V7z5cU9kMW Hxfek1Io/duCnFi9j8MA8Qzyx8P4ReFBSi616hrfpi9HAlhydnENl/Zc9D49y7vL1A Yl2aW8kmI2EVg== Message-ID: Date: Tue, 31 Oct 2023 10:58:34 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 1/1] gcc: config: microblaze: fix cpu version check Content-Language: en-US To: "Frager, Neal" , "gcc-patches@gcc.gnu.org" , "eager@eagerm.com" Cc: "Erkiaga Elorza, Ibai" , "Mekala, Nagaraju" , "Hatle, Mark" , "Mutyala, Sadanand" , "Nali, Appa Rao" , "Hunsigida, Vidhumouli" , "luca.ceresoli@bootlin.com" References: <20231030170253.293494-1-neal.frager@amd.com> From: Michael Eager In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/31/23 09:41, Frager, Neal wrote: > Hi Michael, > >> The MICROBLAZE_VERSION_COMPARE was incorrectly using strcasecmp >> instead of strverscmp to check the mcpu version against feature >> options. By simply changing the define to use strverscmp, the new >> version 10.0 is treated correctly as a higher version than previous >> versions. >> >> Signed-off-by: Neal Frager > >> Added to commit message; >> Fix incorrect warning with -mcpu=10.0: >> warning: '-mxl-multiply-high' can be used only with >> '-mcpu=v6.00.a' or greater > >> --- >> V1->V2: >> - No need to create a new microblaze specific version check >> routine as strverscmp is the correct solution. >> V2->V3: >> - Changed mcpu define for microblaze isa testsuite examples. >> V3->V4: >> - Added ChangeLog >> V4->V5: >> - Added testsuite ChangeLog >> V5->V6: >> - Updated testsuite ChangeLog to include all files >> --- >> gcc/ChangeLog | 4 ++++ >> gcc/config/microblaze/microblaze.cc | 2 +- >> gcc/testsuite/ChangeLog | 22 +++++++++++++++++++ >> .../gcc.target/microblaze/isa/bshift.c | 2 +- >> gcc/testsuite/gcc.target/microblaze/isa/div.c | 2 +- >> .../gcc.target/microblaze/isa/fcmp1.c | 2 +- >> .../gcc.target/microblaze/isa/fcmp2.c | 2 +- >> .../gcc.target/microblaze/isa/fcmp3.c | 2 +- >> .../gcc.target/microblaze/isa/fcmp4.c | 2 +- >> .../gcc.target/microblaze/isa/fcvt.c | 2 +- >> .../gcc.target/microblaze/isa/float.c | 2 +- >> .../gcc.target/microblaze/isa/fsqrt.c | 2 +- >> .../microblaze/isa/mul-bshift-pcmp.c | 2 +- >> .../gcc.target/microblaze/isa/mul-bshift.c | 2 +- >> gcc/testsuite/gcc.target/microblaze/isa/mul.c | 2 +- >> .../microblaze/isa/mulh-bshift-pcmp.c | 2 +- >> .../gcc.target/microblaze/isa/mulh.c | 2 +- >> .../gcc.target/microblaze/isa/nofcmp.c | 2 +- >> .../gcc.target/microblaze/isa/nofloat.c | 2 +- >> .../gcc.target/microblaze/isa/pcmp.c | 2 +- >> .../gcc.target/microblaze/isa/vanilla.c | 2 +- >> .../gcc.target/microblaze/microblaze.exp | 2 +- >> 22 files changed, 46 insertions(+), 20 deletions(-) > >> Committed. > > Did you commit this patch? I only see the ChangeLog files have been > updated by your commit. > > Am I missing something? > Updated. -- Michael Eager