From: Jeff Law <law@redhat.com>
To: Alan Hayward <alan.hayward@arm.com>, gcc-patches@gcc.gnu.org
Cc: nd@arm.com
Subject: Re: [PATCH v2 7/7] Enable clobber high for tls descs on Aarch64
Date: Sat, 04 Aug 2018 04:27:00 -0000 [thread overview]
Message-ID: <b31f81b4-e25d-6db2-e982-161bf82b8672@redhat.com> (raw)
In-Reply-To: <20180726091329.26875-8-alan.hayward@arm.com>
On 07/26/2018 03:13 AM, Alan Hayward wrote:
> Add the clobber high expressions to tls_desc for aarch64.
> It also adds three tests.
>
> In addition I also tested by taking the gcc torture test suite and making
> all global variables __thread. Then emended the suite to compile with -fpic,
> save the .s file and only for one given O level.
> I ran this before and after the patch and compared the resulting .s files,
> ensuring that there were no ASM changes.
> I discarded the 10% of tests that failed to compile (due to the code in
> the test now being invalid C).
> I did this for O0,O2,O3 on both x86 and aarch64 and observed no difference
> between ASM files before and after the patch.
>
> Alan.
>
> 2018-07-25 Alan Hayward <alan.hayward@arm.com>
>
> gcc/
> * config/aarch64/aarch64.md: Add clobber highs to tls_desc.
>
> gcc/testsuite/
> * gcc.target/aarch64/sve_tls_preserve_1.c: New test.
> * gcc.target/aarch64/sve_tls_preserve_2.c: New test.
> * gcc.target/aarch64/sve_tls_preserve_3.c: New test.
AArch64 specific, so leaving it to the AArch64 maintainers to handle review.
jeff
next prev parent reply other threads:[~2018-08-04 4:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-26 9:14 [PATCH v2 0/7] Support partial clobbers around TLS calls on Aarch64 SVE Alan Hayward
2018-07-26 9:14 ` [PATCH v2 5/7] cse support for clobber_high Alan Hayward
2018-08-04 4:26 ` Jeff Law
2018-07-26 9:14 ` [PATCH v2 7/7] Enable clobber high for tls descs on Aarch64 Alan Hayward
2018-08-04 4:27 ` Jeff Law [this message]
2018-08-06 13:15 ` Richard Sandiford
2018-07-26 9:14 ` [PATCH v2 3/7] Add func to check if register is clobbered by clobber_high Alan Hayward
2018-08-04 4:12 ` Jeff Law
2018-07-26 9:14 ` [PATCH v2 6/7] Remaining support for clobber high Alan Hayward
2018-08-04 4:30 ` Jeff Law
2018-12-13 10:11 ` Jakub Jelinek
2018-07-26 9:14 ` [PATCH v2 2/7] Generation support for CLOBBER_HIGH Alan Hayward
2018-08-04 4:09 ` Jeff Law
2018-07-26 9:14 ` [PATCH v2 4/7] lra support for clobber_high Alan Hayward
2018-08-04 4:21 ` Jeff Law
2018-07-26 9:14 ` [PATCH v2 1/7] Add CLOBBER_HIGH expression Alan Hayward
2018-08-04 4:04 ` Jeff Law
2018-08-02 13:01 ` PING [PATCH v2 0/7] Support partial clobbers around TLS calls on Aarch64 SVE Alan Hayward
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b31f81b4-e25d-6db2-e982-161bf82b8672@redhat.com \
--to=law@redhat.com \
--cc=alan.hayward@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).