From: Jason Merrill <jason@redhat.com>
To: Marek Polacek <polacek@redhat.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: C++ PATCH to tweak variadic126.C test (PR c++/88866)
Date: Tue, 15 Jan 2019 18:29:00 -0000 [thread overview]
Message-ID: <b329bdc9-fcef-4991-5bb8-ee2e960214d4@redhat.com> (raw)
In-Reply-To: <20190115182718.GH19569@redhat.com>
On 1/15/19 1:27 PM, Marek Polacek wrote:
> This test was failing in c++2a because the error messages are different
> because we're now trying to parse braced-list in template-argument-list.
>
> Tested on x86_64-linux, ok for trunk?
>
> 2019-01-15 Marek Polacek <polacek@redhat.com>
>
> PR c++/88866
> * g++.dg/cpp0x/variadic126.C: Tweak dg-error.
>
> diff --git gcc/testsuite/g++.dg/cpp0x/variadic126.C gcc/testsuite/g++.dg/cpp0x/variadic126.C
> index 513c7e54a07..a219309f058 100644
> --- gcc/testsuite/g++.dg/cpp0x/variadic126.C
> +++ gcc/testsuite/g++.dg/cpp0x/variadic126.C
> @@ -3,6 +3,6 @@
>
> template < typename ... > struct A;
>
> -struct B : A < // { dg-error "invalid" }
> +struct B : A < // { dg-error "invalid" "" { target c++17_down } }
> {
> -};
> +}; // { dg-error "mismatch|expected" "" { target c++2a } }
OK.
Jason
prev parent reply other threads:[~2019-01-15 18:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 18:27 Marek Polacek
2019-01-15 18:29 ` Jason Merrill [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b329bdc9-fcef-4991-5bb8-ee2e960214d4@redhat.com \
--to=jason@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=polacek@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).