From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by sourceware.org (Postfix) with ESMTPS id 854103857354 for ; Thu, 29 Sep 2022 20:46:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 854103857354 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x635.google.com with SMTP id v1so2238917plo.9 for ; Thu, 29 Sep 2022 13:46:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=aeT0ZDRALrQOSOtqPQPACDePMlXygY3zzVCoeXj059A=; b=btpxKzQT9a+q5Tx4jLuSfibb76s6DpqXMIvVMo5MJZr3MgpaNDCrDro9jsv4ngOP8R Qi/szPLrcd/H8CNwnTq1v1AVE0GQIc9MK9SvBMej/xhzbjneI4GUqzIZ0ByIkx0Kt1Oz JB88iMI6e1ch76zMtnJl7XmLdV0FPzkzRxPJjzPFF3/s6/CSSYjkv/dd6YUwe2mzbsjT FpZT14G+JP19OoeBhnyhvAFYDwgmmMWsLiszJb1uGaiVl43vNJXQq/Q+igZaHeeowdVm 6nt0jhsReN3kZe8KLhbY8ptv5j3sy1qY3fkEBBdciFVqWdIsfNd05BcS7Sikdn5ll1S6 9SGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=aeT0ZDRALrQOSOtqPQPACDePMlXygY3zzVCoeXj059A=; b=ZczWHmewS/HigFvaLX60rE9XNUkva7g/dUyDOpzjh1SVi82nE8nvE6rW91inD8EBDc r3gAtOeKO5mE0GlwsuBTZnWsQOliU1nKE0nN3aF9phqzI+22DF6mDX1VBhfKM4ih/HMU m6jLGb/+ANk07vOlwPK/xO4QkRZNXXfQNSB109OD29CH8nxHOeJjYX8aGSkiPQclWrkv PmZPFLCyZQW1zFoKwHx5QisTMZusER374dAUE5xbLoSuljHFI6HEuTl5ItmLofg2RqYT 0KGUevGchd/GGf0ETljv/rm99JM7oZtJ2i6P8tUygkC9sBHlIbjOo9/KjM3tJiIfxWSJ al+w== X-Gm-Message-State: ACrzQf0gyX6yRS9tZVaQ2Mw5iBnRvoNB88pexEw2yhBLjeU+ZYEfonT3 yx5U46Vuzr0TfZYtt0gzHHRIXeS+EVykdQ== X-Google-Smtp-Source: AMsMyM6ZIt7GpIdA9kx02LfDBS28OJC8KCucGsZrWCKLmlQmvcMzLTB9vQ303D6eU1lrq3HfPOcG5g== X-Received: by 2002:a17:902:d40c:b0:178:4439:69f9 with SMTP id b12-20020a170902d40c00b00178443969f9mr5386013ple.118.1664484418049; Thu, 29 Sep 2022 13:46:58 -0700 (PDT) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id g8-20020aa79f08000000b00537daf64e8esm90716pfr.188.2022.09.29.13.46.57 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Sep 2022 13:46:57 -0700 (PDT) Message-ID: Date: Thu, 29 Sep 2022 14:46:56 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH] Don't ICE running selftests if errors were raised [PR99723] Content-Language: en-US To: gcc-patches@gcc.gnu.org References: <20220927151214.1082396-1-andrea.corallo@arm.com> From: Jeff Law In-Reply-To: <20220927151214.1082396-1-andrea.corallo@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 9/27/22 09:12, Andrea Corallo via Gcc-patches wrote: > Hi all > > this is to address PR 99723. > > In the PR GCC crashes as the initialization of common trees is not > performed as no compilation is happening, this is because we raise an > error earlier while processing the arch flags. > > This patch changes the code to execute selftests only if no errors > where raised before. > > Bootstrapped on aarch64, okay for trunk? > > Best Regards > > Andrea > > 2022-09-27 Andrea Corallo > > * toplev.cc (toplev::main): Don't run self tests in case of > previous error. OK jeff