From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id DA5693858D35 for ; Fri, 14 Apr 2023 05:11:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DA5693858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 33E3EaCl018467; Fri, 14 Apr 2023 05:11:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=JU8CIXP28bGt9bL7XEIG8uzq2w7lFkGiFAcq6WLTRiQ=; b=ikPsgoOcA8GH/Tc3L/GG+Wk2bn0pKVGL9gwZhWZd/WTptecfVrAIv3rrecG9K/4eSSAY cBWBix2iJ2W5JiwMy0fHTCisq89qkfw5Yx+4LuNtUG6pgSfhnr5gWoa4GYWC5BGy4dtu 1xH4ssn4ArXkxPLKV9gyZtqxa2KuilGy2kA28W1JA8KkcL7GAByWjpMbe383cPRNQVBS oOb+SlA8FmuCgw2hodbJWduM5BmRN/s8wVEtfieOJbNokj9fw+ENCCq38j3FC8ktGozo 8W9SCCUguQl/ItQHpZ8SyMe1M5ZZWggyP/ltWdkZqbmyn7lKDm3bgmvLM1pVuErM2+7D dw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3pxx96uq4m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 14 Apr 2023 05:11:49 +0000 Received: from m0098404.ppops.net (m0098404.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 33E4p1g6007408; Fri, 14 Apr 2023 05:11:49 GMT Received: from ppma06ams.nl.ibm.com (66.31.33a9.ip4.static.sl-reverse.com [169.51.49.102]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3pxx96uq3b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 14 Apr 2023 05:11:49 +0000 Received: from pps.filterd (ppma06ams.nl.ibm.com [127.0.0.1]) by ppma06ams.nl.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 33E3rAiK005093; Fri, 14 Apr 2023 05:11:46 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma06ams.nl.ibm.com (PPS) with ESMTPS id 3pu0m23ec3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 14 Apr 2023 05:11:46 +0000 Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 33E5Bhqs2294348 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 14 Apr 2023 05:11:43 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 25D8C20040; Fri, 14 Apr 2023 05:11:43 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C11C720043; Fri, 14 Apr 2023 05:11:40 +0000 (GMT) Received: from [9.177.69.38] (unknown [9.177.69.38]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP; Fri, 14 Apr 2023 05:11:40 +0000 (GMT) Message-ID: Date: Fri, 14 Apr 2023 13:11:38 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH, rs6000] xfail float128 comparison test case that fails on powerpc64 [PR108728] Content-Language: en-US To: HAO CHEN GUI Cc: Segher Boessenkool , David , Peter Bergner , gcc-patches References: <84c7ea10-5f15-03b8-3354-487665e7e409@linux.ibm.com> From: "Kewen.Lin" In-Reply-To: <84c7ea10-5f15-03b8-3354-487665e7e409@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 5JionwQ7wL4A1P6LO0qvzPm0JFURCTI2 X-Proofpoint-ORIG-GUID: Y612sHlWFc2g5FznklzqIBIe3QEe1Wdw X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-14_02,2023-04-13_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 mlxscore=0 lowpriorityscore=0 adultscore=0 mlxlogscore=999 spamscore=0 phishscore=0 bulkscore=0 priorityscore=1501 suspectscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2304140045 X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Haochen, on 2023/4/14 09:34, HAO CHEN GUI wrote: > Hi Kewen, > > 在 2023/4/13 16:32, Kewen.Lin 写道: >> xfail all powerpc*-*-* can have some XPASSes on those ENVs with >> software emulation. Since the related hw insn xscmpuqp is guarded >> with TARGET_FLOAT128_HW, could we use the effective target >> ppc_float128_hw instead? > > Thanks for your review comments. It's tricky. It invokes "__lekf2" > with "-mno-float128_hw". But it doesn't always pass the check. > With math library on P8, it can. With the library on P9, it fails. Math library doesn't provide it, __lekf2 is from libgcc (GCC itself). The reason why the __lekf2 behaves differently on P8 and P9 is that we have SW and HW versions for __lekf2, when the underlying "CPU "supports 128-bit IEEE binary floating point instructions.", it will use __lekf2_hw instead of __lekf2_sw, the former still adopts insn xscmpuqp, then it fails. > So it's totally depended on the version of library which is not > controlled by GCC. What's your opinion? So 1) for ppc_float128_hw, it generates xscmpuqp then fails. 2) for !ppc_float128_hw, it uses __lekf2 but the underlying ENV supports __builtin_cpu_supports ("ieee128"), it exploits xscmpuqp, then fails. Ideally we should use one effective target like ppc_ieee128_hw to indicate the underlying ENV supports __builtin_cpu_supports ("ieee128") but I think it may not be worth to adding that at this stage, so I'd suggest xfail-ing it for "ppc_float128_hw || (ppc_cpu_supports_hw && p9vector_hw)". BR, Kewen > > Test result on P9 > make check-gcc-c RUNTESTFLAGS="--target_board=unix'{-mno-float128-hardware}' dg-torture.exp=float128-cmp-invalid.c" > > FAIL: gcc.dg/torture/float128-cmp-invalid.c -O0 execution test > FAIL: gcc.dg/torture/float128-cmp-invalid.c -O1 execution test > FAIL: gcc.dg/torture/float128-cmp-invalid.c -O2 execution test > FAIL: gcc.dg/torture/float128-cmp-invalid.c -O3 -g execution test > FAIL: gcc.dg/torture/float128-cmp-invalid.c -Os execution test > FAIL: gcc.dg/torture/float128-cmp-invalid.c -O2 -flto -fno-use-linker-plugin -flto-partition=none execution test > FAIL: gcc.dg/torture/float128-cmp-invalid.c -O2 -flto -fuse-linker-plugin -fno-fat-lto-objects execution test > > === gcc Summary === > > # of expected passes 7 > # of unexpected failures 7 > > Gui Haochen > Thanks