From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 32F4638582BF for ; Fri, 9 Sep 2022 11:46:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 32F4638582BF Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 032BC22DF1; Fri, 9 Sep 2022 11:46:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1662724018; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YXB+bpcZxETQz2fSCP7yTlnj/08KbQFSi85ZYYkFIGE=; b=rDk1KAwtqHk62CSsCa8eK2zm1LQ4HZWdGyqRidDGxFS5b+HtprSVxYVGLebjaZQ0iMdNHP 8t8c+wJ8lmXQ52hW5Dla/4q+hKwdpLNvdAPyOypREHfs6sLFegPHzS2NQZIiZU3wKsLueL QxNMEOJe1JZtQQCqUAs/yQP0TZh+ncU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1662724018; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YXB+bpcZxETQz2fSCP7yTlnj/08KbQFSi85ZYYkFIGE=; b=/j/gydrrllejNn39CmnaUQBIio32wIz+pRzG8VfQu9hRknimA59uPqd+sa9VvQIy+KGV9q pHQQk8K317PJ8eBA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id ADB8313A93; Fri, 9 Sep 2022 11:46:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id w39VKbEnG2MUGgAAMHmgww (envelope-from ); Fri, 09 Sep 2022 11:46:57 +0000 Message-ID: Date: Fri, 9 Sep 2022 13:46:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH] gcov: Respect tripplet when looking for gcov To: =?UTF-8?Q?Torbj=c3=b6rn_SVENSSON?= , gcc-patches@gcc.gnu.org Cc: hubicka@ucw.cz, nathan@acm.org, ro@CeBiTec.Uni-Bielefeld.DE, mikestump@comcast.net References: <20220909102707.2557434-1-torbjorn.svensson@foss.st.com> Content-Language: en-US From: =?UTF-8?Q?Martin_Li=c5=a1ka?= In-Reply-To: <20220909102707.2557434-1-torbjorn.svensson@foss.st.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-13.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 9/9/22 12:27, Torbjörn SVENSSON wrote: > When testing a cross toolchain outside the build tree, the binary name > for gcov is prefixed with the tripplet. Ok, thanks! Martin > > gcc/testsuite/ChangeLog: > > * g++.dg/gcov/gcov.exp: Respect tripplet when looking for gcov > * gcc.misc-tests/gcov.exp: Likewise > > Signed-off-by: Torbjörn SVENSSON > --- > gcc/testsuite/g++.dg/gcov/gcov.exp | 4 ++-- > gcc/testsuite/gcc.misc-tests/gcov.exp | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/gcc/testsuite/g++.dg/gcov/gcov.exp b/gcc/testsuite/g++.dg/gcov/gcov.exp > index 88acd95c361..04e7a016486 100644 > --- a/gcc/testsuite/g++.dg/gcov/gcov.exp > +++ b/gcc/testsuite/g++.dg/gcov/gcov.exp > @@ -24,9 +24,9 @@ global GXX_UNDER_TEST > > # Find gcov in the same directory as $GXX_UNDER_TEST. > if { ![is_remote host] && [string match "*/*" [lindex $GXX_UNDER_TEST 0]] } { > - set GCOV [file dirname [lindex $GXX_UNDER_TEST 0]]/gcov > + set GCOV [file dirname [lindex $GXX_UNDER_TEST 0]]/[transform gcov] > } else { > - set GCOV gcov > + set GCOV [transform gcov] > } > > # Initialize harness. > diff --git a/gcc/testsuite/gcc.misc-tests/gcov.exp b/gcc/testsuite/gcc.misc-tests/gcov.exp > index 82376d90ac2..a55ce234f6e 100644 > --- a/gcc/testsuite/gcc.misc-tests/gcov.exp > +++ b/gcc/testsuite/gcc.misc-tests/gcov.exp > @@ -24,9 +24,9 @@ global GCC_UNDER_TEST > > # For now find gcov in the same directory as $GCC_UNDER_TEST. > if { ![is_remote host] && [string match "*/*" [lindex $GCC_UNDER_TEST 0]] } { > - set GCOV [file dirname [lindex $GCC_UNDER_TEST 0]]/gcov > + set GCOV [file dirname [lindex $GCC_UNDER_TEST 0]]/[transform gcov] > } else { > - set GCOV gcov > + set GCOV {transform gcov] > } > > # Initialize harness.