From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by sourceware.org (Postfix) with ESMTPS id DDECC3858D32 for ; Wed, 5 Apr 2023 01:29:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DDECC3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x629.google.com with SMTP id o11so33042930ple.1 for ; Tue, 04 Apr 2023 18:29:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680658146; x=1683250146; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4rbiDPz2BVfobCI1Yv8vm867VOIZpVgTQn0GxG3w8CM=; b=kCN1UvEPg2Fut8dyUxlWSeoAvEwf7J7CxPhxP3CP3w/d+o76u9gWY5DUuTyt6KD4ed WXHC9zlqtnH8BK8syJHAlOXp7RCQ31Ntr2CVkkTH6L1URKLk68PtVUaCzCH8nSeh354L kovLRo1BLEEMDbjFT+3ILzgoZdEsl729OJOPbFvwE3seRCUi/RYRKMeSCYb5h/Uy+xmW gUggtNmAAL6Zm2jrBZR36rHt9V4xsxIbss4ech7RgidHdpHlt/vStfhLeENqpxZ8oHDK nlATikFY4NLHadxPoKDYl3HZX+1Sar9d7yC0sPChDinMXan9XPxD1x3UidJfbvj9e82F /zmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680658146; x=1683250146; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4rbiDPz2BVfobCI1Yv8vm867VOIZpVgTQn0GxG3w8CM=; b=3wR38rYRuMSK18tOeQ34/RltIppgUs9t7FunkDsGOfA8rLJmFuOv7Wa7NVfdzm5p9+ Y4nGCpITz0MOXT0TI1IKv/46SQXjO8zBR4XMzl+Ype0UZw7NhksY+hCURUIEoGiiC+4s GKUBn5/k/SgPdlnJrp1JomAXo3rX8exlvfqbb3Nfm1ub2k/qDvUcEYKGK1bNKllef3px /gSR9DNvEVuDTCbbQvb3fK5ui0TUir3f+9lbODoFJstI4dEHObi+Wtu1u5viX/yHfkmP abutbVRI/RVK2GTUmLmXqrrWRSrTV8qXSyvMleiNxYNaicVWK0JZzC4Hy2IlThglkz9+ Wepw== X-Gm-Message-State: AAQBX9eNj13NDgeFWPpUGZTzU6pm06o+s+7M6iiAMwZ8IdyJ6fewpov5 GUdRH4NqHKlcHpKnzo/XpQI= X-Google-Smtp-Source: AKy350Yk+60j+9eFKUbtXSO8vNmZZFcTEz8o1CdaGZl8o6JuK/myGbZscJd8Ctq+TQZugKdttsSSKg== X-Received: by 2002:a05:6a20:3b87:b0:cc:63c6:8d3a with SMTP id b7-20020a056a203b8700b000cc63c68d3amr3454819pzh.41.1680658145705; Tue, 04 Apr 2023 18:29:05 -0700 (PDT) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id b1-20020aa78701000000b0062df30c7e7esm7420879pfo.136.2023.04.04.18.29.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Apr 2023 18:29:05 -0700 (PDT) Message-ID: Date: Tue, 4 Apr 2023 19:29:04 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH] Check hard_regno_mode_ok before setting lowest memory move cost for the mode with different reg classes. Content-Language: en-US To: liuhongt , gcc-patches@gcc.gnu.org Cc: vmakarov@redhat.com References: <20230404051346.1223071-1-hongtao.liu@intel.com> From: Jeff Law In-Reply-To: <20230404051346.1223071-1-hongtao.liu@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/3/23 23:13, liuhongt via Gcc-patches wrote: > There's a potential performance issue when backend returns some > unreasonable value for the mode which can be never be allocate with > reg class. > > Bootstrapped and regtested on x86_64-pc-linux-gnu{-m32,}. > Ok for trunk(or GCC14 stage1)? > > gcc/ChangeLog: > > PR rtl-optimization/109351 > * ira.cc (setup_class_subset_and_memory_move_costs): Check > hard_regno_mode_ok before setting lowest memory move cost for > the mode with different reg classes. Not a regression *and* changing register allocation. This seems like it should defer to gcc-14. jeff