From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa4.mentor.iphmx.com (esa4.mentor.iphmx.com [68.232.137.252]) by sourceware.org (Postfix) with ESMTPS id A64373858016; Wed, 28 Sep 2022 14:26:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A64373858016 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.93,352,1654588800"; d="scan'208";a="83776362" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa4.mentor.iphmx.com with ESMTP; 28 Sep 2022 06:26:19 -0800 IronPort-SDR: Nwks8YWmKD4nLfnguO8ghL0H8T33l83sJvZKWWfrbSyjIW58uqxUAhEMw55/pkFicyTD7TYOrz ezYXtMoEq5Q4H4xTK+yQKuS6cRBT2kNndo8RHrdOiX83jtfbvUUn7AfsUJwKGgioj/tfAXs9dl 5lKR8ShvtL0DVLEf7G+M40EH/mb6s6BC/LyhQ0B6CbvlRakjdKfW6R9rm4MZ1FFclAMOQ6yy89 88LG6QaD5Gkn9ItI11T+dj/YThZArMsstq86+5Bsx4kDpiSydemybYtfRp1bGVPP6yq4twbx7N ta0= Message-ID: Date: Wed, 28 Sep 2022 16:26:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [OG12][PATCH] OpenMP: Fix ICE with OMP metadirectives Content-Language: en-US To: Paul-Antoine Arras , , References: <1696e0a6-52e3-dc61-08a8-eaa26c5c3e1e@codesourcery.com> <0a5da3ce-7b28-fbd1-a0ba-f27c636e1be0@codesourcery.com> From: Tobias Burnus In-Reply-To: <0a5da3ce-7b28-fbd1-a0ba-f27c636e1be0@codesourcery.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-12.mgc.mentorg.com (139.181.222.12) To svr-ies-mbx-12.mgc.mentorg.com (139.181.222.12) X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,KAM_SHORT,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Paul-Antoine, hi all, On 28.09.22 15:47, Paul-Antoine Arras wrote: > Here is a revised patch resulting from your comments. > The only issue that I could not easily fix is the following code > triggering an ICE: [...] > I filed a PR on Bugzilla: > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D107067 > Is it OK for you? Thanks for the update =E2=80=93 LGTM. (We may want to revise some general block handling, but that's something for either upstreaming =E2=80=93 or even after the upstreaming hen fixing t= he PR.) Two minor remarks: (a) Don't forget to update the date in the ChangeLog.omp. (b) On can shorten bug URL by using https://gcc.gnu.org/PR107067 which is, well, shorter. (Similarly, https://gcc.gnu.org/g: or https://gcc.gnu.org/r... for the svn or 'git gcc-descr [--full]' revision number also works.) Tobias ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955