From: Richard Earnshaw <Richard.Earnshaw@foss.arm.com>
To: Murray Steele <murray.steele@arm.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH][GCC] arm: fix __arm_vld1q_z* and __arm_vst1q_p* intrinsics.
Date: Wed, 22 Dec 2021 16:04:49 +0000 [thread overview]
Message-ID: <b3e2f961-d3fc-7169-f855-7c0fcbdf5358@foss.arm.com> (raw)
In-Reply-To: <0ff57aa7-038e-0ef4-abb7-51c4abb3bdb9@arm.com>
On 22/12/2021 15:55, Murray Steele via Gcc-patches wrote:
> Hi All,
>
> This patch fixes the implementation of the existing __arm_vld1q_z* and
> __arm_vst1q_p* MVE intrinsic functions.
>
> The MVE ACLE allows for __ARM_MVE_PRESERVE_USER_NAMESPACE to be defined,
> which removes definitions for intrinsic functions without the __arm_
> prefix. __arm_vld1q_z* and __arm_vst1q_p* are currently implemented via
> calls to vldr* and vstr*, which results in several compile-time errors when
> __ARM_MVE_PRESERVE_USER_NAMESPACE is defined. This patch replaces these
> with calls to their prefixed counterparts, __arm_vldr* and __arm_str*,
> and adds a test covering the definition of __ARM_MVE_PRESERVE_USER_NAMESPACE.
Is there a PR in bugzilla for this?
R.
>
> Regression tested on arm-eabi -- no issues.
>
> Thanks,
> Murray
>
> gcc/ChangeLog:
>
> * config/arm/arm_mve.h (__arm_vst1q_p_u8): Use prefixed intrinsic
> function.
> (__arm_vst1q_p_s8): Likewise.
> (__arm_vld1q_z_u8): Likewise.
> (__arm_vld1q_z_s8): Likewise.
> (__arm_vst1q_p_u16): Likewise.
> (__arm_vst1q_p_s16): Likewise.
> (__arm_vld1q_z_u16): Likewise.
> (__arm_vld1q_z_s16): Likewise.
> (__arm_vst1q_p_u32): Likewise.
> (__arm_vst1q_p_s32): Likewise.
> (__arm_vld1q_z_u32): Likewise.
> (__arm_vld1q_z_s32): Likewise.
> (__arm_vld1q_z_f16): Likewise.
> (__arm_vst1q_p_f16): Likewise.
> (__arm_vld1q_z_f32): Likewise.
> (__arm_vst1q_p_f32): Likewise.
>
> gcc/testsuite/ChangeLog:
>
> * gcc.target/arm/mve/general/preserve_user_namespace_1.c: New test.
>
next prev parent reply other threads:[~2021-12-22 16:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-22 15:55 Murray Steele
2021-12-22 16:04 ` Richard Earnshaw [this message]
2021-12-22 16:21 ` Murray Steele
2023-01-18 12:04 ` Richard Earnshaw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3e2f961-d3fc-7169-f855-7c0fcbdf5358@foss.arm.com \
--to=richard.earnshaw@foss.arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=murray.steele@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).