From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130058.outbound.protection.outlook.com [40.107.13.58]) by sourceware.org (Postfix) with ESMTPS id A7AED3853D71 for ; Mon, 21 Nov 2022 14:59:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A7AED3853D71 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=siemens.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Bad4qNn9OdOfXu8pr4q9wNzkjTpCsEvKDasUNl7OxZ9hxuhlSGeA5zJD7mic+Huf81PFVbfNNoRkK/Ksdyi+Nk//VIHk6d+ogQ6DYrZu9wlfgDJrCvZaj4aFZMOEnSULgN4QdEA3iV0bo38Wa774asNn9ocLxT5/4HCkvbEPW/H/JSRoWvYr68LaKUdoIfjq2IgKufgya++jgMEj06JW57PEAC8M7dH29W0gv0gkR1lJ/A9pCThvMBeARf1dG1NKTJ7qrL9hM6NMFzv4eN9DOtpCKD07/iXH5Z/3VEzBUnTH2E9zOuMvFXmWyIMnPEgjwRNbzAsEaQxJXP/ZwL/FYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=B+TBPjNDrf5DNjnLTmQfYZ6DpVDaTmjYDsKn9FsdmGE=; b=P760DctoclHDbafIOJYs88Il0FtdOzt0N/3tG+ZvHAyxaCcs+8WWSsjZXR/v9XD7mRK7LmgqG6lmXAeUncbjtSeVBC3RgACNAL/p+udNBKb5W29T9jY1KxdVs0zywPQGkZTqwsIOwFBQ4/9PsOHcsh/P7cd2oGXzGC0zLhrAAvdxnaLir4sMbNqRajRTwzhxwuuxsq7RAVEH1DD1cInTrPLMP8w2i1WYwlWf5uf0AFwrne2cOkaLSu7VIdsZlBugtdkSAvmunG+C9HfyNsU9itOZLLnKQT2DkPkulkj6zMnrVDdxNRw1o4MHzp6pfA6iny9OacksaPHkLHVoyR8ZmA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B+TBPjNDrf5DNjnLTmQfYZ6DpVDaTmjYDsKn9FsdmGE=; b=zHw8fnYpRVil4sZbL2I2kBPi7YJOKXE4HTuSYeDAqkYxG5LB3uUeXKzNO+AQzsthsxe7DFV+KAYEcE/9EGUFlTl0gIJt/Ed1v16ALuWYT7BIjWECeBdY41V4xMF+GSN3Loa7H5idYk05yck4K1w7hB2Ztwe+2xCJPtBfyANT/gXg24gztBGoMTGiT2Y+TBLlxbzJlsWHqAt1r6MnJoOqLcLWqBvcbOaGTX6EejlQogMRsLf8VxbjJnO1j7ddnnv+LbHa6UHtJeGJEUemuUHbqiXwqMnAZlAC7salpss19dyDPTZANCwpInpXbKfdmb7AEEXhwnmXragJQx4oJMQfTw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from DB8PR10MB3676.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:13c::18) by AM0PR10MB3697.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:155::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.15; Mon, 21 Nov 2022 14:59:01 +0000 Received: from DB8PR10MB3676.EURPRD10.PROD.OUTLOOK.COM ([fe80::ad67:5dcd:eb68:bf68]) by DB8PR10MB3676.EURPRD10.PROD.OUTLOOK.COM ([fe80::ad67:5dcd:eb68:bf68%4]) with mapi id 15.20.5834.015; Mon, 21 Nov 2022 14:59:01 +0000 Message-ID: Date: Mon, 21 Nov 2022 14:58:59 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [Patch] gcn: Add __builtin_gcn_{get_stack_limit,first_call_this_thread_p} Content-Language: en-GB To: Tobias Burnus , Andrew Stubbs , gcc-patches References: <1bec26d6-e2c5-3408-4f61-0fb17e730b3e@codesourcery.com> <2249a729-d961-3939-bc63-8c7564e03dd0@codesourcery.com> From: "Stubbs, Andrew" In-Reply-To: <2249a729-d961-3939-bc63-8c7564e03dd0@codesourcery.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB6PR0802CA0038.eurprd08.prod.outlook.com (2603:10a6:4:a3::24) To DB8PR10MB3676.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:13c::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB8PR10MB3676:EE_|AM0PR10MB3697:EE_ X-MS-Office365-Filtering-Correlation-Id: f56bab02-87f6-4080-ad68-08dacbd0ecaa X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1epr6Bvkeztj4oRuHFkgyEuAQsddUD+hlIkspkCjOckxqAUVV9JcvE3RlYBgHu/feI7Qmw2dsyhofKOruRPZpw5lw1OgAY16dnJHlvcdBgwsLC7fP3aUNQv4b2P96gy1IQMNxTkfiR8p63LP0GFKcQd429a+6mueI3FgbxmzqG+Q/XHUCDUZHzz+TW4TVcWDBce+JnXJrwYoFwjNZWMp3mfWBZLNh7pxUCjtwAMSDOvnRQEAKYuRq1Np+QZFYGp1tc8DT45o1JNnevroe48mMpxbZZYq4yUZg3jWm17K7hToUGRA3+xqH2AvE13rvW57DEyp/IUQaJS4lM2R1NDfbRcmCINn2sgcchL6uXQ5ttynn7tqOBI4xQYFgGnKAGM5Du8xmARWcjK5r5fF/LQMT5VsqKbJYtB7H5fLKaba498A/n7zVRbpWMnuMTvRGZXXk/XJwaWBjwhOuR01S9MS2gPBZKuIm5qLHx4xlzEer68chRdkQn+JliT4W9URWjslRXai3an9+yQvkl65xzKppZF9hxNV9ELOQFyWYafilKR/hBx3B6Wl5m90MwK4K9RYBq4M7Xm6emzRSOtpzE6gxs7aZ+CUlms02O0iR6CLSDaBNW3+E3PU3aav+hEYzg2Y8DDhFv4k77L0h7ds4p9+oHOQ4XUi03Ap9Lp0+u2cDviZJslM6Kz/Sqx9vrbnOYQiseuhF4+bY2xlITYdwsXmmwbogs1GMHTa3xKNtXhWYxc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR10MB3676.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(346002)(396003)(136003)(39860400002)(376002)(451199015)(31686004)(66899015)(36756003)(86362001)(31696002)(82960400001)(38100700002)(2906002)(8936002)(66476007)(66556008)(66946007)(6486002)(5660300002)(8676002)(53546011)(110136005)(41300700001)(316002)(83380400001)(186003)(2616005)(26005)(6512007)(6506007)(478600001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c1R0bHNqTWpBSjRwR0tHaTdFMHAxWnllNnBDdk5CN0sxTWgwUkEzTlNwcGhO?= =?utf-8?B?a2xRWVNoZzFVWnJzb2NWV0RyaEtYdnU0QXVsTXF0REF0OWVGV1hmc011ZXJu?= =?utf-8?B?Vk83VWRGN3B0RFdUWXBFalU5MHNzWGx5ejRNa2pVSkd1aWJtOUI2aGtsMGJQ?= =?utf-8?B?UjF5NXNyRC9GSmlUTmVSQit3N3hnNFhCS1FhN0Izc0E4dUV6RjJaanhHNEZz?= =?utf-8?B?NXA5cmRKOXFZaTJJV2l6VEh2WktySXI3MEJXMDZVaDd3SnM1NWlybjVpSzZE?= =?utf-8?B?UThZYmV3T21pVGlISDZpc0h5WGJaejlBdVFQTGRnNnMrM2kzcE9GY3NDS05j?= =?utf-8?B?YnJiRjRYTTBGNThadFRiZFh6bms0dUJkNXhNeWxSdGVSbkttaHM2QmZJbzRi?= =?utf-8?B?bUl5aitqSlhZYVVTK0MyR21WUm1ZbHV4VldyUXF6RDl6ZU10aWhveXpWTTBB?= =?utf-8?B?Y2FNeDRlb1lDd3lCelhnOTVGV29HL3pkbkpocEl1c2w5aFZSWnI2MXJ3TEZ4?= =?utf-8?B?MkxxSEdzcUovbkg5SFNTMFdqMW1UK3lYcjIyM0l3OXlNaEhQZnNHZ2RZNnkw?= =?utf-8?B?RTIyRjFhbURZZEV6S3QwVzUvanVCMGxwa3J4aFNtTEE2YzF3d1llMWU5ZkJ3?= =?utf-8?B?TFMzN2dBQkx0dWJ4RWpvVGU4ZVV6ejEwWXRNSXhlOWpUM1YwZkdzczR1RWZu?= =?utf-8?B?bkRzQUdDRi9IZVlBajFaQ2sxdnFpVm5HQVVQbmhOOWQ3cTZPRzZrVXZ6dW4z?= =?utf-8?B?OGR3SDY5UlQyMUJBb3NybU4yRXNVYUJFamdNNmJMSjNLYlNiS1VUUitvbmN3?= =?utf-8?B?UFd6Y0VxS1N4bFY3Y1Y5S3BNYTFrWmN2RFVHaC85ampoR2xHZkxwcjU4blls?= =?utf-8?B?dlhIOGphZWR5QmZ4cnp4QlhNUFdOb3BFY0svSnppNGRLVlcxUjdyWWIyb1g4?= =?utf-8?B?djBKVCswZHUyVTR2QWxUL0RIVlB0dy80dGoySzBYUVNSWjEwb1NqTlRhc01N?= =?utf-8?B?M2w2WUFELzE4MWRkcXZSYlJYRWZKQmdvYjI1ZnFyOEw0eUtMaUFwNlNOd0I2?= =?utf-8?B?a252cVpDM2lwU0grc0RMSm1tM2JrcHdjNHJ6SnZWd1lOQVF2YWZmWFJESjcy?= =?utf-8?B?djBWNmppUzlqSEdWclNIaUF5WnZGOEZpa0kwUW1SWmRRSzh2VnBwb3FZS0tT?= =?utf-8?B?R1BQUlJrWnJXbVdkdDlIcUlLU2taUGk4L2JkYUxmWjUxcXdLQjhHSFBHYXp4?= =?utf-8?B?RVVoakVpM3czbHZQSmw0a3piSkVoMkQ4NWN4OVJTZ2VGS2sxRzZKS0pXZ3I4?= =?utf-8?B?NFh1VVJLdmZxT0oyRzczeE12UW9SaWxYZ3M1aE5hck1BREZnc3Q2ZFR1allI?= =?utf-8?B?NmJoTGJQc3BFeHZuOUU4QmJjZlNvZXl2UllXa051V2l5aGNWVnFxMUVUS1Az?= =?utf-8?B?dGltQlp0MXdVYytMQXVSbWlxcnczRmtSMDFRQXo5bzR1UmpXV0JsRGZFSTF3?= =?utf-8?B?amtyemRmSXZJNm5RUjNWWmZyNW9hVXpMV3JneXdoYkJZT0YwUEVXZERwdWVO?= =?utf-8?B?V1g4NXQzK3creS9ndm9sdFFFaTZwbmNIaUZQdzYzTzArVnZKOU9uMW1Wb2JK?= =?utf-8?B?TVF6ZzNpVE9VRVRKdElXTGp5SXAwWm41OFBGejlPakg3RGdCTGVqUXlsRWhK?= =?utf-8?B?bmJwSENZK2tTSzhIdEdRUGlsWmMweW9Pc2dxMG8veXB5U3NhbW1PRU1yeXE3?= =?utf-8?B?RitoZUxMQ2ttMEpBRUx5R2JNYkgyTGxnQmQ4YVFtYmN5L3c0enhxV3V6VDRD?= =?utf-8?B?UzRoZGN2SXQwdmJMaGdiRDE3SEFETXFTTTFQUjArRWR0eDJOeFNKY2hzVVlx?= =?utf-8?B?eVltZ2U2VkFSMUpPMXkvUk1CRTlHWkFxR3UrbEV4VTRSZTVRZUI0clZkcHZG?= =?utf-8?B?elRKUEpNM3lBQVBTajVUU0VtcFRqY0VIbVFjVGdhdUR5R0VTbFBxWEg4SjFZ?= =?utf-8?B?ZGsxUzI4REpnSTRjdTdpMVRZNXBpU3k2d0FCNHdoY3VKV2tuSVFpTWhpRHNB?= =?utf-8?B?K3VSaysxSHIvbEJZMXR5WW52TDdDS0RQTGFzcllwTW1nNG5zNlJrY21UbUgz?= =?utf-8?B?SzhsZkVmOFQ3RHNzdTBMRUpSbFA5WmFNZldCQzdvM29pRTZRYnhzcFpaVkl3?= =?utf-8?B?Q1E9PQ==?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: f56bab02-87f6-4080-ad68-08dacbd0ecaa X-MS-Exchange-CrossTenant-AuthSource: DB8PR10MB3676.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2022 14:59:01.5121 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JbkRdIrv6Ji4PxnFkHYTgAxuE1SvTltyNmEgNRtHZJMyNXJUFNfWPixN4uSbf04Ez5LgGu0vHNF42DYjktRVOpKwLTrgpOSuTE5AE7bCS0o= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR10MB3697 X-Spam-Status: No, score=-0.1 required=5.0 tests=BAYES_00,BODY_8BITS,DKIMWL_WL_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 21/11/2022 13:41, Tobias Burnus wrote: > On 19.11.22 11:46, Tobias Burnus wrote: >>> +       stacklimit = stackbase + seg_size*64; >> (this should be '*seg_size' not 'seg_size' and the name should be >> s/seg_size/seg_size_ptr/.) > I have updated the comment and ... >> (Reading it, I think it should be '..._MEM(SImode,' and >> '..._MULT(SImode' instead of DImode.) > Additionally, there was a problem of bytes vs. bits in: >> My understanding is that >> dispatch_ptr->private_segment_size == *((char*)dispatch_ptr + 192) > > which is wrong - its 192 bits but only 24 bytes! > > Finally, in the first_call_this_thread_p() call, I mixed up EQ vs. NE at > one place. > > BTW: It seems as if there is no problem with zero extension, if I look > at the assembler result. > > Updated version. Consists of: GCC patch adding the builtins, > the newlib patch using those (unchanged; used for testing + to be > submitted), and > a 'test.c' using the builtins and its dump produced with amdgcn's > 'cc1 -O2' to show the resulting assembly. > > Tested with libgomp on gfx908 offloading and getting only the known fails: > (libgomp.c-c++-common/teams-2.c, libgomp.fortran/async_io_*.f90, > libgomp.oacc-c-c++-common/{deep-copy-10.c,static-variable-1.c,vprop.c}) > > OK for mainline? OK, provided it has been tested in both stand-alone and offload modes, and the newlib tests too. Andrew