public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeff Law <law@redhat.com>
To: Andrew Pinski <pinskia@gmail.com>,
	JiangNing OS <jiangning@os.amperecomputing.com>
Cc: Richard Biener <richard.guenther@gmail.com>,
	"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] improve ifcvt optimization (PR rtl-optimization/89430)
Date: Fri, 12 Jul 2019 16:11:00 -0000	[thread overview]
Message-ID: <b40918e6-7569-fdf9-c686-3caac096c446@redhat.com> (raw)
In-Reply-To: <CA+=Sn1mcpxv7YYq48rrYvG-Sm-0F3ROhNy=1fD17A7KwjvLcMg@mail.gmail.com>

On 7/11/19 10:08 PM, Andrew Pinski wrote:
> On Mon, Jul 8, 2019 at 12:39 AM JiangNing OS
> <jiangning@os.amperecomputing.com> wrote:
>>
>> Hi Jeff and Richard B.,
>>
>> Following your tips, I've found a much simpler solution in tree-ssa-phiopt.c. Attached is the new patch. Review again, please!
> 
>   /* Prove that we can move the store down.  We could also check
>      TREE_THIS_NOTRAP here, but in that case we also could move stores,
>      whose value is not available readily, which we want to avoid.  */
> 
> I think the comment above the change needs to be changed or extended slightly.
Actually, I don't think that comment needs to change.  But the one
before cond_store_replacement needs minor updating which I'll take care of.

My reasoning is that addressables in the local stack are most likely
going to already have their lines in the cache and thus are available
readily.


Jeff

  reply	other threads:[~2019-07-12 16:05 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-15  8:22 JiangNing OS
2019-03-18 21:53 ` Jeff Law
2019-04-30 16:00 ` Jeff Law
2019-05-05  0:11   ` JiangNing OS
2019-05-24 14:54 ` Kyrill Tkachov
2019-06-17  0:36   ` JiangNing OS
2019-06-17 21:59 ` Jeff Law
2019-06-20  9:53   ` JiangNing OS
2019-06-20 23:13     ` Jeff Law
2019-06-21 12:24       ` Richard Biener
2019-06-21 16:10         ` Jeff Law
2019-07-08  7:43           ` JiangNing OS
2019-07-12  5:22             ` Andrew Pinski
2019-07-12 16:11               ` Jeff Law [this message]
2019-07-12 16:40             ` Jeff Law

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b40918e6-7569-fdf9-c686-3caac096c446@redhat.com \
    --to=law@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jiangning@os.amperecomputing.com \
    --cc=pinskia@gmail.com \
    --cc=richard.guenther@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).