From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by sourceware.org (Postfix) with ESMTPS id ED4943858D1E for ; Sat, 25 Mar 2023 18:09:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ED4943858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x631.google.com with SMTP id ix20so4674909plb.3 for ; Sat, 25 Mar 2023 11:09:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679767749; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Hi6gb18Qy/k6csaJlSuOWHuwtulN2bhqYFwB4WLmoec=; b=c8b54aU/LGq2uh1JXG/QXLIbNS3vRMkgltWn0oisXg7rtl9oB13CdBoixxxJx8zHLm tyDhXDZOp6n9jPt70dfacbSNoi5WhjIJugOBYm7X4758AXhUXhu6nBUERgQk9B57i8p1 RAj3uvNktPeN4c30wl1JCOlw7PicmKrIvO2ckDIpB9GsqCCda3s72wl7dcXsj3aOjPnT AwM0+kFoQVJvD8x+M3wFBcsuW4CUBUMkS0pbQWPsMqPi+UUUk8YFv0g2qyPZw1ejXMH3 c3qu2OH9kT7mtpfimTJVVpzQW8RL2n293cbXJGwZZcKfOpu/AoiF2BcoV0o5RRGEmNyl A6JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679767749; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Hi6gb18Qy/k6csaJlSuOWHuwtulN2bhqYFwB4WLmoec=; b=WJoNdsBsuP7h8gRg4ZNAPe0uOcJ7bSfGpb8UtmAU1tqGdBjZlJoolOSFDZItQd67oJ /qlseyygxMHfrANVzb+w2XvK+MBl+xy5ScJslXOd/LMZ2yYo9ewZTKVpBYtFYgigm61j ndd+8cHOPzIb7HloPR+9iQDU9UxoVmRozKAEIoZmsGpqQ/nlRJX1B1GBD8EHkMFVP8aN qTNqRh4bN0Y+Tq8STDDNur66xOW7Pvd3xyNmJuvaGxV7rkaaBTd1Z/uxs2p9wIwt9EqJ MqQelTKoT4hY8wSeum09TvX9wP2nGOSEm5hm2QvMAo2hWjO3KIH1cYbkYwAxnPZC2JeO hzdw== X-Gm-Message-State: AAQBX9e6i7sezGzPWAEvalDO+gdw25F3poZW5zLam1pBZpggUJkmUW4j mSNuOo67llL5kFIHtLC6Hug= X-Google-Smtp-Source: AKy350Y7WmEAs6/ZOqhaldlxPXHef76trH7fLbYt+dT4lTi4GT8pTn/O1zWeVRm6i5IsLhn57VlZ7g== X-Received: by 2002:a17:903:181:b0:1a1:f0ad:8657 with SMTP id z1-20020a170903018100b001a1f0ad8657mr7495078plg.37.1679767748706; Sat, 25 Mar 2023 11:09:08 -0700 (PDT) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id w5-20020a1709029a8500b001a064cff3c5sm16189712plp.43.2023.03.25.11.09.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 25 Mar 2023 11:09:08 -0700 (PDT) Message-ID: Date: Sat, 25 Mar 2023 12:09:06 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH] rtl-optimization: ppc backend generates unnecessary signed extension. Content-Language: en-US To: Peter Bergner , Ajit Agarwal , gcc-patches Cc: Segher Boessenkool , Richard Biener , Raphael Zinsly References: <4c0b6b4f-bbc1-8dd0-a91c-ffed028b4873@linux.ibm.com> <365cfb50-4313-d44e-6ffc-77473b20c670@linux.ibm.com> <5834b0cb-dd25-c55f-2cf6-9aa6b8372724@linux.ibm.com> <29ab8ff7-20d5-183f-a0ce-c82758488b64@linux.ibm.com> <1a482ac5-404b-0787-c682-b10d13dc76ee@gmail.com> <247f5af3-5db3-4a73-b636-95e006a3a649@linux.ibm.com> <0caf5e53-76e2-afc6-8b8c-363e56cd8212@linux.ibm.com> From: Jeff Law In-Reply-To: <0caf5e53-76e2-afc6-8b8c-363e56cd8212@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/24/23 15:34, Peter Bergner wrote: > On 3/23/23 6:12 PM, Jeff Law via Gcc-patches wrote: >>>>> Is there a reason why REE cannot see that our (reg:QI 4) is a param register >>>>> and thus due to our ABI, already correctly sign/zero extended? >>>> >>>> I don't think REE has ever considered exploiting ABI constraints. Handling >>>> that might be a notable improvement on various targets. It'd be a great >>>> place to do some experimentation. >>> >>> Ok, so sounds like a good follow-on project after this patch is reviewed >>> and committed (stage1). Thanks for your input! >> >> Agreed. I suspect that risc-v will benefit from such work as well. >> With that in mind, if y'all start poking at this, please loop in Raphael >> (on cc) who's expressed an interest in this space. > > Will do. I suspect that it'll be best to come up with some generic interface > using target hooks like "param regs are sign/zero extended" or "call return > values are sign/zero extended", etc. that targets can conditionally opt into > depending on their ABI that is in effect. I wonder if we already have some of this in place via the ABI interfaces. Or if the ABI interfaces could be slightly revamped to utilize the same information as REE. That way there's a single source of truth for this aspect of the ABI. But we can cross that bridge when we start poking around. jeff