From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x12d.google.com (mail-il1-x12d.google.com [IPv6:2607:f8b0:4864:20::12d]) by sourceware.org (Postfix) with ESMTPS id 185603858C41 for ; Wed, 20 Dec 2023 18:16:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 185603858C41 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 185603858C41 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::12d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703096178; cv=none; b=wDll0dP+/80Gg4dxEhy/iOUxw1QcwMSSQXAtpESfhxMQQOILP2KQG4Iifb38tpcjuUtKF4uMIa5v3geBBZerN37Szcl44xCUh2+CsWPZXCAOcvbo4dt+MfNa3Tl5Vnvwun0D6lDhTcOpO0E5a3eEhK5z/egUJ19F+lRBqFLWLes= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703096178; c=relaxed/simple; bh=Hpe6qQKd87AChwTQkQQS5kGamThyCQfR1tEHunralQ4=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=URZujEBJdFCmGiegjo5Tbk0LHEwc8fj8FSpjZ3MLmCo0ZcYa0g0MwToW4XygOPvHI/H67dsCgYhW5wJeRyfb/8caLWu9ny1YOBH4jDEiKPpPL5U8ToPInpMIwTWPvFpRRhkD+EVNf03tzickSSGkXjmRDhuNf3x8sQnEGl/ig/k= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-il1-x12d.google.com with SMTP id e9e14a558f8ab-35fc1a21f60so9381305ab.0 for ; Wed, 20 Dec 2023 10:16:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703096176; x=1703700976; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=dyuP80o69lvka2zmOhrxiNpSueFV1ZrmJA1Pd3YC/jM=; b=bzTEtP3K6DjncGkIzsCJ4AqvFO075exwWPAY9rbzSPXdCQs+g38WvxbROiU1XNbtMB JqmoKOmKo13flOhJvkyPSuRJM9vy8i2V4SBU95/wv1JxivoRRl62NCMU4Aqm1NRnWHa4 gD1ctm3XL/qS10c1L1XgFGv2h1LbnzkWWrMljc8wHaaBX+9JxycLBv0X1S1Q7xF8LHql UBNADdWqoCJpiY7owjhYlVYyGqwTN3YmTi7q/4DwNzcYz0lnsW2TuHl0eZbx3AUcpkWq mbuUvzTgjajvoMF5YHfj5g9ldwVeUNMgloJM61jJdnh3XzcWMfUbHBbkjtoMga3O+Bf5 G37g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703096176; x=1703700976; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dyuP80o69lvka2zmOhrxiNpSueFV1ZrmJA1Pd3YC/jM=; b=wx6Ir+HuyDbz1rhT9XiPqGQ+BmL5RZtxbf1dgZEvCJArAQpjuq1mtUefAH1YOsVtqI V3ONr5kWfIj4wJrrMOVdIjxS19E//snAfi3XmMskY+MzY3ZlvsjTknh/dBKmkaVgycpA d3hSlhCXPP3li/JbAxZT/NXWWB0u70U5+dbikvGUxOD8Rnxbbf+IqMM8KnsBKu2t3ZQZ sTZTeikQAEMkb3DeniNF8d+VPzyBSwz7gQWZkqzylDLpg5KuPf7jafcL/FY55qNeultc XJjrLIAlsAZQlYstPJaWkchd0TeR9pK8AK1907e91b1ZoMWu1k6fxfKyHjwQDzF1RHUF QvbQ== X-Gm-Message-State: AOJu0YwuLzyxh1lQwQlnMNeHoAtB6BbBbUckkJmSsQPcNjsssqepjlyc SqvQl9MO/Liiavu3AevZWe0= X-Google-Smtp-Source: AGHT+IFV4gqTkP6+wndWaWtAsR5javqh1l3p4oK1/6zc+j82QVyXPldp7oIhL6528WmrCq0Vzj2JQA== X-Received: by 2002:a05:6e02:20ee:b0:35d:5995:903f with SMTP id q14-20020a056e0220ee00b0035d5995903fmr17885349ilv.50.1703096176103; Wed, 20 Dec 2023 10:16:16 -0800 (PST) Received: from [172.31.0.109] ([136.36.72.243]) by smtp.gmail.com with ESMTPSA id i7-20020a056e021b0700b0035fce97d25bsm10720ilv.71.2023.12.20.10.16.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Dec 2023 10:16:15 -0800 (PST) Message-ID: Date: Wed, 20 Dec 2023 11:16:13 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/6] RISC-V: Split csr_operand in predicates.md for vector patterns. Content-Language: en-US To: "Jun Sha (Joshua)" , gcc-patches@gcc.gnu.org Cc: jim.wilson.gcc@gmail.com, palmer@dabbelt.com, andrew@sifive.com, philipp.tomsich@vrull.eu, christoph.muellner@vrull.eu, juzhe.zhong@rivai.ai, Jin Ma , Xianmiao Qu References: <20231220122055.343-1-cooper.joshua@linux.alibaba.com> <20231220122732.449-1-cooper.joshua@linux.alibaba.com> From: Jeff Law In-Reply-To: <20231220122732.449-1-cooper.joshua@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,MEDICAL_SUBJECT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/20/23 05:27, Jun Sha (Joshua) wrote: > This patch splits the definition of csr_operand in predicates.md. > The newly defined vector_csr_operand has the same functionality > as csr_operand but can only be used in vector patterns, so that > changes for vector will not affect scalar patterns in files > like riscv.md. > > gcc/ChangeLog: > > * config/riscv/predicates.md (vector_csr_operand): > Define vector_csr_opeand for vector. > * config/riscv/vector.md: > Use newly defined csr_operand for vector. So do you envision changing something in vector_csr_operand? If not, then this doesn't make much sense. Jeff